# git rev-parse -q --verify 99793e64b815ec88daa9955c6347bd541e78543b^{commit}
99793e64b815ec88daa9955c6347bd541e78543b
already have revision, skipping fetch
# git checkout -q -f -B kisskb 99793e64b815ec88daa9955c6347bd541e78543b
# git clean -qxdf
# < git log -1
# commit 99793e64b815ec88daa9955c6347bd541e78543b
# Author: Michael Ellerman <mpe@ellerman.id.au>
# Date:   Mon Mar 16 22:32:32 2020 +1100
# 
#     powerpc/64: Prevent stack protection in early boot
#     
#     The previous commit reduced the amount of code that is run before we
#     setup a paca. However there are still a few remaining functions that
#     run with no paca, or worse, with an arbitrary value in r13 that will
#     be used as a paca pointer.
#     
#     In particular the stack protector canary is stored in the paca, so if
#     stack protector is activated for any of these functions we will read
#     the stack canary from wherever r13 points. If r13 happens to point
#     outside of memory we will get a machine check / checkstop.
#     
#     For example if we modify initialise_paca() to trigger stack
#     protection, and then boot in the mambo simulator with r13 poisoned in
#     skiboot before calling the kernel:
#     
#       DEBUG: 19952232: (19952232): INSTRUCTION: PC=0xC0000000191FC1E8: [0x3C4C006D]: addis   r2,r12,0x6D [fetch]
#       DEBUG: 19952236: (19952236): INSTRUCTION: PC=0xC00000001807EAD8: [0x7D8802A6]: mflr    r12 [fetch]
#       FATAL ERROR: 19952276: (19952276): Check Stop for 0:0: Machine Check with ME bit of MSR off
#       DEBUG: 19952276: (19952276): INSTRUCTION: PC=0xC0000000191FCA7C: [0xE90D0CF8]: ld      r8,0xCF8(r13) [Instruction Failed]
#       INFO: 19952276: (19952277): ** Execution stopped: Mambo Error, Machine Check Stop,  **
#       systemsim % bt
#       pc:                             0xC0000000191FCA7C      initialise_paca+0x54
#       lr:                             0xC0000000191FC22C      early_setup+0x44
#       stack:0x00000000198CBED0        0x0     +0x0
#       stack:0x00000000198CBF00        0xC0000000191FC22C      early_setup+0x44
#       stack:0x00000000198CBF90        0x1801C968      +0x1801C968
#     
#     So annotate the relevant functions to ensure stack protection is never
#     enabled for them.
#     
#     Fixes: 06ec27aea9fc ("powerpc/64: add stack protector support")
#     Cc: stable@vger.kernel.org # v4.20+
#     Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
# < /opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux-gcc --version
# < /opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux-ld --version
# < git log --format=%s --max-count=1 99793e64b815ec88daa9955c6347bd541e78543b
# < make -s -j 32 ARCH=arm64 O=/kisskb/build/powerpc-next_arm64-defconfig_arm64-gcc5.4 CROSS_COMPILE=/opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux-  defconfig
# < make -s -j 32 ARCH=arm64 O=/kisskb/build/powerpc-next_arm64-defconfig_arm64-gcc5.4 CROSS_COMPILE=/opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux-  help
# make -s -j 32 ARCH=arm64 O=/kisskb/build/powerpc-next_arm64-defconfig_arm64-gcc5.4 CROSS_COMPILE=/opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux-  olddefconfig
# make -s -j 32 ARCH=arm64 O=/kisskb/build/powerpc-next_arm64-defconfig_arm64-gcc5.4 CROSS_COMPILE=/opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux-  
arch/arm64/Makefile:27: ld does not support --fix-cortex-a53-843419; kernel may be susceptible to erratum
arch/arm64/Makefile:35: LSE atomics not supported by binutils
In file included from /kisskb/src/include/linux/rwsem.h:16:0,
                 from /kisskb/src/include/linux/notifier.h:15,
                 from /kisskb/src/include/linux/clk.h:14,
                 from /kisskb/src/drivers/tty/serial/sh-sci.c:20:
/kisskb/src/drivers/tty/serial/sh-sci.c: In function 'sci_dma_rx_submit':
/kisskb/src/include/linux/spinlock.h:288:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
   _raw_spin_unlock_irqrestore(lock, flags); \
   ^
/kisskb/src/drivers/tty/serial/sh-sci.c:1348:16: note: 'flags' was declared here
  unsigned long flags;
                ^
/kisskb/src/drivers/i2c/busses/i2c-sh_mobile.c: In function 'sh_mobile_i2c_isr':
/kisskb/src/drivers/i2c/busses/i2c-sh_mobile.c:399:26: warning: 'data' may be used uninitialized in this function [-Wmaybe-uninitialized]
   pd->msg->buf[real_pos] = data;
                          ^
/kisskb/src/drivers/i2c/busses/i2c-sh_mobile.c:372:16: note: 'data' was declared here
  unsigned char data;
                ^
Completed OK
# rm -rf /kisskb/build/powerpc-next_arm64-defconfig_arm64-gcc5.4
# Build took: 0:05:26.215499