# git rev-parse -q --verify 5076190daded2197f62fe92cf69674488be44175^{commit} 5076190daded2197f62fe92cf69674488be44175 already have revision, skipping fetch # git checkout -q -f -B kisskb 5076190daded2197f62fe92cf69674488be44175 # git clean -qxdf # < git log -1 # commit 5076190daded2197f62fe92cf69674488be44175 # Author: Linus Torvalds # Date: Tue Mar 17 11:04:09 2020 -0700 # # mm: slub: be more careful about the double cmpxchg of freelist # # This is just a cleanup addition to Jann's fix to properly update the # transaction ID for the slub slowpath in commit fd4d9c7d0c71 ("mm: slub: # add missing TID bump.."). # # The transaction ID is what protects us against any concurrent accesses, # but we should really also make sure to make the 'freelist' comparison # itself always use the same freelist value that we then used as the new # next free pointer. # # Jann points out that if we do all of this carefully, we could skip the # transaction ID update for all the paths that only remove entries from # the lists, and only update the TID when adding entries (to avoid the ABA # issue with cmpxchg and list handling re-adding a previously seen value). # # But this patch just does the "make sure to cmpxchg the same value we # used" rather than then try to be clever. # # Acked-by: Jann Horn # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 5076190daded2197f62fe92cf69674488be44175 # < make -s -j 160 ARCH=x86 O=/kisskb/build/linus_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # < make -s -j 160 ARCH=x86 O=/kisskb/build/linus_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- help # make -s -j 160 ARCH=x86 O=/kisskb/build/linus_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- olddefconfig # make -s -j 160 ARCH=x86 O=/kisskb/build/linus_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- Completed OK # rm -rf /kisskb/build/linus_x86-allmodconfig_x86_64-gcc8 # Build took: 0:06:31.307039