# git rev-parse -q --verify 5076190daded2197f62fe92cf69674488be44175^{commit} 5076190daded2197f62fe92cf69674488be44175 already have revision, skipping fetch # git checkout -q -f -B kisskb 5076190daded2197f62fe92cf69674488be44175 # git clean -qxdf # < git log -1 # commit 5076190daded2197f62fe92cf69674488be44175 # Author: Linus Torvalds # Date: Tue Mar 17 11:04:09 2020 -0700 # # mm: slub: be more careful about the double cmpxchg of freelist # # This is just a cleanup addition to Jann's fix to properly update the # transaction ID for the slub slowpath in commit fd4d9c7d0c71 ("mm: slub: # add missing TID bump.."). # # The transaction ID is what protects us against any concurrent accesses, # but we should really also make sure to make the 'freelist' comparison # itself always use the same freelist value that we then used as the new # next free pointer. # # Jann points out that if we do all of this carefully, we could skip the # transaction ID update for all the paths that only remove entries from # the lists, and only update the TID when adding entries (to avoid the ABA # issue with cmpxchg and list handling re-adding a previously seen value). # # But this patch just does the "make sure to cmpxchg the same value we # used" rather than then try to be clever. # # Acked-by: Jann Horn # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi-ld --version # < git log --format=%s --max-count=1 5076190daded2197f62fe92cf69674488be44175 # < make -s -j 80 ARCH=arm O=/kisskb/build/linus_rpc_defconfig_arm-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi- rpc_defconfig # < make -s -j 80 ARCH=arm O=/kisskb/build/linus_rpc_defconfig_arm-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi- help # make -s -j 80 ARCH=arm O=/kisskb/build/linus_rpc_defconfig_arm-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi- olddefconfig # make -s -j 80 ARCH=arm O=/kisskb/build/linus_rpc_defconfig_arm-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi- /kisskb/src/fs/fat/dir.c: In function 'fat_ioctl_filldir': /kisskb/src/fs/fat/dir.c:759:43: internal compiler error: Max. number of generated reload insns per insn is achieved (90) FAT_IOCTL_FILLDIR_FUNC(fat_ioctl_filldir, __fat_dirent) ^ /kisskb/src/fs/fat/dir.c:714:9: note: in definition of macro 'FAT_IOCTL_FILLDIR_FUNC' struct dirent_type __user *d2 = d1 + 1; \ ^ Please submit a full bug report, with preprocessed source if appropriate. See for instructions. make[3]: *** [/kisskb/src/scripts/Makefile.build:267: fs/fat/dir.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:505: fs/fat] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1683: fs] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:180: sub-make] Error 2 Command 'make -s -j 80 ARCH=arm O=/kisskb/build/linus_rpc_defconfig_arm-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_rpc_defconfig_arm-gcc4.9 # Build took: 0:00:37.490374