# git rev-parse -q --verify c8cfcb78c65877313cda7bcbace624d3dbd1f3b3^{commit} c8cfcb78c65877313cda7bcbace624d3dbd1f3b3 already have revision, skipping fetch # git checkout -q -f -B kisskb c8cfcb78c65877313cda7bcbace624d3dbd1f3b3 # git clean -qxdf # < git log -1 # commit c8cfcb78c65877313cda7bcbace624d3dbd1f3b3 # Author: Jason A. Donenfeld # Date: Wed Mar 18 20:27:32 2020 -0600 # # crypto: arm64/chacha - correctly walk through blocks # # Prior, passing in chunks of 2, 3, or 4, followed by any additional # chunks would result in the chacha state counter getting out of sync, # resulting in incorrect encryption/decryption, which is a pretty nasty # crypto vuln: "why do images look weird on webpages?" WireGuard users # never experienced this prior, because we have always, out of tree, used # a different crypto library, until the recent Frankenzinc addition. This # commit fixes the issue by advancing the pointers and state counter by # the actual size processed. It also fixes up a bug in the (optional, # costly) stride test that prevented it from running on arm64. # # Fixes: b3aad5bad26a ("crypto: arm64/chacha - expose arm64 ChaCha routine as library function") # Reported-and-tested-by: Emil Renner Berthing # Cc: Ard Biesheuvel # Cc: stable@vger.kernel.org # v5.5+ # Signed-off-by: Jason A. Donenfeld # Reviewed-by: Eric Biggers # Signed-off-by: Herbert Xu # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-ld --version # < git log --format=%s --max-count=1 c8cfcb78c65877313cda7bcbace624d3dbd1f3b3 # < make -s -j 80 ARCH=powerpc O=/kisskb/build/crypto_ppc64_defconfig+UP_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- ppc64_defconfig # Added to kconfig CONFIG_SMP=n # < make -s -j 80 ARCH=powerpc O=/kisskb/build/crypto_ppc64_defconfig+UP_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- help # make -s -j 80 ARCH=powerpc O=/kisskb/build/crypto_ppc64_defconfig+UP_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- olddefconfig # make -s -j 80 ARCH=powerpc O=/kisskb/build/crypto_ppc64_defconfig+UP_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/ext4/extents.c: In function 'ext4_convert_unwritten_io_end_vec': /kisskb/src/fs/ext4/extents.c:5054:23: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2591:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1852:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/bridge/br_netlink.c: In function 'br_afspec.isra.30': /kisskb/src/net/bridge/br_netlink.c:648:7: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page': /kisskb/src/mm/hugetlb.c:1377:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:338:21: note: 'pdeo' was declared here /kisskb/src/net/core/devlink.c: In function 'devlink_fmsg_prepare_skb': /kisskb/src/net/core/devlink.c:4613:6: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:248:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:228:19: note: 'i' was declared here /kisskb/src/fs/nfsd/nfs4xdr.c: In function 'nfsd4_encode_components_esc': /kisskb/src/fs/nfsd/nfs4xdr.c:2076:9: warning: 'str' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/usb/core/devio.c: In function 'async_completed': /kisskb/src/drivers/usb/core/devio.c:625:23: warning: 'errno' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/udf/unicode.c: In function 'udf_name_conv_char': /kisskb/src/fs/udf/unicode.c:132:8: warning: 'c' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c: In function 'tun_get_user': /kisskb/src/drivers/net/tun.c:1836:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c:1749:46: warning: 'linear' may be used uninitialized in this function [-Wuninitialized] WARNING: 2 bad relocations c0000000018d8058 R_PPC64_ADDR64 _binary__btf_vmlinux_bin_start c0000000018d8060 R_PPC64_ADDR64 _binary__btf_vmlinux_bin_end Completed OK # rm -rf /kisskb/build/crypto_ppc64_defconfig+UP_powerpc-gcc4.6 # Build took: 0:02:52.863759