# git rev-parse -q --verify c8cfcb78c65877313cda7bcbace624d3dbd1f3b3^{commit} c8cfcb78c65877313cda7bcbace624d3dbd1f3b3 already have revision, skipping fetch # git checkout -q -f -B kisskb c8cfcb78c65877313cda7bcbace624d3dbd1f3b3 # git clean -qxdf # < git log -1 # commit c8cfcb78c65877313cda7bcbace624d3dbd1f3b3 # Author: Jason A. Donenfeld # Date: Wed Mar 18 20:27:32 2020 -0600 # # crypto: arm64/chacha - correctly walk through blocks # # Prior, passing in chunks of 2, 3, or 4, followed by any additional # chunks would result in the chacha state counter getting out of sync, # resulting in incorrect encryption/decryption, which is a pretty nasty # crypto vuln: "why do images look weird on webpages?" WireGuard users # never experienced this prior, because we have always, out of tree, used # a different crypto library, until the recent Frankenzinc addition. This # commit fixes the issue by advancing the pointers and state counter by # the actual size processed. It also fixes up a bug in the (optional, # costly) stride test that prevented it from running on arm64. # # Fixes: b3aad5bad26a ("crypto: arm64/chacha - expose arm64 ChaCha routine as library function") # Reported-and-tested-by: Emil Renner Berthing # Cc: Ard Biesheuvel # Cc: stable@vger.kernel.org # v5.5+ # Signed-off-by: Jason A. Donenfeld # Reviewed-by: Eric Biggers # Signed-off-by: Herbert Xu # < /opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 c8cfcb78c65877313cda7bcbace624d3dbd1f3b3 # < make -s -j 80 ARCH=x86_64 O=/kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux- allnoconfig # < make -s -j 80 ARCH=x86_64 O=/kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux- help # make -s -j 80 ARCH=x86_64 O=/kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux- olddefconfig # make -s -j 80 ARCH=x86_64 O=/kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux- /kisskb/src/tools/objtool /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/x86/kernel/apic/io_apic.c: In function 'mp_map_pin_to_irq': /kisskb/src/arch/x86/kernel/apic/io_apic.c:1037:6: warning: 'irq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/x86/kernel/e820.c: In function 'e820__setup_pci_gap': /kisskb/src/arch/x86/kernel/e820.c:665:16: warning: 'gapstart' may be used uninitialized in this function [-Wuninitialized] Completed OK # rm -rf /kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc4.6 # Build took: 0:00:19.825700