# git rev-parse -q --verify 90e5d84c7b06b849a330ea43625086ff81388ed4^{commit} 90e5d84c7b06b849a330ea43625086ff81388ed4 already have revision, skipping fetch # git checkout -q -f -B kisskb 90e5d84c7b06b849a330ea43625086ff81388ed4 # git clean -qxdf # < git log -1 # commit 90e5d84c7b06b849a330ea43625086ff81388ed4 # Author: Gustavo A. R. Silva # Date: Mon Mar 23 19:41:14 2020 -0500 # # xattr.h: Replace zero-length array with flexible-array member # # The current codebase makes use of the zero-length array language # extension to the C90 standard, but the preferred mechanism to declare # variable-length types such as these ones is a flexible array member[1][2], # introduced in C99: # # struct foo { # int stuff; # struct boo array[]; # }; # # By making use of the mechanism above, we will get a compiler warning # in case the flexible array does not occur last in the structure, which # will help us prevent some kind of undefined behavior bugs from being # inadvertently introduced[3] to the codebase from now on. # # Also, notice that, dynamic memory allocations won't be affected by # this change: # # "Flexible array members have incomplete type, and so the sizeof operator # may not be applied. As a quirk of the original implementation of # zero-length arrays, sizeof evaluates to zero."[1] # # This issue was found with the help of Coccinelle. # # [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html # [2] https://github.com/KSPP/linux/issues/21 # [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") # # Signed-off-by: Gustavo A. R. Silva # < /opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc-gcc --version # < /opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc-ld --version # < git log --format=%s --max-count=1 90e5d84c7b06b849a330ea43625086ff81388ed4 # < make -s -j 32 ARCH=arc O=/kisskb/build/gustavoars_axs101_defconfig_arcompact CROSS_COMPILE=/opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc- axs101_defconfig # Added to kconfig CONFIG_INITRAMFS_SOURCE="" # < make -s -j 32 ARCH=arc O=/kisskb/build/gustavoars_axs101_defconfig_arcompact CROSS_COMPILE=/opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc- help # make -s -j 32 ARCH=arc O=/kisskb/build/gustavoars_axs101_defconfig_arcompact CROSS_COMPILE=/opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc- olddefconfig # make -s -j 32 ARCH=arc O=/kisskb/build/gustavoars_axs101_defconfig_arcompact CROSS_COMPILE=/opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc- /kisskb/src/net/ipv4/tcp_input.c: In function 'tcp_data_queue': /kisskb/src/net/ipv4/tcp_input.c:4398:49: warning: array subscript is above array bounds [-Warray-bounds] tp->selective_acks[i-1] = tp->selective_acks[i]; ^ /kisskb/src/drivers/gpu/drm/drm_dp_mst_topology.c: In function 'drm_dp_mst_dsc_aux_for_port': /kisskb/src/drivers/gpu/drm/drm_dp_mst_topology.c:5400:9: warning: missing braces around initializer [-Wmissing-braces] struct drm_dp_desc desc = { 0 }; ^ /kisskb/src/drivers/gpu/drm/drm_dp_mst_topology.c:5400:9: warning: (near initialization for 'desc.ident') [-Wmissing-braces] Completed OK # rm -rf /kisskb/build/gustavoars_axs101_defconfig_arcompact # Build took: 0:01:08.695762