Buildresult: gustavoars/i386-allnoconfig/i386-gcc4.9 built on Mar 25 2020, 08:04

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Mar 25 2020, 08:04
Duration:	0:00:21.319058
Builder:	ka1
Revision:	xattr.h: Replace zero-length array with flexible-array member (`90e5d84c7b06b849a330ea43625086ff81388ed4)`
Target:	gustavoars/i386-allnoconfig/i386-gcc4.9
Branch:	gustavoars
Compiler:	i386-gcc4.9 (i386-linux-gcc (GCC) 4.9.4 / GNU ld (GNU Binutils) 2.29.1.20170915)
Config:	allnoconfig (download)
Log:	Download original No warnings found in log. Full Log # git rev-parse -q --verify 90e5d84c7b06b849a330ea43625086ff81388ed4^{commit} 90e5d84c7b06b849a330ea43625086ff81388ed4 already have revision, skipping fetch # git checkout -q -f -B kisskb 90e5d84c7b06b849a330ea43625086ff81388ed4 # git clean -qxdf # < git log -1 # commit 90e5d84c7b06b849a330ea43625086ff81388ed4 # Author: Gustavo A. R. Silva <gustavo@embeddedor.com> # Date: Mon Mar 23 19:41:14 2020 -0500 # # xattr.h: Replace zero-length array with flexible-array member # # The current codebase makes use of the zero-length array language # extension to the C90 standard, but the preferred mechanism to declare # variable-length types such as these ones is a flexible array member[1][2], # introduced in C99: # # struct foo { # int stuff; # struct boo array[]; # }; # # By making use of the mechanism above, we will get a compiler warning # in case the flexible array does not occur last in the structure, which # will help us prevent some kind of undefined behavior bugs from being # inadvertently introduced[3] to the codebase from now on. # # Also, notice that, dynamic memory allocations won't be affected by # this change: # # "Flexible array members have incomplete type, and so the sizeof operator # may not be applied. As a quirk of the original implementation of # zero-length arrays, sizeof evaluates to zero."[1] # # This issue was found with the help of Coccinelle. # # [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html # [2] https://github.com/KSPP/linux/issues/21 # [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") # # Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/i386-linux/bin/i386-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/i386-linux/bin/i386-linux-ld --version # < git log --format=%s --max-count=1 90e5d84c7b06b849a330ea43625086ff81388ed4 # < make -s -j 48 ARCH=i386 O=/kisskb/build/gustavoars_i386-allnoconfig_i386-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/i386-linux/bin/i386-linux- allnoconfig # < make -s -j 48 ARCH=i386 O=/kisskb/build/gustavoars_i386-allnoconfig_i386-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/i386-linux/bin/i386-linux- help # make -s -j 48 ARCH=i386 O=/kisskb/build/gustavoars_i386-allnoconfig_i386-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/i386-linux/bin/i386-linux- olddefconfig # make -s -j 48 ARCH=i386 O=/kisskb/build/gustavoars_i386-allnoconfig_i386-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/i386-linux/bin/i386-linux- Completed OK # rm -rf /kisskb/build/gustavoars_i386-allnoconfig_i386-gcc4.9 # Build took: 0:00:21.319058

© Michael Ellerman 2006-2018.