# git rev-parse -q --verify 7be97138e7276c71cc9ad1752dcb502d28f4400d^{commit} 7be97138e7276c71cc9ad1752dcb502d28f4400d already have revision, skipping fetch # git checkout -q -f -B kisskb 7be97138e7276c71cc9ad1752dcb502d28f4400d # git clean -qxdf # < git log -1 # commit 7be97138e7276c71cc9ad1752dcb502d28f4400d # Merge: 7db83c070bd2 27fb5a72f50a # Author: Linus Torvalds # Date: Thu Apr 2 13:02:07 2020 -0700 # # Merge tag 'xfs-5.7-merge-8' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux # # Pull xfs updates from Darrick Wong: # "There's a lot going on this cycle with cleanups in the log code, the # btree code, and the xattr code. # # We're tightening of metadata validation and online fsck checking, and # introducing a common btree rebuilding library so that we can refactor # xfs_repair and introduce online repair in a future cycle. # # We also fixed a few visible bugs -- most notably there's one in # getdents that we introduced in 5.6; and a fix for hangs when disabling # quotas. # # This series has been running fstests & other QA in the background for # over a week and looks good so far. # # I anticipate sending a second pull request next week. That batch will # change how xfs interacts with memory reclaim; how the log batches and # throttles log items; how hard writes near ENOSPC will try to squeeze # more space out of the filesystem; and hopefully fix the last of the # umount hangs after a catastrophic failure. That should ease a lot of # problems when running at the limits, but for now I'm leaving that in # for-next for another week to make sure we got all the subtleties # right. # # Summary: # # - Fix a hard to trigger race between iclog error checking and log # shutdown. # # - Strengthen the AGF verifier. # # - Ratelimit some of the more spammy error messages. # # - Remove the icdinode uid/gid members and just use the ones in the # vfs inode. # # - Hold ILOCK across insert/collapse range. # # - Clean up the extended attribute interfaces. # # - Clean up the attr flags mess. # # - Restore PF_MEMALLOC after exiting xfsaild thread to avoid # triggering warnings in the process accounting code. # # - Remove the flexibly-sized array from struct xfs_agfl to eliminate # compiler warnings about unaligned pointers and packed structures. # # - Various macro and typedef removals. # # - Stale metadata buffers if we decide they're corrupt outside of a # verifier. # # - Check directory data/block/free block owners. # # - Fix a UAF when aborting inactivation of a corrupt xattr fork. # # - Teach online scrub to report failed directory and attr name lookups # as a metadata corruption instead of a runtime error. # # - Avoid potential buffer overflows in sysfs files by using scnprintf. # # - Fix a regression in getdents lookups due to a mistake in pointer # arithmetic. # # - Refactor btree cursor private data structures to use anonymous # unions. # # - Cleanups in the log unmounting code. # # - Fix a potential mishandling of ENOMEM errors on multi-block # directory buffer lookups. # # - Fix an incorrect test in the block allocation code. # # - Cleanups and name prefix shortening in the scrub code. # # - Introduce btree bulk loading code for online repair and scrub. # # - Fix a quotaoff log item leak (and hang) when the fs goes down # midway through a quotaoff operation. # # - Remove di_version from the incore inode. # # - Refactor some of the log shutdown checking code. # # - Record the forcing of the log unmount records in the log force # counters. # # - Fix a longstanding bug where quotacheck would purge the # administrator's default quota grace interval and warning limits. # # - Reduce memory usage when scrubbing directory and xattr trees. # # - Don't let fsfreeze race with GETFSMAP or online scrub. # # - Handle bio_add_page failures more gracefully in xlog_write_iclog" # # * tag 'xfs-5.7-merge-8' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux: (108 commits) # xfs: prohibit fs freezing when using empty transactions # xfs: shutdown on failure to add page to log bio # xfs: directory bestfree check should release buffers # xfs: drop all altpath buffers at the end of the sibling check # xfs: preserve default grace interval during quotacheck # xfs: remove xlog_state_want_sync # xfs: move the ioerror check out of xlog_state_clean_iclog # xfs: refactor xlog_state_clean_iclog # xfs: remove the aborted parameter to xlog_state_done_syncing # xfs: simplify log shutdown checking in xfs_log_release_iclog # xfs: simplify the xfs_log_release_iclog calling convention # xfs: factor out a xlog_wait_on_iclog helper # xfs: merge xlog_cil_push into xlog_cil_push_work # xfs: remove the di_version field from struct icdinode # xfs: simplify a check in xfs_ioctl_setattr_check_cowextsize # xfs: simplify di_flags2 inheritance in xfs_ialloc # xfs: only check the superblock version for dinode size calculation # xfs: add a new xfs_sb_version_has_v3inode helper # xfs: fix unmount hang and memory leak on shutdown during quotaoff # xfs: factor out quotaoff intent AIL removal and memory free # ... # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux-ld --version # < git log --format=%s --max-count=1 7be97138e7276c71cc9ad1752dcb502d28f4400d # < make -s -j 32 ARCH=m68k O=/kisskb/build/linus_sun3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- sun3_defconfig WARNING: unmet direct dependencies detected for NEED_MULTIPLE_NODES Depends on [n]: DISCONTIGMEM [=n] || NUMA Selected by [y]: - SINGLE_MEMORY_CHUNK [=y] && MMU [=y] WARNING: unmet direct dependencies detected for NEED_MULTIPLE_NODES Depends on [n]: DISCONTIGMEM [=n] || NUMA Selected by [y]: - SINGLE_MEMORY_CHUNK [=y] && MMU [=y] # < make -s -j 32 ARCH=m68k O=/kisskb/build/linus_sun3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- help # make -s -j 32 ARCH=m68k O=/kisskb/build/linus_sun3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- olddefconfig WARNING: unmet direct dependencies detected for NEED_MULTIPLE_NODES Depends on [n]: DISCONTIGMEM [=n] || NUMA Selected by [y]: - SINGLE_MEMORY_CHUNK [=y] && MMU [=y] WARNING: unmet direct dependencies detected for NEED_MULTIPLE_NODES Depends on [n]: DISCONTIGMEM [=n] || NUMA Selected by [y]: - SINGLE_MEMORY_CHUNK [=y] && MMU [=y] # make -s -j 32 ARCH=m68k O=/kisskb/build/linus_sun3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- In file included from /kisskb/src/arch/m68k/include/asm/atomic.h:7, from /kisskb/src/include/linux/atomic.h:7, from /kisskb/src/include/linux/spinlock.h:460, from /kisskb/src/include/linux/seqlock.h:36, from /kisskb/src/include/linux/time.h:6, from /kisskb/src/include/linux/stat.h:19, from /kisskb/src/include/linux/module.h:13, from /kisskb/src/net/core/filter.c:20: /kisskb/src/net/core/filter.c: In function 'bpf_clear_redirect_map': /kisskb/src/arch/m68k/include/asm/cmpxchg.h:137:3: warning: value computed is not used [-Wunused-value] ((__typeof__(*(ptr)))__cmpxchg_local_generic((ptr), (unsigned long)(o),\ ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (unsigned long)(n), sizeof(*(ptr)))) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/include/asm-generic/cmpxchg.h:106:28: note: in expansion of macro 'cmpxchg_local' #define cmpxchg(ptr, o, n) cmpxchg_local((ptr), (o), (n)) ^~~~~~~~~~~~~ /kisskb/src/net/core/filter.c:3529:4: note: in expansion of macro 'cmpxchg' cmpxchg(&ri->map, map, NULL); ^~~~~~~ In file included from /kisskb/src/arch/m68k/include/asm/atomic.h:7, from /kisskb/src/include/linux/atomic.h:7, from /kisskb/src/include/linux/spinlock.h:460, from /kisskb/src/include/linux/mmzone.h:8, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/mm.h:10, from /kisskb/src/kernel/acct.c:47: /kisskb/src/kernel/acct.c: In function 'acct_pin_kill': /kisskb/src/arch/m68k/include/asm/cmpxchg.h:137:3: warning: value computed is not used [-Wunused-value] ((__typeof__(*(ptr)))__cmpxchg_local_generic((ptr), (unsigned long)(o),\ ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (unsigned long)(n), sizeof(*(ptr)))) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/include/asm-generic/cmpxchg.h:106:28: note: in expansion of macro 'cmpxchg_local' #define cmpxchg(ptr, o, n) cmpxchg_local((ptr), (o), (n)) ^~~~~~~~~~~~~ /kisskb/src/kernel/acct.c:177:2: note: in expansion of macro 'cmpxchg' cmpxchg(&acct->ns->bacct, pin, NULL); ^~~~~~~ In file included from /kisskb/src/include/linux/swab.h:5, from /kisskb/src/include/uapi/linux/byteorder/big_endian.h:13, from /kisskb/src/include/linux/byteorder/big_endian.h:5, from /kisskb/src/arch/m68k/include/uapi/asm/byteorder.h:5, from /kisskb/src/include/asm-generic/bitops/le.h:6, from /kisskb/src/arch/m68k/include/asm/bitops.h:528, from /kisskb/src/include/linux/bitops.h:29, from /kisskb/src/include/linux/kernel.h:12, from /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c:31: /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c: In function 'sun3_82586_timeout': /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c:993:108: warning: array subscript 1 is above array bounds of 'volatile struct transmit_cmd_struct *[1]' [-Warray-bounds] printk("%s: command-stats: %04x %04x\n",dev->name,swab16(p->xmit_cmds[0]->cmd_status),swab16(p->xmit_cmds[1]->cmd_status)); ~~~~~~~~~~~~^~~ /kisskb/src/include/uapi/linux/swab.h:107:12: note: in definition of macro '__swab16' __fswab16(x)) ^ /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c:993:89: note: in expansion of macro 'swab16' printk("%s: command-stats: %04x %04x\n",dev->name,swab16(p->xmit_cmds[0]->cmd_status),swab16(p->xmit_cmds[1]->cmd_status)); ^~~~~~ In file included from /kisskb/src/arch/m68k/include/asm/atomic.h:7, from /kisskb/src/include/linux/atomic.h:7, from /kisskb/src/include/linux/spinlock.h:460, from /kisskb/src/include/linux/wait.h:9, from /kisskb/src/include/linux/wait_bit.h:8, from /kisskb/src/include/linux/fs.h:6, from /kisskb/src/fs/ocfs2/file.c:13: /kisskb/src/fs/ocfs2/file.c: In function 'ocfs2_file_write_iter': /kisskb/src/arch/m68k/include/asm/cmpxchg.h:79:22: warning: value computed is not used [-Wunused-value] #define xchg(ptr,x) ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr)))) ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/fs/ocfs2/file.c:2419:3: note: in expansion of macro 'xchg' xchg(&iocb->ki_complete, saved_ki_complete); ^~~~ In file included from /kisskb/src/arch/m68k/include/asm/atomic.h:7, from /kisskb/src/include/linux/atomic.h:7, from /kisskb/src/include/linux/spinlock.h:460, from /kisskb/src/include/linux/mmzone.h:8, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/slab.h:15, from /kisskb/src/fs/posix_acl.c:15: /kisskb/src/fs/posix_acl.c: In function 'get_acl': /kisskb/src/arch/m68k/include/asm/cmpxchg.h:137:3: warning: value computed is not used [-Wunused-value] ((__typeof__(*(ptr)))__cmpxchg_local_generic((ptr), (unsigned long)(o),\ ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (unsigned long)(n), sizeof(*(ptr)))) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/include/asm-generic/cmpxchg.h:106:28: note: in expansion of macro 'cmpxchg_local' #define cmpxchg(ptr, o, n) cmpxchg_local((ptr), (o), (n)) ^~~~~~~~~~~~~ /kisskb/src/fs/posix_acl.c:148:3: note: in expansion of macro 'cmpxchg' cmpxchg(p, sentinel, ACL_NOT_CACHED); ^~~~~~~ Completed OK # rm -rf /kisskb/build/linus_sun3_defconfig_m68k-gcc8 # Build took: 0:02:07.211336