# git rev-parse -q --verify 755bddd1e4eaf9178758bd554c60aaab46fc42ba^{commit} 755bddd1e4eaf9178758bd554c60aaab46fc42ba already have revision, skipping fetch # git checkout -q -f -B kisskb 755bddd1e4eaf9178758bd554c60aaab46fc42ba # git clean -qxdf # < git log -1 # commit 755bddd1e4eaf9178758bd554c60aaab46fc42ba # Author: Colin Ian King # Date: Thu Apr 2 00:10:12 2020 +0100 # # crypto: marvell/octeontx - fix double free of ptr # # Currently in the case where eq->src != req->ds, the allocation of # ptr is kfree'd at the end of the code block. However later on in # the case where enc is not null any of the error return paths that # return via the error handling return path end up performing an # erroneous second kfree of ptr. # # Fix this by adding an error exit label error_free and only jump to # this when ptr needs kfree'ing thus avoiding the double free issue. # # Addresses-Coverity: ("Double free") # Fixes: 10b4f09491bf ("crypto: marvell - add the Virtual Function driver for CPT") # Signed-off-by: Colin Ian King # Signed-off-by: Herbert Xu # < /opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 755bddd1e4eaf9178758bd554c60aaab46fc42ba # < make -s -j 48 ARCH=x86_64 O=/kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux- allnoconfig # < make -s -j 48 ARCH=x86_64 O=/kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux- help # make -s -j 48 ARCH=x86_64 O=/kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux- olddefconfig # make -s -j 48 ARCH=x86_64 O=/kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/x86/kernel/apic/io_apic.c: In function 'mp_map_pin_to_irq': /kisskb/src/arch/x86/kernel/apic/io_apic.c:1037:6: warning: 'irq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/x86/kernel/e820.c: In function 'e820__setup_pci_gap': /kisskb/src/arch/x86/kernel/e820.c:665:16: warning: 'gapstart' may be used uninitialized in this function [-Wuninitialized] Completed OK # rm -rf /kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc4.6 # Build took: 0:00:20.336698