# git rev-parse -q --verify abc3fce76adbdfa8f87272c784b388cd20b46049^{commit} abc3fce76adbdfa8f87272c784b388cd20b46049 already have revision, skipping fetch # git checkout -q -f -B kisskb abc3fce76adbdfa8f87272c784b388cd20b46049 # git clean -qxdf # < git log -1 # commit abc3fce76adbdfa8f87272c784b388cd20b46049 # Author: Nicholas Piggin # Date: Thu Apr 2 22:04:01 2020 +1000 # # Revert "powerpc/64: irq_work avoid interrupt when called with hardware irqs enabled" # # This reverts commit ebb37cf3ffd39fdb6ec5b07111f8bb2f11d92c5f. # # That commit does not play well with soft-masked irq state # manipulations in idle, interrupt replay, and possibly others due to # tracing code sometimes using irq_work_queue (e.g., in # trace_hardirqs_on()). That can cause PACA_IRQ_DEC to become set when # it is not expected, and be ignored or cleared or cause warnings. # # The net result seems to be missing an irq_work until the next timer # interrupt in the worst case which is usually not going to be noticed, # however it could be a long time if the tick is disabled, which is # against the spirit of irq_work and might cause real problems. # # The idea is still solid, but it would need more work. It's not really # clear if it would be worth added complexity, so revert this for # now (not a straight revert, but replace with a comment explaining why # we might see interrupts happening, and gives git blame something to # find). # # Fixes: ebb37cf3ffd3 ("powerpc/64: irq_work avoid interrupt when called with hardware irqs enabled") # Signed-off-by: Nicholas Piggin # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20200402120401.1115883-1-npiggin@gmail.com # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-ld --version # < git log --format=%s --max-count=1 abc3fce76adbdfa8f87272c784b388cd20b46049 # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next_85xx_tqm8560_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- 85xx/tqm8560_defconfig # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next_85xx_tqm8560_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- help # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next_85xx_tqm8560_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- olddefconfig # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next_85xx_tqm8560_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:72:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:338:21: note: 'pdeo' was declared here /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:248:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:228:19: note: 'i' was declared here /kisskb/src/fs/ext4/extents.c: In function 'ext4_convert_unwritten_io_end_vec': /kisskb/src/fs/ext4/extents.c:5009:23: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1859:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2598:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/io_uring.c: In function '__io_sqe_files_update': /kisskb/src/fs/io_uring.c:5824:13: warning: 'err' may be used uninitialized in this function [-Wuninitialized] INFO: Uncompressed kernel (size 0x510e84) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5007f4) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) Image Name: Linux-5.6.0-rc2-00191-gabc3fce76 Created: Fri Apr 3 23:25:45 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2543625 Bytes = 2484.01 KiB = 2.43 MiB Load Address: 00000000 Entry Point: 00000000 Image Name: Linux-5.6.0-rc2-00191-gabc3fce76 Created: Fri Apr 3 23:25:45 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2574404 Bytes = 2514.07 KiB = 2.46 MiB Load Address: 00600000 Entry Point: 006002e8 Completed OK # rm -rf /kisskb/build/powerpc-next_85xx_tqm8560_defconfig_powerpc-gcc4.6 # Build took: 0:00:37.503625