# git rev-parse -q --verify abc3fce76adbdfa8f87272c784b388cd20b46049^{commit} abc3fce76adbdfa8f87272c784b388cd20b46049 already have revision, skipping fetch # git checkout -q -f -B kisskb abc3fce76adbdfa8f87272c784b388cd20b46049 # git clean -qxdf # < git log -1 # commit abc3fce76adbdfa8f87272c784b388cd20b46049 # Author: Nicholas Piggin # Date: Thu Apr 2 22:04:01 2020 +1000 # # Revert "powerpc/64: irq_work avoid interrupt when called with hardware irqs enabled" # # This reverts commit ebb37cf3ffd39fdb6ec5b07111f8bb2f11d92c5f. # # That commit does not play well with soft-masked irq state # manipulations in idle, interrupt replay, and possibly others due to # tracing code sometimes using irq_work_queue (e.g., in # trace_hardirqs_on()). That can cause PACA_IRQ_DEC to become set when # it is not expected, and be ignored or cleared or cause warnings. # # The net result seems to be missing an irq_work until the next timer # interrupt in the worst case which is usually not going to be noticed, # however it could be a long time if the tick is disabled, which is # against the spirit of irq_work and might cause real problems. # # The idea is still solid, but it would need more work. It's not really # clear if it would be worth added complexity, so revert this for # now (not a straight revert, but replace with a comment explaining why # we might see interrupts happening, and gives git blame something to # find). # # Fixes: ebb37cf3ffd3 ("powerpc/64: irq_work avoid interrupt when called with hardware irqs enabled") # Signed-off-by: Nicholas Piggin # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20200402120401.1115883-1-npiggin@gmail.com # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 abc3fce76adbdfa8f87272c784b388cd20b46049 # < make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_defconfig # < make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/include/linux/kernel.h:11:0, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/module.h:12, from /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:15: /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) ^ /kisskb/src/include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' # define unlikely(x) __builtin_expect(!!(x), 0) ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:139:6: note: in expansion of macro 'IS_ERR_VALUE' if (IS_ERR_VALUE(fep->ring_mem_addr)) ^ /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) INFO: Uncompressed kernel (size 0xc94700) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc94700) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc94700) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc94700) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc94700) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc94700) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc94700) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc94700) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc94700) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc94700) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc94700) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc94700) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc94700) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc94700) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc94700) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc83efc) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) Image Name: Linux-5.6.0-rc2-gabc3fce76adb Created: Fri Apr 3 23:51:42 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6170115 Bytes = 6025.50 KiB = 5.88 MiB Load Address: 00d00000 Entry Point: 00d002a4 Image Name: Linux-5.6.0-rc2-gabc3fce76adb Created: Fri Apr 3 23:51:42 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6170529 Bytes = 6025.91 KiB = 5.88 MiB Load Address: 00d00000 Entry Point: 00d002a4 Image Name: Linux-5.6.0-rc2-gabc3fce76adb Created: Fri Apr 3 23:51:42 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6169663 Bytes = 6025.06 KiB = 5.88 MiB Load Address: 00d00000 Entry Point: 00d002a4 Image Name: Linux-5.6.0-rc2-gabc3fce76adb Created: Fri Apr 3 23:51:42 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6170633 Bytes = 6026.01 KiB = 5.88 MiB Load Address: 00d00000 Entry Point: 00d002a4 Image Name: Linux-5.6.0-rc2-gabc3fce76adb Created: Fri Apr 3 23:51:42 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6169702 Bytes = 6025.10 KiB = 5.88 MiB Load Address: 00d00000 Entry Point: 00d00314 Image Name: Linux-5.6.0-rc2-gabc3fce76adb Created: Fri Apr 3 23:51:42 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6169466 Bytes = 6024.87 KiB = 5.88 MiB Load Address: 00d00000 Entry Point: 00d00314 Image Name: Linux-5.6.0-rc2-gabc3fce76adb Created: Fri Apr 3 23:51:43 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6169662 Bytes = 6025.06 KiB = 5.88 MiB Load Address: 00d00000 Entry Point: 00d002a4 Image Name: Linux-5.6.0-rc2-gabc3fce76adb Created: Fri Apr 3 23:51:43 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6139193 Bytes = 5995.31 KiB = 5.85 MiB Load Address: 00000000 Entry Point: 00000000 Image Name: Linux-5.6.0-rc2-gabc3fce76adb Created: Fri Apr 3 23:51:43 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6169465 Bytes = 6024.87 KiB = 5.88 MiB Load Address: 00d00000 Entry Point: 00d00314 Image Name: Linux-5.6.0-rc2-gabc3fce76adb Created: Fri Apr 3 23:51:43 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6169682 Bytes = 6025.08 KiB = 5.88 MiB Load Address: 00d00000 Entry Point: 00d00314 Image Name: Linux-5.6.0-rc2-gabc3fce76adb Created: Fri Apr 3 23:51:43 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6169484 Bytes = 6024.89 KiB = 5.88 MiB Load Address: 00d00000 Entry Point: 00d002a4 Image Name: Linux-5.6.0-rc2-gabc3fce76adb Created: Fri Apr 3 23:51:43 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6169434 Bytes = 6024.84 KiB = 5.88 MiB Load Address: 00d00000 Entry Point: 00d002a4 Image Name: Linux-5.6.0-rc2-gabc3fce76adb Created: Fri Apr 3 23:51:43 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6169510 Bytes = 6024.91 KiB = 5.88 MiB Load Address: 00d00000 Entry Point: 00d00314 Image Name: Linux-5.6.0-rc2-gabc3fce76adb Created: Fri Apr 3 23:51:43 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6169589 Bytes = 6024.99 KiB = 5.88 MiB Load Address: 00d00000 Entry Point: 00d002a4 Image Name: Linux-5.6.0-rc2-gabc3fce76adb Created: Fri Apr 3 23:51:44 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6169422 Bytes = 6024.83 KiB = 5.88 MiB Load Address: 00d00000 Entry Point: 00d002a4 Image Name: Linux-5.6.0-rc2-gabc3fce76adb Created: Fri Apr 3 23:51:44 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6169588 Bytes = 6024.99 KiB = 5.88 MiB Load Address: 00d00000 Entry Point: 00d002a4 Completed OK # rm -rf /kisskb/build/powerpc-next_mpc85xx_defconfig_powerpc-gcc5 # Build took: 0:02:35.697758