# git rev-parse -q --verify abc3fce76adbdfa8f87272c784b388cd20b46049^{commit} abc3fce76adbdfa8f87272c784b388cd20b46049 already have revision, skipping fetch # git checkout -q -f -B kisskb abc3fce76adbdfa8f87272c784b388cd20b46049 # git clean -qxdf # < git log -1 # commit abc3fce76adbdfa8f87272c784b388cd20b46049 # Author: Nicholas Piggin # Date: Thu Apr 2 22:04:01 2020 +1000 # # Revert "powerpc/64: irq_work avoid interrupt when called with hardware irqs enabled" # # This reverts commit ebb37cf3ffd39fdb6ec5b07111f8bb2f11d92c5f. # # That commit does not play well with soft-masked irq state # manipulations in idle, interrupt replay, and possibly others due to # tracing code sometimes using irq_work_queue (e.g., in # trace_hardirqs_on()). That can cause PACA_IRQ_DEC to become set when # it is not expected, and be ignored or cleared or cause warnings. # # The net result seems to be missing an irq_work until the next timer # interrupt in the worst case which is usually not going to be noticed, # however it could be a long time if the tick is disabled, which is # against the spirit of irq_work and might cause real problems. # # The idea is still solid, but it would need more work. It's not really # clear if it would be worth added complexity, so revert this for # now (not a straight revert, but replace with a comment explaining why # we might see interrupts happening, and gives git blame something to # find). # # Fixes: ebb37cf3ffd3 ("powerpc/64: irq_work avoid interrupt when called with hardware irqs enabled") # Signed-off-by: Nicholas Piggin # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20200402120401.1115883-1-npiggin@gmail.com # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 abc3fce76adbdfa8f87272c784b388cd20b46049 # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc6xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ppc6xx_defconfig # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc6xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc6xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc6xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/sound/ppc/pmac.h:12:0, from /kisskb/src/sound/ppc/awacs.c:16: /kisskb/src/sound/ppc/awacs.c: In function 'snd_pmac_awacs_init': /kisskb/src/include/sound/control.h:218:9: warning: 'speaker_vol' may be used uninitialized in this function [-Wmaybe-uninitialized] return _snd_ctl_add_slave(master, slave, 0); ^ /kisskb/src/sound/ppc/awacs.c:873:36: note: 'speaker_vol' was declared here struct snd_kcontrol *master_vol, *speaker_vol; ^ INFO: Uncompressed kernel (size 0xaca6ec) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xb00000) INFO: Uncompressed kernel (size 0xaca6ec) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xb00000) INFO: Uncompressed kernel (size 0xaca6ec) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xb00000) INFO: Uncompressed kernel (size 0xaca6ec) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xb00000) INFO: Uncompressed kernel (size 0xaca6ec) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xb00000) INFO: Uncompressed kernel (size 0xaca6ec) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xb00000) INFO: Uncompressed kernel (size 0xaca6ec) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xb00000) INFO: Uncompressed kernel (size 0xaca6ec) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xb00000) INFO: Uncompressed kernel (size 0xaca6ec) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xb00000) INFO: Uncompressed kernel (size 0xaba004) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xb00000) INFO: Uncompressed kernel (size 0xaba004) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xb00000) INFO: Uncompressed kernel (size 0xaca6ec) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xb00000) Image Name: Linux-5.6.0-rc2+ Created: Fri Apr 3 23:54:09 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5176746 Bytes = 5055.42 KiB = 4.94 MiB Load Address: 00b00000 Entry Point: 00b00294 Image Name: Linux-5.6.0-rc2+ Created: Fri Apr 3 23:54:09 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5177237 Bytes = 5055.90 KiB = 4.94 MiB Load Address: 00b00000 Entry Point: 00b00294 Image Name: Linux-5.6.0-rc2+ Created: Fri Apr 3 23:54:09 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5146910 Bytes = 5026.28 KiB = 4.91 MiB Load Address: 00000000 Entry Point: 00000000 Image Name: Linux-5.6.0-rc2+ Created: Fri Apr 3 23:54:09 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5177145 Bytes = 5055.81 KiB = 4.94 MiB Load Address: 00b00000 Entry Point: 00b00894 Image Name: Linux-5.6.0-rc2+ Created: Fri Apr 3 23:54:09 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5175720 Bytes = 5054.41 KiB = 4.94 MiB Load Address: 00b00000 Entry Point: 00b00294 Image Name: Linux-5.6.0-rc2+ Created: Fri Apr 3 23:54:09 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5176996 Bytes = 5055.66 KiB = 4.94 MiB Load Address: 00b00000 Entry Point: 00b00294 Image Name: Linux-5.6.0-rc2+ Created: Fri Apr 3 23:54:09 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5176360 Bytes = 5055.04 KiB = 4.94 MiB Load Address: 00b00000 Entry Point: 00b00294 Image Name: Linux-5.6.0-rc2+ Created: Fri Apr 3 23:54:09 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5177162 Bytes = 5055.82 KiB = 4.94 MiB Load Address: 00b00000 Entry Point: 00b00294 Image Name: Linux-5.6.0-rc2+ Created: Fri Apr 3 23:54:09 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5177253 Bytes = 5055.91 KiB = 4.94 MiB Load Address: 00b00000 Entry Point: 00b00894 Completed OK # rm -rf /kisskb/build/powerpc-next_ppc6xx_defconfig_powerpc-gcc5 # Build took: 0:03:56.713385