# git rev-parse -q --verify abc3fce76adbdfa8f87272c784b388cd20b46049^{commit} abc3fce76adbdfa8f87272c784b388cd20b46049 already have revision, skipping fetch # git checkout -q -f -B kisskb abc3fce76adbdfa8f87272c784b388cd20b46049 # git clean -qxdf # < git log -1 # commit abc3fce76adbdfa8f87272c784b388cd20b46049 # Author: Nicholas Piggin # Date: Thu Apr 2 22:04:01 2020 +1000 # # Revert "powerpc/64: irq_work avoid interrupt when called with hardware irqs enabled" # # This reverts commit ebb37cf3ffd39fdb6ec5b07111f8bb2f11d92c5f. # # That commit does not play well with soft-masked irq state # manipulations in idle, interrupt replay, and possibly others due to # tracing code sometimes using irq_work_queue (e.g., in # trace_hardirqs_on()). That can cause PACA_IRQ_DEC to become set when # it is not expected, and be ignored or cleared or cause warnings. # # The net result seems to be missing an irq_work until the next timer # interrupt in the worst case which is usually not going to be noticed, # however it could be a long time if the tick is disabled, which is # against the spirit of irq_work and might cause real problems. # # The idea is still solid, but it would need more work. It's not really # clear if it would be worth added complexity, so revert this for # now (not a straight revert, but replace with a comment explaining why # we might see interrupts happening, and gives git blame something to # find). # # Fixes: ebb37cf3ffd3 ("powerpc/64: irq_work avoid interrupt when called with hardware irqs enabled") # Signed-off-by: Nicholas Piggin # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20200402120401.1115883-1-npiggin@gmail.com # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 abc3fce76adbdfa8f87272c784b388cd20b46049 # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- randconfig KCONFIG_SEED=0xFCB95A50 # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # Added to kconfig CONFIG_TRIM_UNUSED_KSYMS=n # Added to kconfig CONFIG_UBSAN=n # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:4940:warning: override: reassigning to symbol STANDALONE .config:4945:warning: override: reassigning to symbol PPC_DISABLE_WERROR .config:4946:warning: override: reassigning to symbol SECTION_MISMATCH_WARN_ONLY .config:4947:warning: override: reassigning to symbol PREVENT_FIRMWARE_BUILD # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/drivers/net/ethernet/chelsio/cxgb4/sge.c: In function 'ethofld_hard_xmit': /kisskb/src/drivers/net/ethernet/chelsio/cxgb4/sge.c:2216:19: warning: 'next_state' may be used uninitialized in this function [-Wmaybe-uninitialized] 2216 | eosw_txq->state = next_state; | ~~~~~~~~~~~~~~~~^~~~~~~~~~~~ In file included from /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:29, from /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:37, from /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:27: /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c: In function 'dcn_bw_apply_registry_override': /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/os_types.h:64:3: error: implicit declaration of function 'enable_kernel_vsx'; did you mean 'enable_kernel_fp'? [-Werror=implicit-function-declaration] 64 | enable_kernel_vsx(); \ | ^~~~~~~~~~~~~~~~~ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:626:2: note: in expansion of macro 'DC_FP_START' 626 | DC_FP_START(); | ^~~~~~~~~~~ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/os_types.h:67:3: error: implicit declaration of function 'enable_kernel_altivec'; did you mean 'enable_kernel_fp'? [-Werror=implicit-function-declaration] 67 | enable_kernel_altivec(); \ | ^~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:626:2: note: in expansion of macro 'DC_FP_START' 626 | DC_FP_START(); | ^~~~~~~~~~~ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/os_types.h:75:3: error: implicit declaration of function 'disable_kernel_vsx'; did you mean 'disable_kernel_fp'? [-Werror=implicit-function-declaration] 75 | disable_kernel_vsx(); \ | ^~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:662:2: note: in expansion of macro 'DC_FP_END' 662 | DC_FP_END(); | ^~~~~~~~~ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/os_types.h:78:3: error: implicit declaration of function 'disable_kernel_altivec'; did you mean 'disable_kernel_fp'? [-Werror=implicit-function-declaration] 78 | disable_kernel_altivec(); \ | ^~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c:662:2: note: in expansion of macro 'DC_FP_END' 662 | DC_FP_END(); | ^~~~~~~~~ cc1: some warnings being treated as errors make[5]: *** [/kisskb/src/scripts/Makefile.build:268: drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.o] Error 1 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [/kisskb/src/scripts/Makefile.build:505: drivers/gpu/drm/amd/amdgpu] Error 2 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:505: drivers/gpu/drm] Error 2 make[2]: *** [/kisskb/src/scripts/Makefile.build:505: drivers/gpu] Error 2 make[1]: *** [/kisskb/src/Makefile:1681: drivers] Error 2 make: *** [Makefile:179: sub-make] Error 2 Command 'make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc9 # Build took: 0:05:09.306485