# git rev-parse -q --verify 58bb4f7d4970e92c2400208a1b48aae3b2853e5c^{commit} 58bb4f7d4970e92c2400208a1b48aae3b2853e5c already have revision, skipping fetch # git checkout -q -f -B kisskb 58bb4f7d4970e92c2400208a1b48aae3b2853e5c # git clean -qxdf # < git log -1 # commit 58bb4f7d4970e92c2400208a1b48aae3b2853e5c # Author: Masahiro Yamada # Date: Thu Mar 12 07:37:25 2020 +0900 # # kbuild: link lib-y objects to vmlinux forcibly when CONFIG_MODULES=y # # Kbuild supports not only obj-y but also lib-y to list objects linked to # vmlinux. # # The difference between them is that all the objects from obj-y are # forcibly linked to vmlinux, whereas the objects from lib-y are linked # as needed; if there is no user of a lib-y object, it is not linked. # # lib-y is intended to list utility functions that may be called from all # over the place (and may be unused at all), but it is a problem for # EXPORT_SYMBOL(). Even if there is no call-site in the vmlinux, we need # to keep exported symbols for the use from loadable modules. # # Commit 7f2084fa55e6 ("[kbuild] handle exports in lib-y objects reliably") # worked around it by linking a dummy object, lib-ksyms.o, which contains # references to all the symbols exported from lib.a in that directory. # It uses the linker script command, EXTERN. Unfortunately, the meaning of # EXTERN of ld.lld is different from that of ld.bfd. Therefore, this does # not work with LD=ld.lld (CBL issue #515). # # Anyway, the build rule of lib-ksyms.o is somewhat tricky. So, I want to # get rid of it. # # At first, I was thinking of accumulating lib-y objects into obj-y # (or even replacing lib-y with obj-y entirely), but the lib-y syntax # is used beyond the ordinary use in lib/ and arch/*/lib/. # # Examples: # # - drivers/firmware/efi/libstub/Makefile builds lib.a, which is linked # into vmlinux in the own way (arm64), or linked to the decompressor # (arm, x86). # # - arch/alpha/lib/Makefile builds lib.a which is linked not only to # vmlinux, but also to bootloaders in arch/alpha/boot/Makefile. # # - arch/xtensa/boot/lib/Makefile builds lib.a for use from # arch/xtensa/boot/boot-redboot/Makefile. # # One more thing, adding everything to obj-y would increase the vmlinux # size of allnoconfig (or tinyconfig). # # For less impact, I tweaked the destination of lib.a at the top Makefile; # when CONFIG_MODULES=y, lib.a goes to KBUILD_VMLINUX_OBJS, which is # forcibly linked to vmlinux, otherwise lib.a goes to KBUILD_VMLINUX_LIBS # as before. # # The size impact for normal usecases is quite small since at lease one # symbol in every lib-y object is eventually called by someone. In case # you are intrested, here are the figures. # # x86_64_defconfig: # # text data bss dec hex filename # 19566602 5422072 1589328 26578002 1958c52 vmlinux.before # 19566932 5422104 1589328 26578364 1958dbc vmlinux.after # # The case with the biggest impact is allnoconfig + CONFIG_MODULES=y. # # ARCH=x86 allnoconfig + CONFIG_MODULES=y: # # text data bss dec hex filename # 1175162 254740 1220608 2650510 28718e vmlinux.before # 1177974 254836 1220608 2653418 287cea vmlinux.after # # Hopefully this is still not a big deal. The per-file trimming with the # static library is not so effective after all. # # If fine-grained optimization is desired, some architectures support # CONFIG_LD_DEAD_CODE_DATA_ELIMINATION, which trims dead code per-symbol # basis. When LTO is supported in mainline, even better optimization will # be possible. # # Link: https://github.com/ClangBuiltLinux/linux/issues/515 # Signed-off-by: Masahiro Yamada # Reported-by: kbuild test robot # Reviewed-by: Nick Desaulniers # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-ld --version # < git log --format=%s --max-count=1 58bb4f7d4970e92c2400208a1b48aae3b2853e5c # < make -s -j 48 ARCH=powerpc O=/kisskb/build/kbuild_cell_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- cell_defconfig # < make -s -j 48 ARCH=powerpc O=/kisskb/build/kbuild_cell_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- help # make -s -j 48 ARCH=powerpc O=/kisskb/build/kbuild_cell_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- olddefconfig # make -s -j 48 ARCH=powerpc O=/kisskb/build/kbuild_cell_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:72:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:401:21: note: 'pdeo' was declared here /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:247:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:227:19: note: 'i' was declared here /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:204:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/ext4/extents.c: In function 'ext4_convert_unwritten_io_end_vec': /kisskb/src/fs/ext4/extents.c:5009:23: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c: In function 'tun_get_user': /kisskb/src/drivers/net/tun.c:1799:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c:1712:46: warning: 'linear' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/namei.c: In function 'handle_dots': /kisskb/src/fs/namei.c:1805:10: warning: 'inode' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/namei.c:1805:10: warning: 'seq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page': /kisskb/src/mm/hugetlb.c:1741:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/udf/unicode.c: In function 'udf_name_conv_char': /kisskb/src/fs/udf/unicode.c:132:8: warning: 'c' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/trace/trace_events.c: In function 'event_create_dir': /kisskb/src/kernel/trace/trace_events.c:2040:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/usb/core/devio.c: In function 'async_completed': /kisskb/src/drivers/usb/core/devio.c:625:23: warning: 'errno' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/io_uring.c: In function '__io_sqe_files_update': /kisskb/src/fs/io_uring.c:6617:13: warning: 'err' may be used uninitialized in this function [-Wuninitialized] Completed OK # rm -rf /kisskb/build/kbuild_cell_defconfig_powerpc-gcc4.6 # Build took: 0:01:20.149872