# git rev-parse -q --verify 7ccc9de5c708922203eee06901af49b3f47207aa^{commit}
7ccc9de5c708922203eee06901af49b3f47207aa
already have revision, skipping fetch
# git checkout -q -f -B kisskb 7ccc9de5c708922203eee06901af49b3f47207aa
# git clean -qxdf
# < git log -1
# commit 7ccc9de5c708922203eee06901af49b3f47207aa
# Author: Gustavo A. R. Silva <gustavo@embeddedor.com>
# Date:   Fri Feb 21 09:32:33 2020 -0600
# 
#     firmware: google: vpd: Replace zero-length array with flexible-array member
#     
#     The current codebase makes use of the zero-length array language
#     extension to the C90 standard, but the preferred mechanism to declare
#     variable-length types such as these ones is a flexible array member[1][2],
#     introduced in C99:
#     
#     struct foo {
#             int stuff;
#             struct boo array[];
#     };
#     
#     By making use of the mechanism above, we will get a compiler warning
#     in case the flexible array does not occur last in the structure, which
#     will help us prevent some kind of undefined behavior bugs from being
#     inadvertently introduced[3] to the codebase from now on.
#     
#     Also, notice that, dynamic memory allocations won't be affected by
#     this change:
#     
#     "Flexible array members have incomplete type, and so the sizeof operator
#     may not be applied. As a quirk of the original implementation of
#     zero-length arrays, sizeof evaluates to zero."[1]
#     
#     This issue was found with the help of Coccinelle.
#     
#     [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
#     [2] https://github.com/KSPP/linux/issues/21
#     [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
#     
#     Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
# < /opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux-gcc --version
# < /opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux-ld --version
# < git log --format=%s --max-count=1 7ccc9de5c708922203eee06901af49b3f47207aa
# < make -s -j 8 ARCH=sparc64 O=/kisskb/build/gustavoars_sparc64-allmodconfig_sparc64 CROSS_COMPILE=/opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux-  allmodconfig
# Added to kconfig CONFIG_BUILD_DOCSRC=n
# Added to kconfig CONFIG_HAVE_FTRACE_MCOUNT_RECORD=n
# Added to kconfig CONFIG_SAMPLES=n
# Added to kconfig CONFIG_MODULE_SIG=n
# < make -s -j 8 ARCH=sparc64 O=/kisskb/build/gustavoars_sparc64-allmodconfig_sparc64 CROSS_COMPILE=/opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux-  help
# make -s -j 8 ARCH=sparc64 O=/kisskb/build/gustavoars_sparc64-allmodconfig_sparc64 CROSS_COMPILE=/opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux-  olddefconfig
# make -s -j 8 ARCH=sparc64 O=/kisskb/build/gustavoars_sparc64-allmodconfig_sparc64 CROSS_COMPILE=/opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux-  
<stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
/kisskb/src/kernel/futex.c: In function 'do_futex':
/kisskb/src/kernel/futex.c:1676:17: warning: 'oldval' may be used uninitialized in this function [-Wmaybe-uninitialized]
   return oldval == cmparg;
                 ^
/kisskb/src/kernel/futex.c:1652:6: note: 'oldval' was declared here
  int oldval, ret;
      ^
/kisskb/src/fs/cifs/smb2pdu.c: In function 'SMB2_ioctl_init':
/kisskb/src/fs/cifs/smb2pdu.c:2899:19: warning: 'in_data_buf' may be used uninitialized in this function [-Wmaybe-uninitialized]
   iov[1].iov_base = in_data_buf;
                   ^
/kisskb/src/net/mptcp/protocol.c: In function 'mptcp_sendmsg_frag':
/kisskb/src/net/mptcp/protocol.c:606:6: warning: 'dfrag_collapsed' may be used uninitialized in this function [-Wmaybe-uninitialized]
   if (!dfrag_collapsed) {
      ^
In file included from /kisskb/src/include/linux/rwsem.h:16:0,
                 from /kisskb/src/include/linux/notifier.h:15,
                 from /kisskb/src/include/linux/clk.h:14,
                 from /kisskb/src/drivers/tty/serial/sh-sci.c:20:
/kisskb/src/drivers/tty/serial/sh-sci.c: In function 'sci_dma_rx_submit':
/kisskb/src/include/linux/spinlock.h:289:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
   _raw_spin_unlock_irqrestore(lock, flags); \
   ^
/kisskb/src/drivers/tty/serial/sh-sci.c:1348:16: note: 'flags' was declared here
  unsigned long flags;
                ^
/kisskb/src/drivers/i2c/busses/i2c-sh_mobile.c: In function 'sh_mobile_i2c_isr':
/kisskb/src/drivers/i2c/busses/i2c-sh_mobile.c:396:26: warning: 'data' may be used uninitialized in this function [-Wmaybe-uninitialized]
   pd->msg->buf[real_pos] = data;
                          ^
/kisskb/src/drivers/i2c/busses/i2c-sh_mobile.c:369:16: note: 'data' was declared here
  unsigned char data;
                ^
/kisskb/src/drivers/input/joystick/analog.c:160:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp]
 #warning Precise timer not defined for this architecture.
  ^
  kernel: arch/sparc/boot/image is ready
  kernel: arch/sparc/boot/zImage is ready
warning: same module names found:
  drivers/char/adi.ko
  drivers/input/joystick/adi.ko
Completed OK
# rm -rf /kisskb/build/gustavoars_sparc64-allmodconfig_sparc64
# Build took: 0:33:03.680988