# git rev-parse -q --verify c27cd1c3b9197a83d974f7dcc60c321fff9991ff^{commit} # git fetch -q -n -f https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git for-next/kspp warning: The last gc run reported the following. Please correct the root cause and remove .git/gc.log. Automatic cleanup will not be performed until the file is removed. warning: There are too many unreachable loose objects; run 'git prune' to remove them. # git rev-parse -q --verify c27cd1c3b9197a83d974f7dcc60c321fff9991ff^{commit} c27cd1c3b9197a83d974f7dcc60c321fff9991ff # git checkout -q -f -B kisskb c27cd1c3b9197a83d974f7dcc60c321fff9991ff # git clean -qxdf # < git log -1 # commit c27cd1c3b9197a83d974f7dcc60c321fff9991ff # Author: Gustavo A. R. Silva # Date: Mon May 25 16:23:22 2020 -0500 # # treewide: Replace zero-length array with flexible-array # # The current codebase makes use of the zero-length array language # extension to the C90 standard, but the preferred mechanism to declare # variable-length types such as these ones is a flexible array member[1][2], # introduced in C99: # # struct foo { # int stuff; # struct boo array[]; # }; # # By making use of the mechanism above, we will get a compiler warning # in case the flexible array does not occur last in the structure, which # will help us prevent some kind of undefined behavior bugs from being # inadvertently introduced[3] to the codebase from now on. # # Also, notice that, dynamic memory allocations won't be affected by # this change: # # "Flexible array members have incomplete type, and so the sizeof operator # may not be applied. As a quirk of the original implementation of # zero-length arrays, sizeof evaluates to zero."[1] # # sizeof(flexible-array-member) triggers a warning because flexible array # members have incomplete type[1]. There are some instances of code in # which the sizeof operator is being incorrectly/erroneously applied to # zero-length arrays and the result is zero. Such instances may be hiding # some bugs. So, this work (flexible-array member conversions) will also # help to get completely rid of those sorts of issues. # # Notice that, currently, more than 250 of these patches have already # been merged into mainline during the last merge window, including # 5.7-rc2. So, in order to make better use of everyone's time, I'm # planning to add this treewide patch to my -next tree and then send a # pull request to Linus for 5.7-rc3 or -rc4, after getting some acks # and/or reviews. # # This treewide patch has been successfully built (on top of v5.7-rc1) for # multiple architectures (arm, arm64, sparc, powerpc, ia64, s390, i386, # nios2, c6x, xtensa, openrisc, mips, parisc, x86_64, riscv, sh, sparc64) # and 82 different configurations with the help of the 0-day CI guys[5]. # # This issue was found with the help of Coccinelle. # # [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html # [2] https://github.com/KSPP/linux/issues/21 # [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") # [4] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/?qt=grep&q=replace+zero-length+array+with+flexible-array+member # [5] https://github.com/GustavoARSilva/linux-hardening/blob/master/cii/kernel-ci/kspp-fam0-20200420.md # # Signed-off-by: Gustavo A. R. Silva # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 c27cd1c3b9197a83d974f7dcc60c321fff9991ff # < make -s -j 48 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_defconfig # < make -s -j 48 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 48 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 48 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/include/linux/kernel.h:11, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/module.h:12, from /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:15: /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 22 | #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) | ^ /kisskb/src/include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:139:6: note: in expansion of macro 'IS_ERR_VALUE' 139 | if (IS_ERR_VALUE(fep->ring_mem_addr)) | ^~~~~~~~~~~~ /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) INFO: Uncompressed kernel (size 0xe3c478) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe3c478) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe3c478) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe3c478) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe3c478) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe3c478) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe3c478) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe3c478) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe3c478) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe3c478) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe3c478) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe3c478) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe3c478) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe3c478) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe3c478) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) INFO: Uncompressed kernel (size 0xe2bc74) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xf00000) Image Name: Linux-5.7.0-rc2-14550-gc27cd1c3b Created: Wed May 27 03:56:56 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6740801 Bytes = 6582.81 KiB = 6.43 MiB Load Address: 00000000 Entry Point: 00000000 Image Name: Linux-5.7.0-rc2-14550-gc27cd1c3b Created: Wed May 27 03:56:58 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6776092 Bytes = 6617.28 KiB = 6.46 MiB Load Address: 00f00000 Entry Point: 00f002cc Image Name: Linux-5.7.0-rc2-14550-gc27cd1c3b Created: Wed May 27 03:56:58 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6775871 Bytes = 6617.06 KiB = 6.46 MiB Load Address: 00f00000 Entry Point: 00f002cc Image Name: Linux-5.7.0-rc2-14550-gc27cd1c3b Created: Wed May 27 03:56:58 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6775880 Bytes = 6617.07 KiB = 6.46 MiB Load Address: 00f00000 Entry Point: 00f0031c Image Name: Linux-5.7.0-rc2-14550-gc27cd1c3b Created: Wed May 27 03:56:58 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6776260 Bytes = 6617.44 KiB = 6.46 MiB Load Address: 00f00000 Entry Point: 00f002cc Image Name: Linux-5.7.0-rc2-14550-gc27cd1c3b Created: Wed May 27 03:56:58 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6775900 Bytes = 6617.09 KiB = 6.46 MiB Load Address: 00f00000 Entry Point: 00f002cc Image Name: Linux-5.7.0-rc2-14550-gc27cd1c3b Created: Wed May 27 03:56:59 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6776161 Bytes = 6617.34 KiB = 6.46 MiB Load Address: 00f00000 Entry Point: 00f002cc Image Name: Linux-5.7.0-rc2-14550-gc27cd1c3b Created: Wed May 27 03:57:00 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6775596 Bytes = 6616.79 KiB = 6.46 MiB Load Address: 00f00000 Entry Point: 00f0031c Image Name: Linux-5.7.0-rc2-14550-gc27cd1c3b Created: Wed May 27 03:57:00 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6775599 Bytes = 6616.80 KiB = 6.46 MiB Load Address: 00f00000 Entry Point: 00f002cc Image Name: Linux-5.7.0-rc2-14550-gc27cd1c3b Created: Wed May 27 03:57:00 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6775964 Bytes = 6617.15 KiB = 6.46 MiB Load Address: 00f00000 Entry Point: 00f0031c Image Name: Linux-5.7.0-rc2-14550-gc27cd1c3b Created: Wed May 27 03:57:00 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6775625 Bytes = 6616.82 KiB = 6.46 MiB Load Address: 00f00000 Entry Point: 00f002cc Image Name: Linux-5.7.0-rc2-14550-gc27cd1c3b Created: Wed May 27 03:57:00 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6775735 Bytes = 6616.93 KiB = 6.46 MiB Load Address: 00f00000 Entry Point: 00f0031c Image Name: Linux-5.7.0-rc2-14550-gc27cd1c3b Created: Wed May 27 03:57:00 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6775869 Bytes = 6617.06 KiB = 6.46 MiB Load Address: 00f00000 Entry Point: 00f002cc Image Name: Linux-5.7.0-rc2-14550-gc27cd1c3b Created: Wed May 27 03:57:00 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6775594 Bytes = 6616.79 KiB = 6.46 MiB Load Address: 00f00000 Entry Point: 00f0031c Image Name: Linux-5.7.0-rc2-14550-gc27cd1c3b Created: Wed May 27 03:57:00 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6775866 Bytes = 6617.06 KiB = 6.46 MiB Load Address: 00f00000 Entry Point: 00f002cc Image Name: Linux-5.7.0-rc2-14550-gc27cd1c3b Created: Wed May 27 03:57:00 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6776169 Bytes = 6617.35 KiB = 6.46 MiB Load Address: 00f00000 Entry Point: 00f002cc Completed OK # rm -rf /kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 # Build took: 0:02:32.059265