# git rev-parse -q --verify ec7b8eb9bc7a519047485c95f7292b48f5b73fe6^{commit} ec7b8eb9bc7a519047485c95f7292b48f5b73fe6 already have revision, skipping fetch # git checkout -q -f -B kisskb ec7b8eb9bc7a519047485c95f7292b48f5b73fe6 # git clean -qxdf # < git log -1 # commit ec7b8eb9bc7a519047485c95f7292b48f5b73fe6 # Author: Jessica Yu # Date: Wed Apr 8 16:31:06 2020 +0200 # # module: break nested ARCH_HAS_STRICT_MODULE_RWX and STRICT_MODULE_RWX #ifdefs # # Various frob_* and module_{enable,disable}_* functions are defined in a # CONFIG_ARCH_HAS_STRICT_MODULE_RWX ifdef block which also has a nested # CONFIG_STRICT_MODULE_RWX ifdef block within it. This is unecessary and # makes things hard to read. Not only that, this construction requires # redundant empty stubs for module_enable_nx(). I suspect this was # originally done for cosmetic reasons - to keep all the frob_* functions # in the same place, and all the module_{enable,disable}_* functions right # after, but as a result it made the code harder to read. # # Make this more readable by unnesting the ifdef blocks and getting rid of # the redundant empty stubs. # # Signed-off-by: Jessica Yu # [mpe: Cherry-pick to fix build breakage] # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 ec7b8eb9bc7a519047485c95f7292b48f5b73fe6 # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-merge_pseries_defconfig+NO_MEMORY_HOTPLUG_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- pseries_defconfig # Added to kconfig CONFIG_MEMORY_HOTPLUG=n # Added to kconfig CONFIG_MEMORY_HOTREMOVE=n # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-merge_pseries_defconfig+NO_MEMORY_HOTPLUG_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-merge_pseries_defconfig+NO_MEMORY_HOTPLUG_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-merge_pseries_defconfig+NO_MEMORY_HOTPLUG_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c:666:13: warning: 'cxgb4_uld_in_use' defined but not used [-Wunused-function] static bool cxgb4_uld_in_use(struct adapter *adap) ^ Completed OK # rm -rf /kisskb/build/powerpc-merge_pseries_defconfig+NO_MEMORY_HOTPLUG_powerpc-gcc5 # Build took: 0:02:51.724404