# git rev-parse -q --verify 625d3449788f85569096780592549d0340e9c0c7^{commit} 625d3449788f85569096780592549d0340e9c0c7 already have revision, skipping fetch # git checkout -q -f -B kisskb 625d3449788f85569096780592549d0340e9c0c7 # git clean -qxdf # < git log -1 # commit 625d3449788f85569096780592549d0340e9c0c7 # Author: Jason A. Donenfeld # Date: Sun Jun 21 21:02:22 2020 -0600 # # Revert "kernel/printk: add kmsg SEEK_CUR handling" # # This reverts commit 8ece3b3eb576a78d2e67ad4c3a80a39fa6708809. # # This commit broke userspace. Bash uses ESPIPE to determine whether or # not the file should be read using "unbuffered I/O", which means reading # 1 byte at a time instead of 128 bytes at a time. I used to use bash to # read through kmsg in a really quite nasty way: # # while read -t 0.1 -r line 2>/dev/null || [[ $? -ne 142 ]]; do # echo "SARU $line" # done < /dev/kmsg # # This will show all lines that can fit into the 128 byte buffer, and skip # lines that don't. That's pretty awful, but at least it worked. # # With this change, bash now tries to do 1-byte reads, which means it # skips all the lines, which is worse than before. # # Now, I don't really care very much about this, and I'm already look for # a workaround. But I did just spend an hour trying to figure out why my # scripts were broken. Either way, it makes no difference to me personally # whether this is reverted, but it might be something to consider. If you # declare that "trying to read /dev/kmsg with bash is terminally stupid # anyway," I might be inclined to agree with you. But do note that bash # uses lseek(fd, 0, SEEK_CUR)==>ESPIPE to determine whether or not it's # reading from a pipe. # # Cc: Bruno Meneguele # Cc: Sergey Senozhatsky # Cc: Steven Rostedt # Cc: David Laight # Cc: Sergey Senozhatsky # Cc: Petr Mladek # Signed-off-by: Jason A. Donenfeld # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 625d3449788f85569096780592549d0340e9c0c7 # < make -s -j 24 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- randconfig KCONFIG_SEED=0xB30850B8 # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # Added to kconfig CONFIG_TRIM_UNUSED_KSYMS=n # Added to kconfig CONFIG_UBSAN=n # < make -s -j 24 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 24 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:4471:warning: override: reassigning to symbol STANDALONE .config:4474:warning: override: reassigning to symbol CPU_BIG_ENDIAN .config:4474:warning: override: CPU_BIG_ENDIAN changes choice state .config:4476:warning: override: reassigning to symbol PPC_DISABLE_WERROR .config:4478:warning: override: reassigning to symbol PREVENT_FIRMWARE_BUILD # make -s -j 24 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/mm/memory.c:87:2: warning: #warning Unfortunate NUMA and NUMA Balancing config, growing page-frame for last_cpupid. [-Wcpp] #warning Unfortunate NUMA and NUMA Balancing config, growing page-frame for last_cpupid. ^ /kisskb/src/mm/memory.c:87:2: warning: #warning Unfortunate NUMA and NUMA Balancing config, growing page-frame for last_cpupid. [-Wcpp] #warning Unfortunate NUMA and NUMA Balancing config, growing page-frame for last_cpupid. ^ /kisskb/src/drivers/vfio/pci/vfio_pci_nvlink2.c: In function 'vfio_pci_nvgpu_release': /kisskb/src/drivers/vfio/pci/vfio_pci_nvlink2.c:101:4: error: implicit declaration of function 'mm_iommu_put' [-Werror=implicit-function-declaration] ret = mm_iommu_put(data->mm, data->mem); ^ /kisskb/src/drivers/vfio/pci/vfio_pci_nvlink2.c: In function 'vfio_pci_nvgpu_mmap': /kisskb/src/drivers/vfio/pci/vfio_pci_nvlink2.c:165:2: error: implicit declaration of function 'mm_iommu_newdev' [-Werror=implicit-function-declaration] ret = (int) mm_iommu_newdev(data->mm, data->useraddr, ^ cc1: some warnings being treated as errors make[4]: *** [/kisskb/src/scripts/Makefile.build:281: drivers/vfio/pci/vfio_pci_nvlink2.o] Error 1 make[3]: *** [/kisskb/src/scripts/Makefile.build:497: drivers/vfio/pci] Error 2 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:497: drivers/vfio] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1756: drivers] Error 2 make: *** [Makefile:185: __sub-make] Error 2 Command 'make -s -j 24 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc4.9 # Build took: 0:04:45.608038