Buildresult: linus/s390-defconfig/s390x-gcc4.9 built on Jun 22 2020, 19:05

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

🌟 kisskb is no longer producing new builds, old results are still available.

Status:	OK
Date/Time:	Jun 22 2020, 19:05
Duration:	0:03:51.190342
Builder:	ka1
Revision:	Revert "kernel/printk: add kmsg SEEK_CUR handling" (`625d3449788f85569096780592549d0340e9c0c7)`
Target:	linus/s390-defconfig/s390x-gcc4.9
Branch:	linus
Compiler:	s390x-gcc4.9 (s390-linux-gcc (GCC) 4.9.4 / GNU ld (GNU Binutils) 2.29.1.20170915)
Config:	defconfig (download)
Log:	Download original Possible warnings (6) net/smc/smc_llc.c:1145:9: warning: missing braces around initializer [-Wmissing-braces] net/smc/smc_llc.c:1145:9: warning: (near initialization for 'add_llc.hd') [-Wmissing-braces] net/smc/smc_llc.c:1178:9: warning: missing braces around initializer [-Wmissing-braces] net/smc/smc_llc.c:1178:9: warning: (near initialization for 'del_llc.hd') [-Wmissing-braces] net/smc/smc_llc.c:1250:9: warning: missing braces around initializer [-Wmissing-braces] net/smc/smc_llc.c:1250:9: warning: (near initialization for 'delllc.hd') [-Wmissing-braces] Full Log # git rev-parse -q --verify 625d3449788f85569096780592549d0340e9c0c7^{commit} 625d3449788f85569096780592549d0340e9c0c7 already have revision, skipping fetch # git checkout -q -f -B kisskb 625d3449788f85569096780592549d0340e9c0c7 # git clean -qxdf # < git log -1 # commit 625d3449788f85569096780592549d0340e9c0c7 # Author: Jason A. Donenfeld <Jason@zx2c4.com> # Date: Sun Jun 21 21:02:22 2020 -0600 # # Revert "kernel/printk: add kmsg SEEK_CUR handling" # # This reverts commit 8ece3b3eb576a78d2e67ad4c3a80a39fa6708809. # # This commit broke userspace. Bash uses ESPIPE to determine whether or # not the file should be read using "unbuffered I/O", which means reading # 1 byte at a time instead of 128 bytes at a time. I used to use bash to # read through kmsg in a really quite nasty way: # # while read -t 0.1 -r line 2>/dev/null \|\| [[ $? -ne 142 ]]; do # echo "SARU $line" # done < /dev/kmsg # # This will show all lines that can fit into the 128 byte buffer, and skip # lines that don't. That's pretty awful, but at least it worked. # # With this change, bash now tries to do 1-byte reads, which means it # skips all the lines, which is worse than before. # # Now, I don't really care very much about this, and I'm already look for # a workaround. But I did just spend an hour trying to figure out why my # scripts were broken. Either way, it makes no difference to me personally # whether this is reverted, but it might be something to consider. If you # declare that "trying to read /dev/kmsg with bash is terminally stupid # anyway," I might be inclined to agree with you. But do note that bash # uses lseek(fd, 0, SEEK_CUR)==>ESPIPE to determine whether or not it's # reading from a pipe. # # Cc: Bruno Meneguele <bmeneg@redhat.com> # Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> # Cc: Steven Rostedt <rostedt@goodmis.org> # Cc: David Laight <David.Laight@ACULAB.COM> # Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> # Cc: Petr Mladek <pmladek@suse.com> # Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/s390-linux/bin/s390-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/s390-linux/bin/s390-linux-ld --version # < git log --format=%s --max-count=1 625d3449788f85569096780592549d0340e9c0c7 # < make -s -j 24 ARCH=s390 O=/kisskb/build/linus_s390-defconfig_s390x-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/s390-linux/bin/s390-linux- defconfig # < make -s -j 24 ARCH=s390 O=/kisskb/build/linus_s390-defconfig_s390x-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/s390-linux/bin/s390-linux- help # make -s -j 24 ARCH=s390 O=/kisskb/build/linus_s390-defconfig_s390x-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/s390-linux/bin/s390-linux- olddefconfig # make -s -j 24 ARCH=s390 O=/kisskb/build/linus_s390-defconfig_s390x-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/s390-linux/bin/s390-linux- /kisskb/src/net/smc/smc_llc.c: In function 'smc_llc_srv_add_link_local': /kisskb/src/net/smc/smc_llc.c:1145:9: warning: missing braces around initializer [-Wmissing-braces] struct smc_llc_msg_add_link add_llc = {0}; ^ /kisskb/src/net/smc/smc_llc.c:1145:9: warning: (near initialization for 'add_llc.hd') [-Wmissing-braces] /kisskb/src/net/smc/smc_llc.c: In function 'smc_llc_srv_delete_link_local': /kisskb/src/net/smc/smc_llc.c:1178:9: warning: missing braces around initializer [-Wmissing-braces] struct smc_llc_msg_del_link del_llc = {0}; ^ /kisskb/src/net/smc/smc_llc.c:1178:9: warning: (near initialization for 'del_llc.hd') [-Wmissing-braces] /kisskb/src/net/smc/smc_llc.c: In function 'smc_llc_send_link_delete_all': /kisskb/src/net/smc/smc_llc.c:1250:9: warning: missing braces around initializer [-Wmissing-braces] struct smc_llc_msg_del_link delllc = {0}; ^ /kisskb/src/net/smc/smc_llc.c:1250:9: warning: (near initialization for 'delllc.hd') [-Wmissing-braces] Completed OK # rm -rf /kisskb/build/linus_s390-defconfig_s390x-gcc4.9 # Build took: 0:03:51.190342

© Michael Ellerman 2006-2018.