# git rev-parse -q --verify 625d3449788f85569096780592549d0340e9c0c7^{commit} 625d3449788f85569096780592549d0340e9c0c7 already have revision, skipping fetch # git checkout -q -f -B kisskb 625d3449788f85569096780592549d0340e9c0c7 # git clean -qxdf # < git log -1 # commit 625d3449788f85569096780592549d0340e9c0c7 # Author: Jason A. Donenfeld # Date: Sun Jun 21 21:02:22 2020 -0600 # # Revert "kernel/printk: add kmsg SEEK_CUR handling" # # This reverts commit 8ece3b3eb576a78d2e67ad4c3a80a39fa6708809. # # This commit broke userspace. Bash uses ESPIPE to determine whether or # not the file should be read using "unbuffered I/O", which means reading # 1 byte at a time instead of 128 bytes at a time. I used to use bash to # read through kmsg in a really quite nasty way: # # while read -t 0.1 -r line 2>/dev/null || [[ $? -ne 142 ]]; do # echo "SARU $line" # done < /dev/kmsg # # This will show all lines that can fit into the 128 byte buffer, and skip # lines that don't. That's pretty awful, but at least it worked. # # With this change, bash now tries to do 1-byte reads, which means it # skips all the lines, which is worse than before. # # Now, I don't really care very much about this, and I'm already look for # a workaround. But I did just spend an hour trying to figure out why my # scripts were broken. Either way, it makes no difference to me personally # whether this is reverted, but it might be something to consider. If you # declare that "trying to read /dev/kmsg with bash is terminally stupid # anyway," I might be inclined to agree with you. But do note that bash # uses lseek(fd, 0, SEEK_CUR)==>ESPIPE to determine whether or not it's # reading from a pipe. # # Cc: Bruno Meneguele # Cc: Sergey Senozhatsky # Cc: Steven Rostedt # Cc: David Laight # Cc: Sergey Senozhatsky # Cc: Petr Mladek # Signed-off-by: Jason A. Donenfeld # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux-ld --version # < git log --format=%s --max-count=1 625d3449788f85569096780592549d0340e9c0c7 # < make -s -j 48 ARCH=mips O=/kisskb/build/linus_mips-allnoconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux- allnoconfig # < make -s -j 48 ARCH=mips O=/kisskb/build/linus_mips-allnoconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux- help # make -s -j 48 ARCH=mips O=/kisskb/build/linus_mips-allnoconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux- olddefconfig # make -s -j 48 ARCH=mips O=/kisskb/build/linus_mips-allnoconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux- FIT description: Linux 5.8.0-rc2+ Created: Mon Jun 22 21:22:11 2020 Image 0 (kernel@0) Description: Linux 5.8.0-rc2+ Created: Mon Jun 22 21:22:11 2020 Type: Kernel Image Compression: gzip compressed Data Size: 667056 Bytes = 651.42 KiB = 0.64 MiB Architecture: MIPS OS: Linux Load Address: 0x80100000 Entry Point: 0x8022cc6c Hash algo: sha1 Hash value: 89bf17441ebbde0af43b4d874407cb034b96ba10 Default Configuration: 'conf@default' Configuration 0 (conf@default) Description: Generic Linux kernel Kernel: kernel@0 Completed OK # rm -rf /kisskb/build/linus_mips-allnoconfig_mips-gcc8 # Build took: 0:00:24.012122