Buildresult: powerpc-fixes/versatile_defconfig/arm-gcc4.9 built on Jun 30 2020, 00:10

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Jun 30 2020, 00:10
Duration:	0:01:03.021204
Builder:	blade4b
Revision:	powerpc/mm/pkeys: Make pkey access check work on execute_only_key (`19ab500edb5d6020010caba48ce3b4ce4182ab63)`
Target:	powerpc-fixes/versatile_defconfig/arm-gcc4.9
Branch:	powerpc-fixes
Compiler:	arm-gcc4.9 (arm-linux-gnueabi-gcc (GCC) 4.9.4 / GNU ld (GNU Binutils) 2.29.1.20170915)
Config:	versatile_defconfig (download)
Log:	Download original No warnings found in log. Full Log # git rev-parse -q --verify 19ab500edb5d6020010caba48ce3b4ce4182ab63^{commit} 19ab500edb5d6020010caba48ce3b4ce4182ab63 already have revision, skipping fetch # git checkout -q -f -B kisskb 19ab500edb5d6020010caba48ce3b4ce4182ab63 # git clean -qxdf # < git log -1 # commit 19ab500edb5d6020010caba48ce3b4ce4182ab63 # Author: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> # Date: Sat Jun 27 12:31:46 2020 +0530 # # powerpc/mm/pkeys: Make pkey access check work on execute_only_key # # Jan reported that LTP mmap03 was getting stuck in a page fault loop # after commit c46241a370a6 ("powerpc/pkeys: Check vma before returning # key fault error to the user"), as well as a minimised reproducer: # # #include <fcntl.h> # #include <stdio.h> # #include <stdlib.h> # #include <unistd.h> # #include <sys/mman.h> # # int main(int ac, char *av) # { # int page_sz = getpagesize(); # int fildes; # char addr; # # fildes = open("tempfile", O_WRONLY \| O_CREAT, 0666); # write(fildes, &fildes, sizeof(fildes)); # close(fildes); # # fildes = open("tempfile", O_RDONLY); # unlink("tempfile"); # # addr = mmap(0, page_sz, PROT_EXEC, MAP_FILE \| MAP_PRIVATE, fildes, 0); # # printf("%d\n", *addr); # return 0; # } # # And noticed that access_pkey_error() in page fault handler now always # seem to return false: # # __do_page_fault # access_pkey_error(is_pkey: 1, is_exec: 0, is_write: 0) # arch_vma_access_permitted # pkey_access_permitted # if (!is_pkey_enabled(pkey)) # return true # return false # # pkey_access_permitted() should not check if the pkey is available in # UAMOR (using is_pkey_enabled()). The kernel needs to do that check # only when allocating keys. This also makes sure the execute_only_key # which is marked as non-manageable via UAMOR is handled correctly in # pkey_access_permitted(), and fixes the bug. # # Fixes: c46241a370a6 ("powerpc/pkeys: Check vma before returning key fault error to the user") # Reported-by: Jan Stancek <jstancek@redhat.com> # Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> # [mpe: Include bug report details etc. in the change log] # Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> # Link: https://lore.kernel.org/r/20200627070147.297535-1-aneesh.kumar@linux.ibm.com # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi-ld --version # < git log --format=%s --max-count=1 19ab500edb5d6020010caba48ce3b4ce4182ab63 # < make -s -j 24 ARCH=arm O=/kisskb/build/powerpc-fixes_versatile_defconfig_arm-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi- versatile_defconfig # < make -s -j 24 ARCH=arm O=/kisskb/build/powerpc-fixes_versatile_defconfig_arm-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi- help # make -s -j 24 ARCH=arm O=/kisskb/build/powerpc-fixes_versatile_defconfig_arm-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi- olddefconfig # make -s -j 24 ARCH=arm O=/kisskb/build/powerpc-fixes_versatile_defconfig_arm-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi- Completed OK # rm -rf /kisskb/build/powerpc-fixes_versatile_defconfig_arm-gcc4.9 # Build took: 0:01:03.021204

© Michael Ellerman 2006-2018.