# git rev-parse -q --verify bb5a93aaf25261321db0c499cde7da6ee9d8b164^{commit} bb5a93aaf25261321db0c499cde7da6ee9d8b164 already have revision, skipping fetch # git checkout -q -f -B kisskb bb5a93aaf25261321db0c499cde7da6ee9d8b164 # git clean -qxdf # < git log -1 # commit bb5a93aaf25261321db0c499cde7da6ee9d8b164 # Author: Linus Torvalds # Date: Sun Jul 5 12:50:20 2020 -0700 # # x86/ldt: use "pr_info_once()" instead of open-coding it badly # # Using a mutex for "print this warning only once" is so overdesigned as # to be actively offensive to my sensitive stomach. # # Just use "pr_info_once()" that already does this, although in a # (harmlessly) racy manner that can in theory cause the message to be # printed twice if more than one CPU races on that "is this the first # time" test. # # [ If somebody really cares about that harmless data race (which sounds # very unlikely indeed), that person can trivially fix printk_once() by # using a simple atomic access, preferably with an optimistic non-atomic # test first before even bothering to treat the pointless "make sure it # is _really_ just once" case. # # A mutex is most definitely never the right primitive to use for # something like this. ] # # Yes, this is a small and meaningless detail in a code path that hardly # matters. But let's keep some code quality standards here, and not # accept outrageously bad code. # # Link: https://lore.kernel.org/lkml/CAHk-=wgV9toS7GU3KmNpj8hCS9SeF+A0voHS8F275_mgLhL4Lw@mail.gmail.com/ # Cc: Andy Lutomirski # Cc: Thomas Gleixner # Cc: Peter Zijlstra (Intel) # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux-ld --version # < git log --format=%s --max-count=1 bb5a93aaf25261321db0c499cde7da6ee9d8b164 # < make -s -j 48 ARCH=ia64 O=/kisskb/build/linus_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux- defconfig # < make -s -j 48 ARCH=ia64 O=/kisskb/build/linus_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux- help # make -s -j 48 ARCH=ia64 O=/kisskb/build/linus_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux- olddefconfig # make -s -j 48 ARCH=ia64 O=/kisskb/build/linus_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux- :1511:2: warning: #warning syscall clone3 not implemented [-Wcpp] In file included from /kisskb/src/arch/ia64/include/uapi/asm/intrinsics.h:22:0, from /kisskb/src/arch/ia64/include/asm/intrinsics.h:11, from /kisskb/src/arch/ia64/include/asm/bitops.h:19, from /kisskb/src/include/linux/bitops.h:29, from /kisskb/src/include/linux/kernel.h:12, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/preempt.h:11, from /kisskb/src/include/linux/spinlock.h:51, from /kisskb/src/include/linux/seqlock.h:36, from /kisskb/src/include/linux/time.h:6, from /kisskb/src/fs/nfs/read.c:11: /kisskb/src/fs/nfs/read.c: In function 'nfs_read_completion': /kisskb/src/arch/ia64/include/uapi/asm/cmpxchg.h:57:2: warning: value computed is not used [-Wunused-value] ((__typeof__(*(ptr))) __xchg((unsigned long) (x), (ptr), sizeof(*(ptr)))) ^ /kisskb/src/fs/nfs/read.c:196:5: note: in expansion of macro 'xchg' xchg(&nfs_req_openctx(req)->error, error); ^ /kisskb/src/fs/nfs/read.c: In function 'nfs_readpage': /kisskb/src/arch/ia64/include/uapi/asm/cmpxchg.h:57:2: warning: value computed is not used [-Wunused-value] ((__typeof__(*(ptr))) __xchg((unsigned long) (x), (ptr), sizeof(*(ptr)))) ^ /kisskb/src/fs/nfs/read.c:355:2: note: in expansion of macro 'xchg' xchg(&ctx->error, 0); ^ No errors detected in 22247 functions. Completed OK # rm -rf /kisskb/build/linus_ia64-defconfig_ia64-gcc4.9 # Build took: 0:02:16.529593