Buildresult: linus/multi_v7_defconfig/arm-gcc4.9 built on Jul 6 2020, 08:26
kisskb
Revisions
|
Branches
|
Compilers
|
Configs
|
Build Results
|
Build Failures
|
Status:
OK
Date/Time:
Jul 6 2020, 08:26
Duration:
0:04:40.595639
Builder:
blade4b
Revision:
x86/ldt: use "pr_info_once()" instead of open-coding it badly (
bb5a93aaf25261321db0c499cde7da6ee9d8b164)
Target:
linus/multi_v7_defconfig/arm-gcc4.9
Branch:
linus
Compiler:
arm-gcc4.9
(arm-linux-gnueabi-gcc (GCC) 4.9.4 / GNU ld (GNU Binutils) 2.29.1.20170915)
Config:
multi_v7_defconfig
(
download
)
Log:
Download original
Possible warnings (4)
drivers/firmware/qcom_scm-smc.c:94:9: warning: missing braces around initializer [-Wmissing-braces] drivers/firmware/qcom_scm-smc.c:94:9: warning: (near initialization for 'smc.args') [-Wmissing-braces] drivers/firmware/qcom_scm-legacy.c:139:9: warning: missing braces around initializer [-Wmissing-braces] drivers/firmware/qcom_scm-legacy.c:139:9: warning: (near initialization for 'smc.args') [-Wmissing-braces]
Full Log
# git rev-parse -q --verify bb5a93aaf25261321db0c499cde7da6ee9d8b164^{commit} bb5a93aaf25261321db0c499cde7da6ee9d8b164 already have revision, skipping fetch # git checkout -q -f -B kisskb bb5a93aaf25261321db0c499cde7da6ee9d8b164 # git clean -qxdf # < git log -1 # commit bb5a93aaf25261321db0c499cde7da6ee9d8b164 # Author: Linus Torvalds <torvalds@linux-foundation.org> # Date: Sun Jul 5 12:50:20 2020 -0700 # # x86/ldt: use "pr_info_once()" instead of open-coding it badly # # Using a mutex for "print this warning only once" is so overdesigned as # to be actively offensive to my sensitive stomach. # # Just use "pr_info_once()" that already does this, although in a # (harmlessly) racy manner that can in theory cause the message to be # printed twice if more than one CPU races on that "is this the first # time" test. # # [ If somebody really cares about that harmless data race (which sounds # very unlikely indeed), that person can trivially fix printk_once() by # using a simple atomic access, preferably with an optimistic non-atomic # test first before even bothering to treat the pointless "make sure it # is _really_ just once" case. # # A mutex is most definitely never the right primitive to use for # something like this. ] # # Yes, this is a small and meaningless detail in a code path that hardly # matters. But let's keep some code quality standards here, and not # accept outrageously bad code. # # Link: https://lore.kernel.org/lkml/CAHk-=wgV9toS7GU3KmNpj8hCS9SeF+A0voHS8F275_mgLhL4Lw@mail.gmail.com/ # Cc: Andy Lutomirski <luto@kernel.org> # Cc: Thomas Gleixner <tglx@linutronix.de> # Cc: Peter Zijlstra (Intel) <peterz@infradead.org> # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi-ld --version # < git log --format=%s --max-count=1 bb5a93aaf25261321db0c499cde7da6ee9d8b164 # < make -s -j 24 ARCH=arm O=/kisskb/build/linus_multi_v7_defconfig_arm-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi- multi_v7_defconfig # < make -s -j 24 ARCH=arm O=/kisskb/build/linus_multi_v7_defconfig_arm-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi- help # make -s -j 24 ARCH=arm O=/kisskb/build/linus_multi_v7_defconfig_arm-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi- olddefconfig # make -s -j 24 ARCH=arm O=/kisskb/build/linus_multi_v7_defconfig_arm-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi- /kisskb/src/drivers/firmware/qcom_scm-smc.c: In function 'scm_smc_call': /kisskb/src/drivers/firmware/qcom_scm-smc.c:94:9: warning: missing braces around initializer [-Wmissing-braces] struct arm_smccc_args smc = {0}; ^ /kisskb/src/drivers/firmware/qcom_scm-smc.c:94:9: warning: (near initialization for 'smc.args') [-Wmissing-braces] /kisskb/src/drivers/firmware/qcom_scm-legacy.c: In function 'scm_legacy_call': /kisskb/src/drivers/firmware/qcom_scm-legacy.c:139:9: warning: missing braces around initializer [-Wmissing-braces] struct arm_smccc_args smc = {0}; ^ /kisskb/src/drivers/firmware/qcom_scm-legacy.c:139:9: warning: (near initialization for 'smc.args') [-Wmissing-braces] Completed OK # rm -rf /kisskb/build/linus_multi_v7_defconfig_arm-gcc4.9 # Build took: 0:04:40.595639
© Michael Ellerman 2006-2018.