Buildresult: linus/s390-allyesconfig/s390x-gcc4.9 built on Jul 16 2020, 09:52

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Jul 16 2020, 09:52
Duration:	0:31:44.805896
Builder:	ka1
Revision:	Merge tag 'platform-drivers-x86-v5.8-2' of git://git.infradead.org/linux-platform-drivers-x86 into master (`994e99a96c9b502b3f6ee411457007cd52051cf5)`
Target:	linus/s390-allyesconfig/s390x-gcc4.9
Branch:	linus
Compiler:	s390x-gcc4.9 (s390-linux-gcc (GCC) 4.9.4 / GNU ld (GNU Binutils) 2.29.1.20170915)
Config:	allyesconfig (download)
Log:	Download original Possible warnings (96) kernel/dma/debug.c:1341:1: warning: 'debug_dma_unmap_page' uses dynamic stack allocation kernel/dma/debug.c:1535:1: warning: 'debug_dma_unmap_resource' uses dynamic stack allocation kernel/dma/debug.c:1431:1: warning: 'debug_dma_unmap_sg' uses dynamic stack allocation kernel/dma/debug.c:1554:1: warning: 'debug_dma_sync_single_for_cpu' uses dynamic stack allocation kernel/dma/debug.c:1574:1: warning: 'debug_dma_sync_single_for_device' uses dynamic stack allocation kernel/dma/debug.c:1607:1: warning: 'debug_dma_sync_sg_for_cpu' uses dynamic stack allocation kernel/dma/debug.c:1639:1: warning: 'debug_dma_sync_sg_for_device' uses dynamic stack allocation kernel/dma/debug.c:1493:1: warning: 'debug_dma_free_coherent' uses dynamic stack allocation kernel/bpf/syscall.c:1810:1: warning: 'bpf_prog_show_fdinfo' uses dynamic stack allocation kernel/bpf/syscall.c:3498:1: warning: 'bpf_prog_get_info_by_fd.isra.24' uses dynamic stack allocation kernel/events/core.c:8429:1: warning: 'perf_log_throttle' uses dynamic stack allocation kernel/events/core.c:8563:1: warning: 'perf_event_bpf_output' uses dynamic stack allocation kernel/events/core.c:8670:1: warning: 'perf_log_itrace_start' uses dynamic stack allocation kernel/events/core.c:8358:1: warning: 'perf_event_switch_output' uses dynamic stack allocation kernel/events/core.c:7518:1: warning: 'perf_event_task_output' uses dynamic stack allocation kernel/events/core.c:7711:1: warning: 'perf_event_namespaces_output' uses dynamic stack allocation kernel/events/core.c:8474:1: warning: 'perf_event_ksymbol_output' uses dynamic stack allocation kernel/events/core.c:7834:1: warning: 'perf_event_cgroup_output' uses dynamic stack allocation kernel/events/core.c:7612:1: warning: 'perf_event_comm_output' uses dynamic stack allocation kernel/events/core.c:10138:1: warning: 'perf_swevent_hrtimer' uses dynamic stack allocation kernel/events/core.c:7975:1: warning: 'perf_event_mmap_output' uses dynamic stack allocation kernel/events/core.c:7231:1: warning: 'perf_event_read_event' uses dynamic stack allocation arch/s390/kernel/perf_cpum_sf.c:1145:1: warning: 'perf_push_sample' uses dynamic stack allocation kernel/events/core.c:8266:1: warning: 'perf_event_aux_event' uses dynamic stack allocation kernel/events/core.c:8299:1: warning: 'perf_log_lost_samples' uses dynamic stack allocation kernel/events/core.c:9309:1: warning: 'perf_tp_event' uses dynamic stack allocation kernel/events/core.c:8995:1: warning: '___perf_sw_event' uses dynamic stack allocation kernel/events/ring_buffer.c:269:1: warning: 'perf_output_begin_forward' uses dynamic stack allocation kernel/events/ring_buffer.c:275:1: warning: 'perf_output_begin_backward' uses dynamic stack allocation kernel/events/ring_buffer.c:283:1: warning: 'perf_output_begin' uses dynamic stack allocation arch/s390/kernel/perf_cpum_cf_diag.c:519:1: warning: 'cf_diag_push_sample' uses dynamic stack allocation mm/slub.c:2298:1: warning: 'unfreeze_partials.isra.55' uses dynamic stack allocation mm/slub.c:1929:1: warning: 'get_partial_node.isra.56' uses dynamic stack allocation mm/slub.c:3005:1: warning: '__slab_free' uses dynamic stack allocation mm/slub.c:2230:1: warning: 'deactivate_slab.isra.57' uses dynamic stack allocation mm/slub.c:2692:1: warning: '___slab_alloc' uses dynamic stack allocation kernel/smp.c:387:1: warning: 'smp_call_function_single' uses dynamic stack allocation kernel/rseq.c:281:1: warning: '__rseq_handle_notify_resume' uses dynamic stack allocation kernel/rseq.c:300:1: warning: 'rseq_syscall' uses dynamic stack allocation fs/nfs/super.c:687:1: warning: 'nfs_show_stats' uses dynamic stack allocation drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8928:9: warning: missing braces around initializer [-Wmissing-braces] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8928:9: warning: (near initialization for 'params.triggers') [-Wmissing-braces] drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:297:9: warning: missing braces around initializer [-Wmissing-braces] drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:297:9: warning: (near initialization for 'dummy_record.record_header') [-Wmissing-braces] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:2712:8: warning: missing braces around initializer [-Wmissing-braces] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:2712:8: warning: (near initialization for 'dpcd_test_mode.bits') [-Wmissing-braces] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:2714:8: warning: missing braces around initializer [-Wmissing-braces] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:2714:8: warning: (near initialization for 'dpcd_pattern_period[0]') [-Wmissing-braces] drivers/target/iscsi/cxgbit/cxgbit_target.c:498:1: warning: 'cxgbit_tx_datain_iso.isra.39' uses dynamic stack allocation drivers/target/iscsi/iscsi_target.c:2874:1: warning: 'iscsit_send_datain' uses dynamic stack allocation drivers/scsi/dc395x.c:155:36: warning: value computed is not used [-Wunused-value] drivers/scsi/dc395x.c:155:36: warning: value computed is not used [-Wunused-value] drivers/scsi/dc395x.c:155:36: warning: value computed is not used [-Wunused-value] drivers/input/joystick/analog.c:160:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp] #warning Precise timer not defined for this architecture. drivers/net/ethernet/marvell/mvpp2/mvpp2.h:634:2: warning: overflow in implicit constant conversion [-Woverflow] drivers/s390/net/ism_drv.c:357:1: warning: 'ism_signal_ieq' uses dynamic stack allocation drivers/s390/net/ism_drv.c:329:1: warning: 'ism_del_vlan_id' uses dynamic stack allocation drivers/s390/net/ism_drv.c:315:1: warning: 'ism_add_vlan_id' uses dynamic stack allocation drivers/s390/net/ism_drv.c:214:1: warning: 'ism_query_rgid' uses dynamic stack allocation drivers/s390/net/ism_drv.c:301:1: warning: 'ism_unregister_dmb' uses dynamic stack allocation drivers/s390/net/ism_drv.c:280:1: warning: 'ism_register_dmb' uses dynamic stack allocation drivers/s390/net/ism_drv.c:83:1: warning: 'query_info' uses dynamic stack allocation drivers/s390/net/ism_drv.c:546:1: warning: 'ism_probe' uses dynamic stack allocation lib/crypto/chacha20poly1305.c:335:1: warning: 'chacha20poly1305_crypt_sg_inplace' uses dynamic stack allocation drivers/net/ethernet/neterion/vxge/vxge-config.c:1089:1: warning: 'vxge_hw_device_hw_info_get' uses dynamic stack allocation net/bridge/netfilter/ebtables.c:1850:1: warning: 'compat_copy_everything_to_user' uses dynamic stack allocation net/bridge/br_device.c:228:1: warning: 'br_get_stats64' uses dynamic stack allocation drivers/crypto/chelsio/chtls/chtls_cm.c:435:1: warning: 'wait_for_states.constprop' uses dynamic stack allocation lib/test_stackinit.c:255:15: warning: 'leaf_big_hole_static_all' uses dynamic stack allocation lib/test_stackinit.c:255:15: warning: 'test_big_hole_static_all' uses dynamic stack allocation lib/test_stackinit.c:255:15: warning: 'leaf_big_hole_dynamic_all' uses dynamic stack allocation lib/test_stackinit.c:255:15: warning: 'test_big_hole_dynamic_all' uses dynamic stack allocation lib/test_stackinit.c:255:15: warning: 'leaf_big_hole_zero.isra.9' uses dynamic stack allocation lib/test_stackinit.c:255:15: warning: 'test_big_hole_zero' uses dynamic stack allocation lib/test_stackinit.c:255:15: warning: 'leaf_big_hole_static_partial.isra.17' uses dynamic stack allocation lib/test_stackinit.c:255:15: warning: 'test_big_hole_static_partial' uses dynamic stack allocation lib/test_stackinit.c:255:15: warning: 'leaf_big_hole_dynamic_partial.isra.29' uses dynamic stack allocation lib/test_stackinit.c:255:15: warning: 'test_big_hole_dynamic_partial' uses dynamic stack allocation lib/test_stackinit.c:255:15: warning: 'leaf_big_hole_runtime_partial.isra.41' uses dynamic stack allocation lib/test_stackinit.c:255:15: warning: 'test_big_hole_runtime_partial' uses dynamic stack allocation lib/test_stackinit.c:255:15: warning: 'leaf_big_hole_runtime_all.isra.49' uses dynamic stack allocation lib/test_stackinit.c:255:15: warning: 'test_big_hole_runtime_all' uses dynamic stack allocation lib/test_stackinit.c:255:15: warning: 'leaf_big_hole_none.isra.63' uses dynamic stack allocation lib/test_stackinit.c:255:15: warning: 'test_big_hole_none' uses dynamic stack allocation drivers/mailbox/imx-mailbox.c:601:12: warning: 'imx_mu_suspend_noirq' defined but not used [-Wunused-function] drivers/mailbox/imx-mailbox.c:611:12: warning: 'imx_mu_resume_noirq' defined but not used [-Wunused-function] drivers/mailbox/imx-mailbox.c:629:12: warning: 'imx_mu_runtime_suspend' defined but not used [-Wunused-function] drivers/mailbox/imx-mailbox.c:638:12: warning: 'imx_mu_runtime_resume' defined but not used [-Wunused-function] net/smc/smc_llc.c:1164:9: warning: missing braces around initializer [-Wmissing-braces] net/smc/smc_llc.c:1164:9: warning: (near initialization for 'add_llc.hd') [-Wmissing-braces] net/smc/smc_llc.c:1197:9: warning: missing braces around initializer [-Wmissing-braces] net/smc/smc_llc.c:1197:9: warning: (near initialization for 'del_llc.hd') [-Wmissing-braces] net/smc/smc_llc.c:1269:9: warning: missing braces around initializer [-Wmissing-braces] net/smc/smc_llc.c:1269:9: warning: (near initialization for 'delllc.hd') [-Wmissing-braces] arch/s390/boot/mem_detect.c:175:1: warning: 'detect_memory' uses dynamic stack allocation Full Log # git rev-parse -q --verify 994e99a96c9b502b3f6ee411457007cd52051cf5^{commit} 994e99a96c9b502b3f6ee411457007cd52051cf5 already have revision, skipping fetch # git checkout -q -f -B kisskb 994e99a96c9b502b3f6ee411457007cd52051cf5 # git clean -qxdf # < git log -1 # commit 994e99a96c9b502b3f6ee411457007cd52051cf5 # Merge: 0665a4e9a1d6 9a33e375d98e # Author: Linus Torvalds <torvalds@linux-foundation.org> # Date: Wed Jul 15 16:05:19 2020 -0700 # # Merge tag 'platform-drivers-x86-v5.8-2' of git://git.infradead.org/linux-platform-drivers-x86 into master # # Pull x86 platform driver fixes from Andriy Shevchenko: # "Small fixes for this cycle: # # - Fix procfs handling in Thinkpad ACPI driver # # - Fix battery management on new ASUS laptops # # - New IDs (Sapphire Rapids) in ISST tool" # # * tag 'platform-drivers-x86-v5.8-2' of git://git.infradead.org/linux-platform-drivers-x86: # platform/x86: asus-wmi: allow BAT1 battery name # platform/x86: ISST: Add new PCI device ids # platform/x86: thinkpad_acpi: Revert "Use strndup_user() in dispatch_proc_write()" # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/s390-linux/bin/s390-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/s390-linux/bin/s390-linux-ld --version # < git log --format=%s --max-count=1 994e99a96c9b502b3f6ee411457007cd52051cf5 # < make -s -j 8 ARCH=s390 O=/kisskb/build/linus_s390-allyesconfig_s390x-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/s390-linux/bin/s390-linux- allyesconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # < make -s -j 8 ARCH=s390 O=/kisskb/build/linus_s390-allyesconfig_s390x-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/s390-linux/bin/s390-linux- help # make -s -j 8 ARCH=s390 O=/kisskb/build/linus_s390-allyesconfig_s390x-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/s390-linux/bin/s390-linux- olddefconfig # make -s -j 8 ARCH=s390 O=/kisskb/build/linus_s390-allyesconfig_s390x-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/s390-linux/bin/s390-linux- /kisskb/src/kernel/dma/debug.c: In function 'debug_dma_unmap_page': /kisskb/src/kernel/dma/debug.c:1341:1: warning: 'debug_dma_unmap_page' uses dynamic stack allocation } ^ /kisskb/src/kernel/dma/debug.c: In function 'debug_dma_unmap_resource': /kisskb/src/kernel/dma/debug.c:1535:1: warning: 'debug_dma_unmap_resource' uses dynamic stack allocation } ^ /kisskb/src/kernel/dma/debug.c: In function 'debug_dma_unmap_sg': /kisskb/src/kernel/dma/debug.c:1431:1: warning: 'debug_dma_unmap_sg' uses dynamic stack allocation } ^ /kisskb/src/kernel/dma/debug.c: In function 'debug_dma_sync_single_for_cpu': /kisskb/src/kernel/dma/debug.c:1554:1: warning: 'debug_dma_sync_single_for_cpu' uses dynamic stack allocation } ^ /kisskb/src/kernel/dma/debug.c: In function 'debug_dma_sync_single_for_device': /kisskb/src/kernel/dma/debug.c:1574:1: warning: 'debug_dma_sync_single_for_device' uses dynamic stack allocation } ^ /kisskb/src/kernel/dma/debug.c: In function 'debug_dma_sync_sg_for_cpu': /kisskb/src/kernel/dma/debug.c:1607:1: warning: 'debug_dma_sync_sg_for_cpu' uses dynamic stack allocation } ^ /kisskb/src/kernel/dma/debug.c: In function 'debug_dma_sync_sg_for_device': /kisskb/src/kernel/dma/debug.c:1639:1: warning: 'debug_dma_sync_sg_for_device' uses dynamic stack allocation } ^ /kisskb/src/kernel/dma/debug.c: In function 'debug_dma_free_coherent': /kisskb/src/kernel/dma/debug.c:1493:1: warning: 'debug_dma_free_coherent' uses dynamic stack allocation } ^ /kisskb/src/kernel/bpf/syscall.c: In function 'bpf_prog_show_fdinfo': /kisskb/src/kernel/bpf/syscall.c:1810:1: warning: 'bpf_prog_show_fdinfo' uses dynamic stack allocation } ^ /kisskb/src/kernel/bpf/syscall.c: In function 'bpf_prog_get_info_by_fd.isra.24': /kisskb/src/kernel/bpf/syscall.c:3498:1: warning: 'bpf_prog_get_info_by_fd.isra.24' uses dynamic stack allocation } ^ /kisskb/src/kernel/events/core.c: In function 'perf_log_throttle': /kisskb/src/kernel/events/core.c:8429:1: warning: 'perf_log_throttle' uses dynamic stack allocation } ^ /kisskb/src/kernel/events/core.c: In function 'perf_event_bpf_output': /kisskb/src/kernel/events/core.c:8563:1: warning: 'perf_event_bpf_output' uses dynamic stack allocation } ^ /kisskb/src/kernel/events/core.c: In function 'perf_log_itrace_start': /kisskb/src/kernel/events/core.c:8670:1: warning: 'perf_log_itrace_start' uses dynamic stack allocation } ^ /kisskb/src/kernel/events/core.c: In function 'perf_event_switch_output': /kisskb/src/kernel/events/core.c:8358:1: warning: 'perf_event_switch_output' uses dynamic stack allocation } ^ /kisskb/src/kernel/events/core.c: In function 'perf_event_task_output': /kisskb/src/kernel/events/core.c:7518:1: warning: 'perf_event_task_output' uses dynamic stack allocation } ^ /kisskb/src/kernel/events/core.c: In function 'perf_event_namespaces_output': /kisskb/src/kernel/events/core.c:7711:1: warning: 'perf_event_namespaces_output' uses dynamic stack allocation } ^ /kisskb/src/kernel/events/core.c: In function 'perf_event_ksymbol_output': /kisskb/src/kernel/events/core.c:8474:1: warning: 'perf_event_ksymbol_output' uses dynamic stack allocation } ^ /kisskb/src/kernel/events/core.c: In function 'perf_event_cgroup_output': /kisskb/src/kernel/events/core.c:7834:1: warning: 'perf_event_cgroup_output' uses dynamic stack allocation } ^ /kisskb/src/kernel/events/core.c: In function 'perf_event_comm_output': /kisskb/src/kernel/events/core.c:7612:1: warning: 'perf_event_comm_output' uses dynamic stack allocation } ^ /kisskb/src/kernel/events/core.c: In function 'perf_swevent_hrtimer': /kisskb/src/kernel/events/core.c:10138:1: warning: 'perf_swevent_hrtimer' uses dynamic stack allocation } ^ /kisskb/src/kernel/events/core.c: In function 'perf_event_mmap_output': /kisskb/src/kernel/events/core.c:7975:1: warning: 'perf_event_mmap_output' uses dynamic stack allocation } ^ /kisskb/src/kernel/events/core.c: In function 'perf_event_read_event': /kisskb/src/kernel/events/core.c:7231:1: warning: 'perf_event_read_event' uses dynamic stack allocation } ^ /kisskb/src/arch/s390/kernel/perf_cpum_sf.c: In function 'perf_push_sample': /kisskb/src/arch/s390/kernel/perf_cpum_sf.c:1145:1: warning: 'perf_push_sample' uses dynamic stack allocation } ^ /kisskb/src/kernel/events/core.c: In function 'perf_event_aux_event': /kisskb/src/kernel/events/core.c:8266:1: warning: 'perf_event_aux_event' uses dynamic stack allocation } ^ /kisskb/src/kernel/events/core.c: In function 'perf_log_lost_samples': /kisskb/src/kernel/events/core.c:8299:1: warning: 'perf_log_lost_samples' uses dynamic stack allocation } ^ /kisskb/src/kernel/events/core.c: In function 'perf_tp_event': /kisskb/src/kernel/events/core.c:9309:1: warning: 'perf_tp_event' uses dynamic stack allocation } ^ /kisskb/src/kernel/events/core.c: In function '___perf_sw_event': /kisskb/src/kernel/events/core.c:8995:1: warning: '___perf_sw_event' uses dynamic stack allocation } ^ /kisskb/src/kernel/events/ring_buffer.c: In function 'perf_output_begin_forward': /kisskb/src/kernel/events/ring_buffer.c:269:1: warning: 'perf_output_begin_forward' uses dynamic stack allocation } ^ /kisskb/src/kernel/events/ring_buffer.c: In function 'perf_output_begin_backward': /kisskb/src/kernel/events/ring_buffer.c:275:1: warning: 'perf_output_begin_backward' uses dynamic stack allocation } ^ /kisskb/src/kernel/events/ring_buffer.c: In function 'perf_output_begin': /kisskb/src/kernel/events/ring_buffer.c:283:1: warning: 'perf_output_begin' uses dynamic stack allocation } ^ /kisskb/src/arch/s390/kernel/perf_cpum_cf_diag.c: In function 'cf_diag_push_sample': /kisskb/src/arch/s390/kernel/perf_cpum_cf_diag.c:519:1: warning: 'cf_diag_push_sample' uses dynamic stack allocation } ^ /kisskb/src/mm/slub.c: In function 'unfreeze_partials.isra.55': /kisskb/src/mm/slub.c:2298:1: warning: 'unfreeze_partials.isra.55' uses dynamic stack allocation } ^ /kisskb/src/mm/slub.c: In function 'get_partial_node.isra.56': /kisskb/src/mm/slub.c:1929:1: warning: 'get_partial_node.isra.56' uses dynamic stack allocation } ^ /kisskb/src/mm/slub.c: In function '__slab_free': /kisskb/src/mm/slub.c:3005:1: warning: '__slab_free' uses dynamic stack allocation } ^ /kisskb/src/mm/slub.c: In function 'deactivate_slab.isra.57': /kisskb/src/mm/slub.c:2230:1: warning: 'deactivate_slab.isra.57' uses dynamic stack allocation } ^ /kisskb/src/mm/slub.c: In function '___slab_alloc': /kisskb/src/mm/slub.c:2692:1: warning: '___slab_alloc' uses dynamic stack allocation } ^ /kisskb/src/kernel/smp.c: In function 'smp_call_function_single': /kisskb/src/kernel/smp.c:387:1: warning: 'smp_call_function_single' uses dynamic stack allocation } ^ /kisskb/src/kernel/rseq.c: In function '__rseq_handle_notify_resume': /kisskb/src/kernel/rseq.c:281:1: warning: '__rseq_handle_notify_resume' uses dynamic stack allocation } ^ /kisskb/src/kernel/rseq.c: In function 'rseq_syscall': /kisskb/src/kernel/rseq.c:300:1: warning: 'rseq_syscall' uses dynamic stack allocation } ^ /kisskb/src/fs/nfs/super.c: In function 'nfs_show_stats': /kisskb/src/fs/nfs/super.c:687:1: warning: 'nfs_show_stats' uses dynamic stack allocation } ^ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'amdgpu_dm_psr_enable': /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8928:9: warning: missing braces around initializer [-Wmissing-braces] struct dc_static_screen_params params = {0}; ^ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8928:9: warning: (near initialization for 'params.triggers') [-Wmissing-braces] /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c: In function 'bios_parser_get_i2c_info': /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:297:9: warning: missing braces around initializer [-Wmissing-braces] struct atom_i2c_record dummy_record = {0}; ^ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:297:9: warning: (near initialization for 'dummy_record.record_header') [-Wmissing-braces] /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c: In function 'dp_test_get_audio_test_data': /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:2712:8: warning: missing braces around initializer [-Wmissing-braces] union audio_test_mode dpcd_test_mode = {0}; ^ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:2712:8: warning: (near initialization for 'dpcd_test_mode.bits') [-Wmissing-braces] /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:2714:8: warning: missing braces around initializer [-Wmissing-braces] union audio_test_pattern_period dpcd_pattern_period[AUDIO_CHANNELS_COUNT] = {0}; ^ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:2714:8: warning: (near initialization for 'dpcd_pattern_period[0]') [-Wmissing-braces] /kisskb/src/drivers/target/iscsi/cxgbit/cxgbit_target.c: In function 'cxgbit_tx_datain_iso.isra.39': /kisskb/src/drivers/target/iscsi/cxgbit/cxgbit_target.c:498:1: warning: 'cxgbit_tx_datain_iso.isra.39' uses dynamic stack allocation } ^ /kisskb/src/drivers/target/iscsi/iscsi_target.c: In function 'iscsit_send_datain': /kisskb/src/drivers/target/iscsi/iscsi_target.c:2874:1: warning: 'iscsit_send_datain' uses dynamic stack allocation } ^ /kisskb/src/drivers/scsi/dc395x.c: In function '__dc395x_eh_bus_reset': /kisskb/src/drivers/scsi/dc395x.c:155:36: warning: value computed is not used [-Wunused-value] #define DC395x_read8(acb,address) (u8)(inb(acb->io_port_base + (address))) ^ /kisskb/src/drivers/scsi/dc395x.c:1197:2: note: in expansion of macro 'DC395x_read8' DC395x_read8(acb, TRM_S1040_SCSI_INTSTATUS); ^ /kisskb/src/drivers/scsi/dc395x.c: In function 'set_basic_config': /kisskb/src/drivers/scsi/dc395x.c:155:36: warning: value computed is not used [-Wunused-value] #define DC395x_read8(acb,address) (u8)(inb(acb->io_port_base + (address))) ^ /kisskb/src/drivers/scsi/dc395x.c:3489:2: note: in expansion of macro 'DC395x_read8' DC395x_read8(acb, TRM_S1040_SCSI_INTSTATUS); ^ /kisskb/src/drivers/scsi/dc395x.c: In function 'adapter_uninit_chip': /kisskb/src/drivers/scsi/dc395x.c:155:36: warning: value computed is not used [-Wunused-value] #define DC395x_read8(acb,address) (u8)(inb(acb->io_port_base + (address))) ^ /kisskb/src/drivers/scsi/dc395x.c:4435:2: note: in expansion of macro 'DC395x_read8' DC395x_read8(acb, TRM_S1040_SCSI_INTSTATUS); ^ /kisskb/src/drivers/input/joystick/analog.c:160:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp] #warning Precise timer not defined for this architecture. ^ In file included from /kisskb/src/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:40:0: /kisskb/src/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c: In function 'mvpp2_setup_bm_pool': /kisskb/src/drivers/net/ethernet/marvell/mvpp2/mvpp2.h:634:2: warning: overflow in implicit constant conversion [-Woverflow] ((total_size) - NET_SKB_PAD - MVPP2_SKB_SHINFO_SIZE) ^ /kisskb/src/drivers/net/ethernet/marvell/mvpp2/mvpp2.h:699:33: note: in expansion of macro 'MVPP2_RX_MAX_PKT_SIZE' #define MVPP2_BM_SHORT_PKT_SIZE MVPP2_RX_MAX_PKT_SIZE(MVPP2_BM_SHORT_FRAME_SIZE) ^ /kisskb/src/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:580:41: note: in expansion of macro 'MVPP2_BM_SHORT_PKT_SIZE' mvpp2_pools[MVPP2_BM_SHORT].pkt_size = MVPP2_BM_SHORT_PKT_SIZE; ^ /kisskb/src/drivers/s390/net/ism_drv.c: In function 'ism_signal_ieq': /kisskb/src/drivers/s390/net/ism_drv.c:357:1: warning: 'ism_signal_ieq' uses dynamic stack allocation } ^ /kisskb/src/drivers/s390/net/ism_drv.c: In function 'ism_del_vlan_id': /kisskb/src/drivers/s390/net/ism_drv.c:329:1: warning: 'ism_del_vlan_id' uses dynamic stack allocation } ^ /kisskb/src/drivers/s390/net/ism_drv.c: In function 'ism_add_vlan_id': /kisskb/src/drivers/s390/net/ism_drv.c:315:1: warning: 'ism_add_vlan_id' uses dynamic stack allocation } ^ /kisskb/src/drivers/s390/net/ism_drv.c: In function 'ism_query_rgid': /kisskb/src/drivers/s390/net/ism_drv.c:214:1: warning: 'ism_query_rgid' uses dynamic stack allocation } ^ /kisskb/src/drivers/s390/net/ism_drv.c: In function 'ism_unregister_dmb': /kisskb/src/drivers/s390/net/ism_drv.c:301:1: warning: 'ism_unregister_dmb' uses dynamic stack allocation } ^ /kisskb/src/drivers/s390/net/ism_drv.c: In function 'ism_register_dmb': /kisskb/src/drivers/s390/net/ism_drv.c:280:1: warning: 'ism_register_dmb' uses dynamic stack allocation } ^ /kisskb/src/drivers/s390/net/ism_drv.c: In function 'query_info': /kisskb/src/drivers/s390/net/ism_drv.c:83:1: warning: 'query_info' uses dynamic stack allocation } ^ /kisskb/src/drivers/s390/net/ism_drv.c: In function 'ism_probe': /kisskb/src/drivers/s390/net/ism_drv.c:546:1: warning: 'ism_probe' uses dynamic stack allocation } ^ /kisskb/src/lib/crypto/chacha20poly1305.c: In function 'chacha20poly1305_crypt_sg_inplace': /kisskb/src/lib/crypto/chacha20poly1305.c:335:1: warning: 'chacha20poly1305_crypt_sg_inplace' uses dynamic stack allocation } ^ /kisskb/src/drivers/net/ethernet/neterion/vxge/vxge-config.c: In function 'vxge_hw_device_hw_info_get': /kisskb/src/drivers/net/ethernet/neterion/vxge/vxge-config.c:1089:1: warning: 'vxge_hw_device_hw_info_get' uses dynamic stack allocation } ^ /kisskb/src/net/bridge/netfilter/ebtables.c: In function 'compat_copy_everything_to_user': /kisskb/src/net/bridge/netfilter/ebtables.c:1850:1: warning: 'compat_copy_everything_to_user' uses dynamic stack allocation } ^ /kisskb/src/net/bridge/br_device.c: In function 'br_get_stats64': /kisskb/src/net/bridge/br_device.c:228:1: warning: 'br_get_stats64' uses dynamic stack allocation } ^ /kisskb/src/drivers/crypto/chelsio/chtls/chtls_cm.c: In function 'wait_for_states.constprop': /kisskb/src/drivers/crypto/chelsio/chtls/chtls_cm.c:435:1: warning: 'wait_for_states.constprop' uses dynamic stack allocation } ^ /kisskb/src/lib/test_stackinit.c: In function 'leaf_big_hole_static_all': /kisskb/src/lib/test_stackinit.c:255:15: warning: 'leaf_big_hole_static_all' uses dynamic stack allocation struct test_ ## name, STRUCT, init) ^ /kisskb/src/lib/test_stackinit.c:168:2: note: in definition of macro 'DEFINE_TEST' var_type var INIT_ ## which ## _ ## init_level; \ ^ /kisskb/src/lib/test_stackinit.c:259:3: note: in expansion of macro 'DEFINE_STRUCT_TEST' DEFINE_STRUCT_TEST(big_hole, init); \ ^ /kisskb/src/lib/test_stackinit.c:268:1: note: in expansion of macro 'DEFINE_STRUCT_TESTS' DEFINE_STRUCT_TESTS(static_all); ^ /kisskb/src/lib/test_stackinit.c: In function 'test_big_hole_static_all': /kisskb/src/lib/test_stackinit.c:255:15: warning: 'test_big_hole_static_all' uses dynamic stack allocation struct test_ ## name, STRUCT, init) ^ /kisskb/src/lib/test_stackinit.c:101:2: note: in definition of macro 'DEFINE_TEST_DRIVER' var_type zero INIT_CLONE_ ## which; \ ^ /kisskb/src/lib/test_stackinit.c:254:3: note: in expansion of macro 'DEFINE_TEST' DEFINE_TEST(name ## _ ## init, \ ^ /kisskb/src/lib/test_stackinit.c:259:3: note: in expansion of macro 'DEFINE_STRUCT_TEST' DEFINE_STRUCT_TEST(big_hole, init); \ ^ /kisskb/src/lib/test_stackinit.c:268:1: note: in expansion of macro 'DEFINE_STRUCT_TESTS' DEFINE_STRUCT_TESTS(static_all); ^ /kisskb/src/lib/test_stackinit.c: In function 'leaf_big_hole_dynamic_all': /kisskb/src/lib/test_stackinit.c:255:15: warning: 'leaf_big_hole_dynamic_all' uses dynamic stack allocation struct test_ ## name, STRUCT, init) ^ /kisskb/src/lib/test_stackinit.c:168:2: note: in definition of macro 'DEFINE_TEST' var_type var INIT_ ## which ## _ ## init_level; \ ^ /kisskb/src/lib/test_stackinit.c:259:3: note: in expansion of macro 'DEFINE_STRUCT_TEST' DEFINE_STRUCT_TEST(big_hole, init); \ ^ /kisskb/src/lib/test_stackinit.c:271:1: note: in expansion of macro 'DEFINE_STRUCT_TESTS' DEFINE_STRUCT_TESTS(dynamic_all); ^ /kisskb/src/lib/test_stackinit.c: In function 'test_big_hole_dynamic_all': /kisskb/src/lib/test_stackinit.c:255:15: warning: 'test_big_hole_dynamic_all' uses dynamic stack allocation struct test_ ## name, STRUCT, init) ^ /kisskb/src/lib/test_stackinit.c:101:2: note: in definition of macro 'DEFINE_TEST_DRIVER' var_type zero INIT_CLONE_ ## which; \ ^ /kisskb/src/lib/test_stackinit.c:254:3: note: in expansion of macro 'DEFINE_TEST' DEFINE_TEST(name ## _ ## init, \ ^ /kisskb/src/lib/test_stackinit.c:259:3: note: in expansion of macro 'DEFINE_STRUCT_TEST' DEFINE_STRUCT_TEST(big_hole, init); \ ^ /kisskb/src/lib/test_stackinit.c:271:1: note: in expansion of macro 'DEFINE_STRUCT_TESTS' DEFINE_STRUCT_TESTS(dynamic_all); ^ /kisskb/src/lib/test_stackinit.c: In function 'leaf_big_hole_zero.isra.9': /kisskb/src/lib/test_stackinit.c:255:15: warning: 'leaf_big_hole_zero.isra.9' uses dynamic stack allocation struct test_ ## name, STRUCT, init) ^ /kisskb/src/lib/test_stackinit.c:168:2: note: in definition of macro 'DEFINE_TEST' var_type var INIT_ ## which ## _ ## init_level; \ ^ /kisskb/src/lib/test_stackinit.c:259:3: note: in expansion of macro 'DEFINE_STRUCT_TEST' DEFINE_STRUCT_TEST(big_hole, init); \ ^ /kisskb/src/lib/test_stackinit.c:265:1: note: in expansion of macro 'DEFINE_STRUCT_TESTS' DEFINE_STRUCT_TESTS(zero); ^ /kisskb/src/lib/test_stackinit.c: In function 'test_big_hole_zero': /kisskb/src/lib/test_stackinit.c:255:15: warning: 'test_big_hole_zero' uses dynamic stack allocation struct test_ ## name, STRUCT, init) ^ /kisskb/src/lib/test_stackinit.c:101:2: note: in definition of macro 'DEFINE_TEST_DRIVER' var_type zero INIT_CLONE_ ## which; \ ^ /kisskb/src/lib/test_stackinit.c:254:3: note: in expansion of macro 'DEFINE_TEST' DEFINE_TEST(name ## _ ## init, \ ^ /kisskb/src/lib/test_stackinit.c:259:3: note: in expansion of macro 'DEFINE_STRUCT_TEST' DEFINE_STRUCT_TEST(big_hole, init); \ ^ /kisskb/src/lib/test_stackinit.c:265:1: note: in expansion of macro 'DEFINE_STRUCT_TESTS' DEFINE_STRUCT_TESTS(zero); ^ /kisskb/src/lib/test_stackinit.c: In function 'leaf_big_hole_static_partial.isra.17': /kisskb/src/lib/test_stackinit.c:255:15: warning: 'leaf_big_hole_static_partial.isra.17' uses dynamic stack allocation struct test_ ## name, STRUCT, init) ^ /kisskb/src/lib/test_stackinit.c:168:2: note: in definition of macro 'DEFINE_TEST' var_type var INIT_ ## which ## _ ## init_level; \ ^ /kisskb/src/lib/test_stackinit.c:259:3: note: in expansion of macro 'DEFINE_STRUCT_TEST' DEFINE_STRUCT_TEST(big_hole, init); \ ^ /kisskb/src/lib/test_stackinit.c:267:1: note: in expansion of macro 'DEFINE_STRUCT_TESTS' DEFINE_STRUCT_TESTS(static_partial); ^ /kisskb/src/lib/test_stackinit.c: In function 'test_big_hole_static_partial': /kisskb/src/lib/test_stackinit.c:255:15: warning: 'test_big_hole_static_partial' uses dynamic stack allocation struct test_ ## name, STRUCT, init) ^ /kisskb/src/lib/test_stackinit.c:101:2: note: in definition of macro 'DEFINE_TEST_DRIVER' var_type zero INIT_CLONE_ ## which; \ ^ /kisskb/src/lib/test_stackinit.c:254:3: note: in expansion of macro 'DEFINE_TEST' DEFINE_TEST(name ## _ ## init, \ ^ /kisskb/src/lib/test_stackinit.c:259:3: note: in expansion of macro 'DEFINE_STRUCT_TEST' DEFINE_STRUCT_TEST(big_hole, init); \ ^ /kisskb/src/lib/test_stackinit.c:267:1: note: in expansion of macro 'DEFINE_STRUCT_TESTS' DEFINE_STRUCT_TESTS(static_partial); ^ /kisskb/src/lib/test_stackinit.c: In function 'leaf_big_hole_dynamic_partial.isra.29': /kisskb/src/lib/test_stackinit.c:255:15: warning: 'leaf_big_hole_dynamic_partial.isra.29' uses dynamic stack allocation struct test_ ## name, STRUCT, init) ^ /kisskb/src/lib/test_stackinit.c:168:2: note: in definition of macro 'DEFINE_TEST' var_type var INIT_ ## which ## _ ## init_level; \ ^ /kisskb/src/lib/test_stackinit.c:259:3: note: in expansion of macro 'DEFINE_STRUCT_TEST' DEFINE_STRUCT_TEST(big_hole, init); \ ^ /kisskb/src/lib/test_stackinit.c:270:1: note: in expansion of macro 'DEFINE_STRUCT_TESTS' DEFINE_STRUCT_TESTS(dynamic_partial); ^ /kisskb/src/lib/test_stackinit.c: In function 'test_big_hole_dynamic_partial': /kisskb/src/lib/test_stackinit.c:255:15: warning: 'test_big_hole_dynamic_partial' uses dynamic stack allocation struct test_ ## name, STRUCT, init) ^ /kisskb/src/lib/test_stackinit.c:101:2: note: in definition of macro 'DEFINE_TEST_DRIVER' var_type zero INIT_CLONE_ ## which; \ ^ /kisskb/src/lib/test_stackinit.c:254:3: note: in expansion of macro 'DEFINE_TEST' DEFINE_TEST(name ## _ ## init, \ ^ /kisskb/src/lib/test_stackinit.c:259:3: note: in expansion of macro 'DEFINE_STRUCT_TEST' DEFINE_STRUCT_TEST(big_hole, init); \ ^ /kisskb/src/lib/test_stackinit.c:270:1: note: in expansion of macro 'DEFINE_STRUCT_TESTS' DEFINE_STRUCT_TESTS(dynamic_partial); ^ /kisskb/src/lib/test_stackinit.c: In function 'leaf_big_hole_runtime_partial.isra.41': /kisskb/src/lib/test_stackinit.c:255:15: warning: 'leaf_big_hole_runtime_partial.isra.41' uses dynamic stack allocation struct test_ ## name, STRUCT, init) ^ /kisskb/src/lib/test_stackinit.c:168:2: note: in definition of macro 'DEFINE_TEST' var_type var INIT_ ## which ## _ ## init_level; \ ^ /kisskb/src/lib/test_stackinit.c:259:3: note: in expansion of macro 'DEFINE_STRUCT_TEST' DEFINE_STRUCT_TEST(big_hole, init); \ ^ /kisskb/src/lib/test_stackinit.c:273:1: note: in expansion of macro 'DEFINE_STRUCT_TESTS' DEFINE_STRUCT_TESTS(runtime_partial); ^ /kisskb/src/lib/test_stackinit.c: In function 'test_big_hole_runtime_partial': /kisskb/src/lib/test_stackinit.c:255:15: warning: 'test_big_hole_runtime_partial' uses dynamic stack allocation struct test_ ## name, STRUCT, init) ^ /kisskb/src/lib/test_stackinit.c:101:2: note: in definition of macro 'DEFINE_TEST_DRIVER' var_type zero INIT_CLONE_ ## which; \ ^ /kisskb/src/lib/test_stackinit.c:254:3: note: in expansion of macro 'DEFINE_TEST' DEFINE_TEST(name ## _ ## init, \ ^ /kisskb/src/lib/test_stackinit.c:259:3: note: in expansion of macro 'DEFINE_STRUCT_TEST' DEFINE_STRUCT_TEST(big_hole, init); \ ^ /kisskb/src/lib/test_stackinit.c:273:1: note: in expansion of macro 'DEFINE_STRUCT_TESTS' DEFINE_STRUCT_TESTS(runtime_partial); ^ /kisskb/src/lib/test_stackinit.c: In function 'leaf_big_hole_runtime_all.isra.49': /kisskb/src/lib/test_stackinit.c:255:15: warning: 'leaf_big_hole_runtime_all.isra.49' uses dynamic stack allocation struct test_ ## name, STRUCT, init) ^ /kisskb/src/lib/test_stackinit.c:168:2: note: in definition of macro 'DEFINE_TEST' var_type var INIT_ ## which ## _ ## init_level; \ ^ /kisskb/src/lib/test_stackinit.c:259:3: note: in expansion of macro 'DEFINE_STRUCT_TEST' DEFINE_STRUCT_TEST(big_hole, init); \ ^ /kisskb/src/lib/test_stackinit.c:274:1: note: in expansion of macro 'DEFINE_STRUCT_TESTS' DEFINE_STRUCT_TESTS(runtime_all); ^ /kisskb/src/lib/test_stackinit.c: In function 'test_big_hole_runtime_all': /kisskb/src/lib/test_stackinit.c:255:15: warning: 'test_big_hole_runtime_all' uses dynamic stack allocation struct test_ ## name, STRUCT, init) ^ /kisskb/src/lib/test_stackinit.c:101:2: note: in definition of macro 'DEFINE_TEST_DRIVER' var_type zero INIT_CLONE_ ## which; \ ^ /kisskb/src/lib/test_stackinit.c:254:3: note: in expansion of macro 'DEFINE_TEST' DEFINE_TEST(name ## _ ## init, \ ^ /kisskb/src/lib/test_stackinit.c:259:3: note: in expansion of macro 'DEFINE_STRUCT_TEST' DEFINE_STRUCT_TEST(big_hole, init); \ ^ /kisskb/src/lib/test_stackinit.c:274:1: note: in expansion of macro 'DEFINE_STRUCT_TESTS' DEFINE_STRUCT_TESTS(runtime_all); ^ /kisskb/src/lib/test_stackinit.c: In function 'leaf_big_hole_none.isra.63': /kisskb/src/lib/test_stackinit.c:255:15: warning: 'leaf_big_hole_none.isra.63' uses dynamic stack allocation struct test_ ## name, STRUCT, init) ^ /kisskb/src/lib/test_stackinit.c:168:2: note: in definition of macro 'DEFINE_TEST' var_type var INIT_ ## which ## _ ## init_level; \ ^ /kisskb/src/lib/test_stackinit.c:259:3: note: in expansion of macro 'DEFINE_STRUCT_TEST' DEFINE_STRUCT_TEST(big_hole, init); \ ^ /kisskb/src/lib/test_stackinit.c:277:1: note: in expansion of macro 'DEFINE_STRUCT_TESTS' DEFINE_STRUCT_TESTS(none); ^ /kisskb/src/lib/test_stackinit.c: In function 'test_big_hole_none': /kisskb/src/lib/test_stackinit.c:255:15: warning: 'test_big_hole_none' uses dynamic stack allocation struct test_ ## name, STRUCT, init) ^ /kisskb/src/lib/test_stackinit.c:101:2: note: in definition of macro 'DEFINE_TEST_DRIVER' var_type zero INIT_CLONE_ ## which; \ ^ /kisskb/src/lib/test_stackinit.c:254:3: note: in expansion of macro 'DEFINE_TEST' DEFINE_TEST(name ## _ ## init, \ ^ /kisskb/src/lib/test_stackinit.c:259:3: note: in expansion of macro 'DEFINE_STRUCT_TEST' DEFINE_STRUCT_TEST(big_hole, init); \ ^ /kisskb/src/lib/test_stackinit.c:277:1: note: in expansion of macro 'DEFINE_STRUCT_TESTS' DEFINE_STRUCT_TESTS(none); ^ /kisskb/src/drivers/mailbox/imx-mailbox.c:601:12: warning: 'imx_mu_suspend_noirq' defined but not used [-Wunused-function] static int imx_mu_suspend_noirq(struct device dev) ^ /kisskb/src/drivers/mailbox/imx-mailbox.c:611:12: warning: 'imx_mu_resume_noirq' defined but not used [-Wunused-function] static int imx_mu_resume_noirq(struct device dev) ^ /kisskb/src/drivers/mailbox/imx-mailbox.c:629:12: warning: 'imx_mu_runtime_suspend' defined but not used [-Wunused-function] static int imx_mu_runtime_suspend(struct device dev) ^ /kisskb/src/drivers/mailbox/imx-mailbox.c:638:12: warning: 'imx_mu_runtime_resume' defined but not used [-Wunused-function] static int imx_mu_runtime_resume(struct device dev) ^ /kisskb/src/net/smc/smc_llc.c: In function 'smc_llc_srv_add_link_local': /kisskb/src/net/smc/smc_llc.c:1164:9: warning: missing braces around initializer [-Wmissing-braces] struct smc_llc_msg_add_link add_llc = {0}; ^ /kisskb/src/net/smc/smc_llc.c:1164:9: warning: (near initialization for 'add_llc.hd') [-Wmissing-braces] /kisskb/src/net/smc/smc_llc.c: In function 'smc_llc_srv_delete_link_local': /kisskb/src/net/smc/smc_llc.c:1197:9: warning: missing braces around initializer [-Wmissing-braces] struct smc_llc_msg_del_link del_llc = {0}; ^ /kisskb/src/net/smc/smc_llc.c:1197:9: warning: (near initialization for 'del_llc.hd') [-Wmissing-braces] /kisskb/src/net/smc/smc_llc.c: In function 'smc_llc_send_link_delete_all': /kisskb/src/net/smc/smc_llc.c:1269:9: warning: missing braces around initializer [-Wmissing-braces] struct smc_llc_msg_del_link delllc = {0}; ^ /kisskb/src/net/smc/smc_llc.c:1269:9: warning: (near initialization for 'delllc.hd') [-Wmissing-braces] /kisskb/src/arch/s390/boot/mem_detect.c: In function 'detect_memory': /kisskb/src/arch/s390/boot/mem_detect.c:175:1: warning: 'detect_memory' uses dynamic stack allocation } ^ Completed OK # rm -rf /kisskb/build/linus_s390-allyesconfig_s390x-gcc4.9 # Build took: 0:31:44.805896

© Michael Ellerman 2006-2018.