Buildresult: linus/s390-defconfig/s390x-gcc4.9 built on Jul 31 2020, 02:47

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Jul 31 2020, 02:47
Duration:	0:04:01.188638
Builder:	ka1
Revision:	random: fix circular include dependency on arm64 after addition of percpu.h (`1c9df907da83812e4f33b59d3d142c864d9da57f)`
Target:	linus/s390-defconfig/s390x-gcc4.9
Branch:	linus
Compiler:	s390x-gcc4.9 (s390-linux-gcc (GCC) 4.9.4 / GNU ld (GNU Binutils) 2.29.1.20170915)
Config:	defconfig (download)
Log:	Download original Possible warnings (6) net/smc/smc_llc.c:1199:9: warning: missing braces around initializer [-Wmissing-braces] net/smc/smc_llc.c:1199:9: warning: (near initialization for 'add_llc.hd') [-Wmissing-braces] net/smc/smc_llc.c:1232:9: warning: missing braces around initializer [-Wmissing-braces] net/smc/smc_llc.c:1232:9: warning: (near initialization for 'del_llc.hd') [-Wmissing-braces] net/smc/smc_llc.c:1304:9: warning: missing braces around initializer [-Wmissing-braces] net/smc/smc_llc.c:1304:9: warning: (near initialization for 'delllc.hd') [-Wmissing-braces] Full Log # git rev-parse -q --verify 1c9df907da83812e4f33b59d3d142c864d9da57f^{commit} 1c9df907da83812e4f33b59d3d142c864d9da57f already have revision, skipping fetch # git checkout -q -f -B kisskb 1c9df907da83812e4f33b59d3d142c864d9da57f # git clean -qxdf # < git log -1 # commit 1c9df907da83812e4f33b59d3d142c864d9da57f # Author: Willy Tarreau <w@1wt.eu> # Date: Thu Jul 30 07:59:24 2020 +0200 # # random: fix circular include dependency on arm64 after addition of percpu.h # # Daniel Díaz and Kees Cook independently reported that commit # f227e3ec3b5c ("random32: update the net random state on interrupt and # activity") broke arm64 due to a circular dependency on include files # since the addition of percpu.h in random.h. # # The correct fix would definitely be to move all the prandom32 stuff out # of random.h but for backporting, a smaller solution is preferred. # # This one replaces linux/percpu.h with asm/percpu.h, and this fixes the # problem on x86_64, arm64, arm, and mips. Note that moving percpu.h # around didn't change anything and that removing it entirely broke # differently. When backporting, such options might still be considered # if this patch fails to help. # # [ It turns out that an alternate fix seems to be to just remove the # troublesome <asm/pointer_auth.h> remove from the arm64 <asm/smp.h> # that causes the circular dependency. # # But we might as well do the whole belt-and-suspenders thing, and # minimize inclusion in <linux/random.h> too. Either will fix the # problem, and both are good changes. - Linus ] # # Reported-by: Daniel Díaz <daniel.diaz@linaro.org> # Reported-by: Kees Cook <keescook@chromium.org> # Tested-by: Marc Zyngier <maz@kernel.org> # Fixes: f227e3ec3b5c # Cc: Stephen Rothwell <sfr@canb.auug.org.au> # Signed-off-by: Willy Tarreau <w@1wt.eu> # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/s390-linux/bin/s390-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/s390-linux/bin/s390-linux-ld --version # < git log --format=%s --max-count=1 1c9df907da83812e4f33b59d3d142c864d9da57f # < make -s -j 48 ARCH=s390 O=/kisskb/build/linus_s390-defconfig_s390x-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/s390-linux/bin/s390-linux- defconfig # < make -s -j 48 ARCH=s390 O=/kisskb/build/linus_s390-defconfig_s390x-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/s390-linux/bin/s390-linux- help # make -s -j 48 ARCH=s390 O=/kisskb/build/linus_s390-defconfig_s390x-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/s390-linux/bin/s390-linux- olddefconfig # make -s -j 48 ARCH=s390 O=/kisskb/build/linus_s390-defconfig_s390x-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/s390-linux/bin/s390-linux- /kisskb/src/net/smc/smc_llc.c: In function 'smc_llc_add_link_local': /kisskb/src/net/smc/smc_llc.c:1199:9: warning: missing braces around initializer [-Wmissing-braces] struct smc_llc_msg_add_link add_llc = {0}; ^ /kisskb/src/net/smc/smc_llc.c:1199:9: warning: (near initialization for 'add_llc.hd') [-Wmissing-braces] /kisskb/src/net/smc/smc_llc.c: In function 'smc_llc_srv_delete_link_local': /kisskb/src/net/smc/smc_llc.c:1232:9: warning: missing braces around initializer [-Wmissing-braces] struct smc_llc_msg_del_link del_llc = {0}; ^ /kisskb/src/net/smc/smc_llc.c:1232:9: warning: (near initialization for 'del_llc.hd') [-Wmissing-braces] /kisskb/src/net/smc/smc_llc.c: In function 'smc_llc_send_link_delete_all': /kisskb/src/net/smc/smc_llc.c:1304:9: warning: missing braces around initializer [-Wmissing-braces] struct smc_llc_msg_del_link delllc = {0}; ^ /kisskb/src/net/smc/smc_llc.c:1304:9: warning: (near initialization for 'delllc.hd') [-Wmissing-braces] Completed OK # rm -rf /kisskb/build/linus_s390-defconfig_s390x-gcc4.9 # Build took: 0:04:01.188638

© Michael Ellerman 2006-2018.