Buildresult: linus/arm64-allnoconfig/arm64-gcc5 built on Jul 31 2020, 04:10

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Jul 31 2020, 04:10
Duration:	0:00:23.860527
Builder:	ka1
Revision:	random: fix circular include dependency on arm64 after addition of percpu.h (`1c9df907da83812e4f33b59d3d142c864d9da57f)`
Target:	linus/arm64-allnoconfig/arm64-gcc5
Branch:	linus
Compiler:	arm64-gcc5 (aarch64-linux-gcc.br_real (Buildroot 2016.11-git-00613-ge98b4dd) 5.4.0 / GNU ld (GNU Binutils) 2.25.1)
Config:	allnoconfig (download)
Log:	Download original No warnings found in log. Full Log # git rev-parse -q --verify 1c9df907da83812e4f33b59d3d142c864d9da57f^{commit} 1c9df907da83812e4f33b59d3d142c864d9da57f already have revision, skipping fetch # git checkout -q -f -B kisskb 1c9df907da83812e4f33b59d3d142c864d9da57f # git clean -qxdf # < git log -1 # commit 1c9df907da83812e4f33b59d3d142c864d9da57f # Author: Willy Tarreau <w@1wt.eu> # Date: Thu Jul 30 07:59:24 2020 +0200 # # random: fix circular include dependency on arm64 after addition of percpu.h # # Daniel Díaz and Kees Cook independently reported that commit # f227e3ec3b5c ("random32: update the net random state on interrupt and # activity") broke arm64 due to a circular dependency on include files # since the addition of percpu.h in random.h. # # The correct fix would definitely be to move all the prandom32 stuff out # of random.h but for backporting, a smaller solution is preferred. # # This one replaces linux/percpu.h with asm/percpu.h, and this fixes the # problem on x86_64, arm64, arm, and mips. Note that moving percpu.h # around didn't change anything and that removing it entirely broke # differently. When backporting, such options might still be considered # if this patch fails to help. # # [ It turns out that an alternate fix seems to be to just remove the # troublesome <asm/pointer_auth.h> remove from the arm64 <asm/smp.h> # that causes the circular dependency. # # But we might as well do the whole belt-and-suspenders thing, and # minimize inclusion in <linux/random.h> too. Either will fix the # problem, and both are good changes. - Linus ] # # Reported-by: Daniel Díaz <daniel.diaz@linaro.org> # Reported-by: Kees Cook <keescook@chromium.org> # Tested-by: Marc Zyngier <maz@kernel.org> # Fixes: f227e3ec3b5c # Cc: Stephen Rothwell <sfr@canb.auug.org.au> # Signed-off-by: Willy Tarreau <w@1wt.eu> # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux-gcc --version # < /opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux-ld --version # < git log --format=%s --max-count=1 1c9df907da83812e4f33b59d3d142c864d9da57f # < make -s -j 48 ARCH=arm64 O=/kisskb/build/linus_arm64-allnoconfig_arm64-gcc5.4 CROSS_COMPILE=/opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux- allnoconfig # < make -s -j 48 ARCH=arm64 O=/kisskb/build/linus_arm64-allnoconfig_arm64-gcc5.4 CROSS_COMPILE=/opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux- help # make -s -j 48 ARCH=arm64 O=/kisskb/build/linus_arm64-allnoconfig_arm64-gcc5.4 CROSS_COMPILE=/opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux- olddefconfig # make -s -j 48 ARCH=arm64 O=/kisskb/build/linus_arm64-allnoconfig_arm64-gcc5.4 CROSS_COMPILE=/opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux- Completed OK # rm -rf /kisskb/build/linus_arm64-allnoconfig_arm64-gcc5.4 # Build took: 0:00:23.860527

© Michael Ellerman 2006-2018.