# git rev-parse -q --verify c0842fbc1b18c7a044e6ff3e8fa78bfa822c7d1a^{commit} c0842fbc1b18c7a044e6ff3e8fa78bfa822c7d1a already have revision, skipping fetch # git checkout -q -f -B kisskb c0842fbc1b18c7a044e6ff3e8fa78bfa822c7d1a # git clean -qxdf # < git log -1 # commit c0842fbc1b18c7a044e6ff3e8fa78bfa822c7d1a # Author: Linus Torvalds # Date: Fri Jul 31 07:51:14 2020 +0200 # # random32: move the pseudo-random 32-bit definitions to prandom.h # # The addition of percpu.h to the list of includes in random.h revealed # some circular dependencies on arm64 and possibly other platforms. This # include was added solely for the pseudo-random definitions, which have # nothing to do with the rest of the definitions in this file but are # still there for legacy reasons. # # This patch moves the pseudo-random parts to linux/prandom.h and the # percpu.h include with it, which is now guarded by _LINUX_PRANDOM_H and # protected against recursive inclusion. # # A further cleanup step would be to remove this from # entirely, and make people who use the prandom infrastructure include # just the new header file. That's a bit of a churn patch, but grepping # for "prandom_" and "next_pseudo_random32" "struct rnd_state" should # catch most users. # # But it turns out that that nice cleanup step is fairly painful, because # a _lot_ of code currently seems to depend on the implicit include of # , which can currently come in a lot of ways, including # such fairly core headfers as . # # So the "nice cleanup" part may or may never happen. # # Fixes: 1c9df907da83 ("random: fix circular include dependency on arm64 after addition of percpu.h") # Tested-by: Guenter Roeck # Acked-by: Willy Tarreau # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux-ld --version # < git log --format=%s --max-count=1 c0842fbc1b18c7a044e6ff3e8fa78bfa822c7d1a # < make -s -j 48 ARCH=ia64 O=/kisskb/build/linus_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux- defconfig # < make -s -j 48 ARCH=ia64 O=/kisskb/build/linus_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux- help # make -s -j 48 ARCH=ia64 O=/kisskb/build/linus_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux- olddefconfig # make -s -j 48 ARCH=ia64 O=/kisskb/build/linus_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux- :1511:2: warning: #warning syscall clone3 not implemented [-Wcpp] In file included from /kisskb/src/arch/ia64/include/uapi/asm/intrinsics.h:22:0, from /kisskb/src/arch/ia64/include/asm/intrinsics.h:11, from /kisskb/src/arch/ia64/include/asm/bitops.h:19, from /kisskb/src/include/linux/bitops.h:29, from /kisskb/src/include/linux/kernel.h:12, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/preempt.h:11, from /kisskb/src/include/linux/spinlock.h:51, from /kisskb/src/include/linux/seqlock.h:15, from /kisskb/src/include/linux/time.h:6, from /kisskb/src/fs/nfs/read.c:11: /kisskb/src/fs/nfs/read.c: In function 'nfs_read_completion': /kisskb/src/arch/ia64/include/uapi/asm/cmpxchg.h:57:2: warning: value computed is not used [-Wunused-value] ((__typeof__(*(ptr))) __xchg((unsigned long) (x), (ptr), sizeof(*(ptr)))) ^ /kisskb/src/fs/nfs/read.c:196:5: note: in expansion of macro 'xchg' xchg(&nfs_req_openctx(req)->error, error); ^ /kisskb/src/fs/nfs/read.c: In function 'nfs_readpage': /kisskb/src/arch/ia64/include/uapi/asm/cmpxchg.h:57:2: warning: value computed is not used [-Wunused-value] ((__typeof__(*(ptr))) __xchg((unsigned long) (x), (ptr), sizeof(*(ptr)))) ^ /kisskb/src/fs/nfs/read.c:355:2: note: in expansion of macro 'xchg' xchg(&ctx->error, 0); ^ No errors detected in 22331 functions. Completed OK # rm -rf /kisskb/build/linus_ia64-defconfig_ia64-gcc4.9 # Build took: 0:02:17.497111