# git rev-parse -q --verify c0842fbc1b18c7a044e6ff3e8fa78bfa822c7d1a^{commit} c0842fbc1b18c7a044e6ff3e8fa78bfa822c7d1a already have revision, skipping fetch # git checkout -q -f -B kisskb c0842fbc1b18c7a044e6ff3e8fa78bfa822c7d1a # git clean -qxdf # < git log -1 # commit c0842fbc1b18c7a044e6ff3e8fa78bfa822c7d1a # Author: Linus Torvalds # Date: Fri Jul 31 07:51:14 2020 +0200 # # random32: move the pseudo-random 32-bit definitions to prandom.h # # The addition of percpu.h to the list of includes in random.h revealed # some circular dependencies on arm64 and possibly other platforms. This # include was added solely for the pseudo-random definitions, which have # nothing to do with the rest of the definitions in this file but are # still there for legacy reasons. # # This patch moves the pseudo-random parts to linux/prandom.h and the # percpu.h include with it, which is now guarded by _LINUX_PRANDOM_H and # protected against recursive inclusion. # # A further cleanup step would be to remove this from # entirely, and make people who use the prandom infrastructure include # just the new header file. That's a bit of a churn patch, but grepping # for "prandom_" and "next_pseudo_random32" "struct rnd_state" should # catch most users. # # But it turns out that that nice cleanup step is fairly painful, because # a _lot_ of code currently seems to depend on the implicit include of # , which can currently come in a lot of ways, including # such fairly core headfers as . # # So the "nice cleanup" part may or may never happen. # # Fixes: 1c9df907da83 ("random: fix circular include dependency on arm64 after addition of percpu.h") # Tested-by: Guenter Roeck # Acked-by: Willy Tarreau # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux-ld --version # < git log --format=%s --max-count=1 c0842fbc1b18c7a044e6ff3e8fa78bfa822c7d1a # < make -s -j 48 ARCH=m68k O=/kisskb/build/linus_m5272c3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- m5272c3_defconfig # < make -s -j 48 ARCH=m68k O=/kisskb/build/linus_m5272c3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- help # make -s -j 48 ARCH=m68k O=/kisskb/build/linus_m5272c3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- olddefconfig # make -s -j 48 ARCH=m68k O=/kisskb/build/linus_m5272c3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- In file included from /kisskb/src/arch/m68k/include/asm/atomic.h:7, from /kisskb/src/include/linux/atomic.h:7, from /kisskb/src/include/linux/spinlock.h:461, from /kisskb/src/include/linux/seqlock.h:15, from /kisskb/src/include/linux/time.h:6, from /kisskb/src/include/linux/stat.h:19, from /kisskb/src/include/linux/module.h:13, from /kisskb/src/net/core/filter.c:20: /kisskb/src/net/core/filter.c: In function 'bpf_clear_redirect_map': /kisskb/src/arch/m68k/include/asm/cmpxchg.h:137:3: warning: value computed is not used [-Wunused-value] ((__typeof__(*(ptr)))__cmpxchg_local_generic((ptr), (unsigned long)(o),\ ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (unsigned long)(n), sizeof(*(ptr)))) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/include/asm-generic/cmpxchg.h:106:28: note: in expansion of macro 'cmpxchg_local' #define cmpxchg(ptr, o, n) cmpxchg_local((ptr), (o), (n)) ^~~~~~~~~~~~~ /kisskb/src/net/core/filter.c:3569:4: note: in expansion of macro 'cmpxchg' cmpxchg(&ri->map, map, NULL); ^~~~~~~ /kisskb/src/drivers/net/ethernet/freescale/fec_main.c: In function 'fec_restart': /kisskb/src/drivers/net/ethernet/freescale/fec_main.c:947:6: warning: unused variable 'val' [-Wunused-variable] u32 val; ^~~ /kisskb/src/drivers/net/ethernet/freescale/fec_main.c: In function 'fec_get_mac': /kisskb/src/drivers/net/ethernet/freescale/fec_main.c:1665:28: warning: unused variable 'pdata' [-Wunused-variable] struct fec_platform_data *pdata = dev_get_platdata(&fep->pdev->dev); ^~~~~ Completed OK # rm -rf /kisskb/build/linus_m5272c3_defconfig_m68k-gcc8 # Build took: 0:00:29.044574