# git rev-parse -q --verify 21dfbcd1f5cbff9cf2f9e7e43475aed8d072b0dd^{commit} 21dfbcd1f5cbff9cf2f9e7e43475aed8d072b0dd already have revision, skipping fetch # git checkout -q -f -B kisskb 21dfbcd1f5cbff9cf2f9e7e43475aed8d072b0dd # git clean -qxdf # < git log -1 # commit 21dfbcd1f5cbff9cf2f9e7e43475aed8d072b0dd # Author: Ondrej Mosnacek # Date: Wed Aug 12 14:58:25 2020 +0200 # # crypto: algif_aead - fix uninitialized ctx->init # # In skcipher_accept_parent_nokey() the whole af_alg_ctx structure is # cleared by memset() after allocation, so add such memset() also to # aead_accept_parent_nokey() so that the new "init" field is also # initialized to zero. Without that the initial ctx->init checks might # randomly return true and cause errors. # # While there, also remove the redundant zero assignments in both # functions. # # Found via libkcapi testsuite. # # Cc: Stephan Mueller # Fixes: f3c802a1f300 ("crypto: algif_aead - Only wake up when ctx->more is zero") # Suggested-by: Herbert Xu # Signed-off-by: Ondrej Mosnacek # Signed-off-by: Herbert Xu # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 21dfbcd1f5cbff9cf2f9e7e43475aed8d072b0dd # < make -s -j 24 ARCH=x86 O=/kisskb/build/crypto_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # < make -s -j 24 ARCH=x86 O=/kisskb/build/crypto_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- help # make -s -j 24 ARCH=x86 O=/kisskb/build/crypto_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- olddefconfig # make -s -j 24 ARCH=x86 O=/kisskb/build/crypto_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- Completed OK # rm -rf /kisskb/build/crypto_x86-allmodconfig_x86_64-gcc8 # Build took: 0:33:06.391398