# git rev-parse -q --verify fc45f8974252b140023cdccc4a0907853c3ecec8^{commit}
fc45f8974252b140023cdccc4a0907853c3ecec8
already have revision, skipping fetch
# git checkout -q -f -B kisskb fc45f8974252b140023cdccc4a0907853c3ecec8
# git clean -qxdf
# < git log -1
# commit fc45f8974252b140023cdccc4a0907853c3ecec8
# Author: Stephen Rothwell <sfr@canb.auug.org.au>
# Date:   Mon Jun 15 18:02:37 2020 +1000
# 
#     major.h: remove the remaining unnecessary includes of linux/major.h
#     
#     Now that very file that needs the definitions in major.h explicitly
#     includes it, this is just cleaning up.
#     
#     This is fairly safe because major.h does not include any other files.
#     The only real risk is if a symbol defined in major.h is constructed by
#     concatenation in the preprocessor.
#     
#     The actual change was done using the following command:
#     
#       sed -i -E '/[<"](uapi\/)?linux\/major\.h/d' \
#         $(grep -L -w -f xx \
#           $(git grep -E -l '[<"](uapi/)?linux/major\.h'))
#     
#     Where the file xx contians all the symbols defined in major.h
#     
#     (genhd.h was added by inspection.)
#     
#     The win here is really just the number of lines to be parsed by the
#     preprocessor.  major.h is 180 lines long and was being included by
#     these files unnecessarily.  In particular, there are 3 global include
#     files here (tty.h, genhd.h and blkdev.h) that are also included by 354,
#     68 and 554 other files, repectively.
#     
#     After this, major.h is only included by 4 global include files (which
#     are in turn included by 297 other files), so its indirect inclusion is
#     hopefully much reduced.
#     
#     Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
# < /opt/cross/kisskb/korg/gcc-10.1.0-nolibc/sh4-linux/bin/sh4-linux-gcc --version
# < /opt/cross/kisskb/korg/gcc-10.1.0-nolibc/sh4-linux/bin/sh4-linux-ld --version
# < git log --format=%s --max-count=1 fc45f8974252b140023cdccc4a0907853c3ecec8
# < make -s -j 8 ARCH=sh O=/kisskb/build/sfr-test_sh-defconfig_sh4-gcc10 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-10.1.0-nolibc/sh4-linux/bin/sh4-linux-  defconfig
# < make -s -j 8 ARCH=sh O=/kisskb/build/sfr-test_sh-defconfig_sh4-gcc10 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-10.1.0-nolibc/sh4-linux/bin/sh4-linux-  help
# make -s -j 8 ARCH=sh O=/kisskb/build/sfr-test_sh-defconfig_sh4-gcc10 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-10.1.0-nolibc/sh4-linux/bin/sh4-linux-  olddefconfig
# make -s -j 8 ARCH=sh O=/kisskb/build/sfr-test_sh-defconfig_sh4-gcc10 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-10.1.0-nolibc/sh4-linux/bin/sh4-linux-  
  Generating include/generated/machtypes.h
<stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
/kisskb/src/arch/sh/kernel/cpu/sh4/../sh3/../../entry-common.S: Assembler messages:
/kisskb/src/arch/sh/kernel/cpu/sh4/../sh3/../../entry-common.S:385: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence
/kisskb/src/arch/sh/kernel/cpu/sh4/../sh3/../../entry-common.S:388: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence
In file included from /kisskb/src/arch/sh/include/asm/hw_irq.h:6,
                 from /kisskb/src/include/linux/irq.h:563,
                 from /kisskb/src/arch/sh/include/asm/hardirq.h:6,
                 from /kisskb/src/include/linux/hardirq.h:10,
                 from /kisskb/src/include/linux/interrupt.h:11,
                 from /kisskb/src/include/linux/serial_core.h:14,
                 from /kisskb/src/include/linux/serial_sci.h:6,
                 from /kisskb/src/arch/sh/kernel/cpu/sh4a/setup-shx3.c:10:
/kisskb/src/include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div]
  100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
      |                                                               ^
/kisskb/src/include/linux/sh_intc.h:107:2: note: in expansion of macro '_INTC_ARRAY'
  107 |  _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \
      |  ^~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:124:8: note: in expansion of macro 'INTC_HW_DESC'
  124 |  .hw = INTC_HW_DESC(vectors, groups, mask_regs,   \
      |        ^~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/sh4a/setup-shx3.c:309:8: note: in expansion of macro 'DECLARE_INTC_DESC'
  309 | static DECLARE_INTC_DESC(intc_desc, "shx3", vectors, groups,
      |        ^~~~~~~~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div]
  100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
      |                                                               ^
/kisskb/src/include/linux/sh_intc.h:107:27: note: in expansion of macro '_INTC_ARRAY'
  107 |  _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \
      |                           ^~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:124:8: note: in expansion of macro 'INTC_HW_DESC'
  124 |  .hw = INTC_HW_DESC(vectors, groups, mask_regs,   \
      |        ^~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/sh4a/setup-shx3.c:309:8: note: in expansion of macro 'DECLARE_INTC_DESC'
  309 | static DECLARE_INTC_DESC(intc_desc, "shx3", vectors, groups,
      |        ^~~~~~~~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div]
  100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
      |                                                               ^
/kisskb/src/include/linux/sh_intc.h:107:27: note: in expansion of macro '_INTC_ARRAY'
  107 |  _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \
      |                           ^~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:124:8: note: in expansion of macro 'INTC_HW_DESC'
  124 |  .hw = INTC_HW_DESC(vectors, groups, mask_regs,   \
      |        ^~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/sh4a/setup-shx3.c:322:8: note: in expansion of macro 'DECLARE_INTC_DESC'
  322 | static DECLARE_INTC_DESC(intc_desc_irq, "shx3-irq", vectors_irq, groups,
      |        ^~~~~~~~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div]
  100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
      |                                                               ^
/kisskb/src/include/linux/sh_intc.h:107:2: note: in expansion of macro '_INTC_ARRAY'
  107 |  _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \
      |  ^~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:124:8: note: in expansion of macro 'INTC_HW_DESC'
  124 |  .hw = INTC_HW_DESC(vectors, groups, mask_regs,   \
      |        ^~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/sh4a/setup-shx3.c:337:8: note: in expansion of macro 'DECLARE_INTC_DESC'
  337 | static DECLARE_INTC_DESC(intc_desc_irl, "shx3-irl", vectors_irl, groups,
      |        ^~~~~~~~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div]
  100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
      |                                                               ^
/kisskb/src/include/linux/sh_intc.h:107:27: note: in expansion of macro '_INTC_ARRAY'
  107 |  _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \
      |                           ^~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:124:8: note: in expansion of macro 'INTC_HW_DESC'
  124 |  .hw = INTC_HW_DESC(vectors, groups, mask_regs,   \
      |        ^~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/sh4a/setup-shx3.c:337:8: note: in expansion of macro 'DECLARE_INTC_DESC'
  337 | static DECLARE_INTC_DESC(intc_desc_irl, "shx3-irl", vectors_irl, groups,
      |        ^~~~~~~~~~~~~~~~~
/kisskb/src/fs/ext4/readpage.c: In function 'ext4_mpage_readpages':
/kisskb/src/fs/ext4/readpage.c:409:1: warning: the frame size of 1136 bytes is larger than 1024 bytes [-Wframe-larger-than=]
  409 | }
      | ^
/kisskb/src/fs/mpage.c: In function '__mpage_writepage':
/kisskb/src/fs/mpage.c:674:1: warning: the frame size of 1156 bytes is larger than 1024 bytes [-Wframe-larger-than=]
  674 | }
      | ^
/kisskb/src/fs/mpage.c: In function 'do_mpage_readpage':
/kisskb/src/fs/mpage.c:338:1: warning: the frame size of 1092 bytes is larger than 1024 bytes [-Wframe-larger-than=]
  338 | }
      | ^
/kisskb/src/drivers/sh/clk/cpg.c: In function 'r8':
/kisskb/src/drivers/sh/clk/cpg.c:41:17: warning: passing argument 1 of 'ioread8' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   41 |  return ioread8(addr);
      |                 ^~~~
In file included from /kisskb/src/arch/sh/include/asm/io.h:21,
                 from /kisskb/src/include/linux/io.h:13,
                 from /kisskb/src/drivers/sh/clk/cpg.c:14:
/kisskb/src/include/asm-generic/iomap.h:29:29: note: expected 'void *' but argument is of type 'const void *'
   29 | extern unsigned int ioread8(void __iomem *);
      |                             ^~~~~~~~~~~~~~
/kisskb/src/drivers/sh/clk/cpg.c: In function 'r16':
/kisskb/src/drivers/sh/clk/cpg.c:46:18: warning: passing argument 1 of 'ioread16' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   46 |  return ioread16(addr);
      |                  ^~~~
In file included from /kisskb/src/arch/sh/include/asm/io.h:21,
                 from /kisskb/src/include/linux/io.h:13,
                 from /kisskb/src/drivers/sh/clk/cpg.c:14:
/kisskb/src/include/asm-generic/iomap.h:30:30: note: expected 'void *' but argument is of type 'const void *'
   30 | extern unsigned int ioread16(void __iomem *);
      |                              ^~~~~~~~~~~~~~
/kisskb/src/drivers/sh/clk/cpg.c: In function 'r32':
/kisskb/src/drivers/sh/clk/cpg.c:51:18: warning: passing argument 1 of 'ioread32' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   51 |  return ioread32(addr);
      |                  ^~~~
In file included from /kisskb/src/arch/sh/include/asm/io.h:21,
                 from /kisskb/src/include/linux/io.h:13,
                 from /kisskb/src/drivers/sh/clk/cpg.c:14:
/kisskb/src/include/asm-generic/iomap.h:32:30: note: expected 'void *' but argument is of type 'const void *'
   32 | extern unsigned int ioread32(void __iomem *);
      |                              ^~~~~~~~~~~~~~
  Kernel: arch/sh/boot/zImage is ready
Completed OK
# rm -rf /kisskb/build/sfr-test_sh-defconfig_sh4-gcc10
# Build took: 0:01:36.226763