# git rev-parse -q --verify 6a9dc5fd6170d0a41c8a14eb19e63d94bea5705a^{commit} 6a9dc5fd6170d0a41c8a14eb19e63d94bea5705a already have revision, skipping fetch # git checkout -q -f -B kisskb 6a9dc5fd6170d0a41c8a14eb19e63d94bea5705a # git clean -qxdf # < git log -1 # commit 6a9dc5fd6170d0a41c8a14eb19e63d94bea5705a # Author: Gustavo A. R. Silva # Date: Mon Aug 24 15:36:14 2020 -0500 # # lib: Revert use of fallthrough pseudo-keyword in lib/ # # The following build error for powerpc64 was reported by Nathan Chancellor: # # "$ scripts/config --file arch/powerpc/configs/powernv_defconfig -e KERNEL_XZ # # $ make -skj"$(nproc)" ARCH=powerpc CROSS_COMPILE=powerpc64le-linux- distclean powernv_defconfig zImage # ... # In file included from arch/powerpc/boot/../../../lib/decompress_unxz.c:234, # from arch/powerpc/boot/decompress.c:38: # arch/powerpc/boot/../../../lib/xz/xz_dec_stream.c: In function 'dec_main': # arch/powerpc/boot/../../../lib/xz/xz_dec_stream.c:586:4: error: 'fallthrough' undeclared (first use in this function) # 586 | fallthrough; # | ^~~~~~~~~~~ # # This will end up affecting distribution configurations such as Debian # and OpenSUSE according to my testing. I am not sure what the solution # is, the PowerPC wrapper does not set -D__KERNEL__ so I am not sure # that compiler_attributes.h can be safely included." # # In order to avoid these sort of problems, it seems that the best # solution is to use /* fall through */ comments instead of the # fallthrough pseudo-keyword macro in lib/, for now. # # Reported-by: Nathan Chancellor # Fixes: df561f6688fe ("treewide: Use fallthrough pseudo-keyword") # Signed-off-by: Gustavo A. R. Silva # Reviewed-and-tested-by: Nathan Chancellor # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 6a9dc5fd6170d0a41c8a14eb19e63d94bea5705a # < make -s -j 10 ARCH=powerpc O=/kisskb/build/linus_ppc44x_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- ppc44x_defconfig # < make -s -j 10 ARCH=powerpc O=/kisskb/build/linus_ppc44x_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 10 ARCH=powerpc O=/kisskb/build/linus_ppc44x_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 10 ARCH=powerpc O=/kisskb/build/linus_ppc44x_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/block/genhd.c: In function 'diskstats_show': /kisskb/src/block/genhd.c:1667:1: warning: the frame size of 1160 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ /kisskb/src/lib/zstd/compress.c: In function 'ZSTD_compressBlock_doubleFast': /kisskb/src/lib/zstd/compress.c:1393:1: warning: the frame size of 1584 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ INFO: Uncompressed kernel (size 0x5e37b4) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5e37b4) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5e37b4) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5e37b4) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5e37b4) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5e37b4) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5e37b4) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5e37b4) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5e37b4) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x5e37b4) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) Image Name: Linux-5.9.0-rc2-g6a9dc5fd6170 Created: Tue Aug 25 10:38:43 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3040826 Bytes = 2969.56 KiB = 2.90 MiB Load Address: 00600000 Entry Point: 006000c4 INFO: Uncompressed kernel (size 0x5e37b4) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) Image Name: Linux-5.9.0-rc2-g6a9dc5fd6170 Created: Tue Aug 25 10:38:44 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3040995 Bytes = 2969.72 KiB = 2.90 MiB Load Address: 00600000 Entry Point: 006001b8 Image Name: Linux-5.9.0-rc2-g6a9dc5fd6170 Created: Tue Aug 25 10:38:44 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3040812 Bytes = 2969.54 KiB = 2.90 MiB Load Address: 00600000 Entry Point: 006014a8 Image Name: Linux-5.9.0-rc2-g6a9dc5fd6170 Created: Tue Aug 25 10:38:44 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3040661 Bytes = 2969.40 KiB = 2.90 MiB Load Address: 00600000 Entry Point: 006014a0 Image Name: Linux-5.9.0-rc2-g6a9dc5fd6170 Created: Tue Aug 25 10:38:44 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3040153 Bytes = 2968.90 KiB = 2.90 MiB Load Address: 00600000 Entry Point: 006014a8 Image Name: Linux-5.9.0-rc2-g6a9dc5fd6170 Created: Tue Aug 25 10:38:44 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3040380 Bytes = 2969.12 KiB = 2.90 MiB Load Address: 00600000 Entry Point: 006014a8 Image Name: Linux-5.9.0-rc2-g6a9dc5fd6170 Created: Tue Aug 25 10:38:44 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3040882 Bytes = 2969.61 KiB = 2.90 MiB Load Address: 00600000 Entry Point: 00601488 Image Name: Linux-5.9.0-rc2-g6a9dc5fd6170 Created: Tue Aug 25 10:38:44 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3040340 Bytes = 2969.08 KiB = 2.90 MiB Load Address: 00600000 Entry Point: 006014b8 Image Name: Linux-5.9.0-rc2-g6a9dc5fd6170 Created: Tue Aug 25 10:38:44 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3040251 Bytes = 2969.00 KiB = 2.90 MiB Load Address: 00600000 Entry Point: 00601498 Completed OK # rm -rf /kisskb/build/linus_ppc44x_defconfig_powerpc-gcc4.9 # Build took: 0:01:58.579221