# git rev-parse -q --verify 6a9dc5fd6170d0a41c8a14eb19e63d94bea5705a^{commit} 6a9dc5fd6170d0a41c8a14eb19e63d94bea5705a already have revision, skipping fetch # git checkout -q -f -B kisskb 6a9dc5fd6170d0a41c8a14eb19e63d94bea5705a # git clean -qxdf # < git log -1 # commit 6a9dc5fd6170d0a41c8a14eb19e63d94bea5705a # Author: Gustavo A. R. Silva # Date: Mon Aug 24 15:36:14 2020 -0500 # # lib: Revert use of fallthrough pseudo-keyword in lib/ # # The following build error for powerpc64 was reported by Nathan Chancellor: # # "$ scripts/config --file arch/powerpc/configs/powernv_defconfig -e KERNEL_XZ # # $ make -skj"$(nproc)" ARCH=powerpc CROSS_COMPILE=powerpc64le-linux- distclean powernv_defconfig zImage # ... # In file included from arch/powerpc/boot/../../../lib/decompress_unxz.c:234, # from arch/powerpc/boot/decompress.c:38: # arch/powerpc/boot/../../../lib/xz/xz_dec_stream.c: In function 'dec_main': # arch/powerpc/boot/../../../lib/xz/xz_dec_stream.c:586:4: error: 'fallthrough' undeclared (first use in this function) # 586 | fallthrough; # | ^~~~~~~~~~~ # # This will end up affecting distribution configurations such as Debian # and OpenSUSE according to my testing. I am not sure what the solution # is, the PowerPC wrapper does not set -D__KERNEL__ so I am not sure # that compiler_attributes.h can be safely included." # # In order to avoid these sort of problems, it seems that the best # solution is to use /* fall through */ comments instead of the # fallthrough pseudo-keyword macro in lib/, for now. # # Reported-by: Nathan Chancellor # Fixes: df561f6688fe ("treewide: Use fallthrough pseudo-keyword") # Signed-off-by: Gustavo A. R. Silva # Reviewed-and-tested-by: Nathan Chancellor # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld --version # < git log --format=%s --max-count=1 6a9dc5fd6170d0a41c8a14eb19e63d94bea5705a # < make -s -j 8 ARCH=nds32 O=/kisskb/build/linus_nds32-allmodconfig_nds32le-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux- allmodconfig # < make -s -j 8 ARCH=nds32 O=/kisskb/build/linus_nds32-allmodconfig_nds32le-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux- help # make -s -j 8 ARCH=nds32 O=/kisskb/build/linus_nds32-allmodconfig_nds32le-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux- olddefconfig # make -s -j 8 ARCH=nds32 O=/kisskb/build/linus_nds32-allmodconfig_nds32le-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux- :1511:2: warning: #warning syscall clone3 not implemented [-Wcpp] /kisskb/src/drivers/input/joystick/analog.c:160:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp] #warning Precise timer not defined for this architecture. ^~~~~~~ In file included from /kisskb/src/include/linux/printk.h:405, from /kisskb/src/include/linux/kernel.h:15, from /kisskb/src/include/linux/clk.h:13, from /kisskb/src/drivers/crypto/sa2ul.c:11: /kisskb/src/drivers/crypto/sa2ul.c: In function 'sa_sha_init': /kisskb/src/drivers/crypto/sa2ul.c:1486:33: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] crypto_ahash_digestsize(tfm), (u64)rctx); ^ /kisskb/src/include/linux/dynamic_debug.h:125:15: note: in definition of macro '__dynamic_func_call' func(&id, ##__VA_ARGS__); \ ^~~~~~~~~~~ /kisskb/src/include/linux/dynamic_debug.h:157:2: note: in expansion of macro '_dynamic_func_call' _dynamic_func_call(fmt,__dynamic_dev_dbg, \ ^~~~~~~~~~~~~~~~~~ /kisskb/src/include/linux/dev_printk.h:115:2: note: in expansion of macro 'dynamic_dev_dbg' dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~ /kisskb/src/drivers/crypto/sa2ul.c:1485:2: note: in expansion of macro 'dev_dbg' dev_dbg(sa_k3_dev, "init: digest size: %d, rctx=%llx\n", ^~~~~~~ WARNING: modpost: EXPORT symbol "clear_page" [vmlinux] version generation failed, symbol will not be versioned. WARNING: modpost: EXPORT symbol "copy_page" [vmlinux] version generation failed, symbol will not be versioned. Completed OK # rm -rf /kisskb/build/linus_nds32-allmodconfig_nds32le-gcc8 # Build took: 0:31:53.095779