# git rev-parse -q --verify 308f765116e9176bf508c10b72ca80ad594e3119^{commit} # git fetch -q -n -f https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git for-next/kspp warning: The last gc run reported the following. Please correct the root cause and remove .git/gc.log. Automatic cleanup will not be performed until the file is removed. warning: There are too many unreachable loose objects; run 'git prune' to remove them. # git rev-parse -q --verify 308f765116e9176bf508c10b72ca80ad594e3119^{commit} 308f765116e9176bf508c10b72ca80ad594e3119 # git checkout -q -f -B kisskb 308f765116e9176bf508c10b72ca80ad594e3119 # git clean -qxdf # < git log -1 # commit 308f765116e9176bf508c10b72ca80ad594e3119 # Author: Gustavo A. R. Silva # Date: Mon Aug 24 15:20:04 2020 -0500 # # lib: Revert use of fallthrough pseudo-keyword # # The following build error was reported by Nathan Chancellor: # # "$ scripts/config --file arch/powerpc/configs/powernv_defconfig -e KERNEL_XZ # # $ make -skj"$(nproc)" ARCH=powerpc CROSS_COMPILE=powerpc64le-linux- distclean powernv_defconfig zImage # ... # In file included from arch/powerpc/boot/../../../lib/decompress_unxz.c:234, # from arch/powerpc/boot/decompress.c:38: # arch/powerpc/boot/../../../lib/xz/xz_dec_stream.c: In function 'dec_main': # arch/powerpc/boot/../../../lib/xz/xz_dec_stream.c:586:4: error: 'fallthrough' undeclared (first use in this function) # 586 | fallthrough; # | ^~~~~~~~~~~ # arch/powerpc/boot/../../../lib/xz/xz_dec_stream.c:586:4: note: each undeclared identifier is reported only once for each function it appears in # In file included from arch/powerpc/boot/../../../lib/decompress_unxz.c:235, # from arch/powerpc/boot/decompress.c:38: # arch/powerpc/boot/../../../lib/xz/xz_dec_lzma2.c: In function 'xz_dec_lzma2_run': # arch/powerpc/boot/../../../lib/xz/xz_dec_lzma2.c:1046:4: error: 'fallthrough' undeclared (first use in this function) # 1046 | fallthrough; # | ^~~~~~~~~~~ # make[2]: *** [arch/powerpc/boot/Makefile:215: arch/powerpc/boot/decompress.o] Error 1 # make[2]: Target 'arch/powerpc/boot/zImage' not remade because of errors. # make[1]: *** [arch/powerpc/Makefile:295: zImage] Error 2 # make: *** [Makefile:335: __build_one_by_one] Error 2 # make: Target 'distclean' not remade because of errors. # make: Target 'powernv_defconfig' not remade because of errors. # make: Target 'zImage' not remade because of errors. # # This will end up affecting distribution configurations such as Debian # and OpenSUSE according to my testing. I am not sure what the solution # is, the PowerPC wrapper does not set -D__KERNEL__ so I am not sure that # compiler_attributes.h can be safely included." # # In order to avoid these sort of problems, it seems that the best # solution is to use /* fall through */ comments instead of the # fallthrough pseudo-keyword macro in lib/, for now. # # Reported-by: Nathan Chancellor # Fixes: df561f6688fe ("treewide: Use fallthrough pseudo-keyword") # Signed-off-by: Gustavo A. R. Silva # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 308f765116e9176bf508c10b72ca80ad594e3119 # < make -s -j 8 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_defconfig # < make -s -j 8 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 8 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 8 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/include/linux/kernel.h:11, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/module.h:12, from /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:15: /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 22 | #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) | ^ /kisskb/src/include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:139:6: note: in expansion of macro 'IS_ERR_VALUE' 139 | if (IS_ERR_VALUE(fep->ring_mem_addr)) | ^~~~~~~~~~~~ cc1: fatal error: opening output file arch/powerpc/boot/dts/fsl/.mpc8540ads.dtb.dts.tmp: No such file or directory compilation terminated. make[2]: *** [scripts/Makefile.lib:326: arch/powerpc/boot/dts/fsl/mpc8540ads.dtb] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [arch/powerpc/Makefile:295: zImage] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:185: __sub-make] Error 2 Command 'make -s -j 8 ARCH=powerpc O=/kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/gustavoars_mpc85xx_defconfig_powerpc-gcc9 # Build took: 0:05:17.417112