Buildresult: linus/multi_v7_defconfig/arm-gcc4.9 built on Oct 27 2020, 11:03

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Oct 27 2020, 11:03
Duration:	0:04:55.047928
Builder:	ka4
Revision:	scsi: qla2xxx: remove incorrect sparse #ifdef (`4525c8781ec0701ce824e8bd379ae1b129e26568)`
Target:	linus/multi_v7_defconfig/arm-gcc4.9
Branch:	linus
Compiler:	arm-gcc4.9 (arm-linux-gnueabi-gcc (GCC) 4.9.4 / GNU ld (GNU Binutils) 2.29.1.20170915)
Config:	multi_v7_defconfig (download)
Log:	Download original Possible warnings (9) arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge): /soc/apb@d4000000/spi@d4037000: incorrect #address-cells for SPI bus arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge): /soc/apb@d4000000/spi@d4037000: incorrect #size-cells for SPI bus arch/arm/boot/dts/mmp2-olpc-xo-1-75.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm/crypto/ghash-ce-glue.c:67:44: warning: passing argument 4 of 'pmull_ghash_update_p64' from incompatible pointer type arch/arm/crypto/ghash-ce-glue.c:69:43: warning: passing argument 4 of 'pmull_ghash_update_p8' from incompatible pointer type drivers/firmware/qcom_scm-smc.c:94:9: warning: missing braces around initializer [-Wmissing-braces] drivers/firmware/qcom_scm-smc.c:94:9: warning: (near initialization for 'smc.args') [-Wmissing-braces] drivers/firmware/qcom_scm-legacy.c:139:9: warning: missing braces around initializer [-Wmissing-braces] drivers/firmware/qcom_scm-legacy.c:139:9: warning: (near initialization for 'smc.args') [-Wmissing-braces] Full Log # git rev-parse -q --verify 4525c8781ec0701ce824e8bd379ae1b129e26568^{commit} 4525c8781ec0701ce824e8bd379ae1b129e26568 already have revision, skipping fetch # git checkout -q -f -B kisskb 4525c8781ec0701ce824e8bd379ae1b129e26568 # git clean -qxdf # < git log -1 # commit 4525c8781ec0701ce824e8bd379ae1b129e26568 # Author: Linus Torvalds <torvalds@linux-foundation.org> # Date: Mon Oct 26 15:45:22 2020 -0700 # # scsi: qla2xxx: remove incorrect sparse #ifdef # # The code to try to shut up sparse warnings about questionable locking # didn't shut up sparse: it made the result not parse as valid C at all, # since the end result now has a label with no statement. # # The proper fix is to just always lock the hardware, the same way Bart # did in commit 8ae178760b23 ("scsi: qla2xxx: Simplify the functions for # dumping firmware"). That avoids the whole problem with having locking # that is not statically obvious. # # But in the meantime, just remove the incorrect attempt at trying to # avoid a sparse warning that just made things worse. # # This was exposed by commit 3e6efab865ac ("scsi: qla2xxx: Fix reset of # MPI firmware"), very similarly to how commit cbb01c2f2f63 ("scsi: # qla2xxx: Fix MPI failure AEN (8200) handling") exposed the same problem # in another place, and caused that commit 8ae178760b23. # # Please don't add code to just shut up sparse without actually fixing # what sparse complains about. # # Reported-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> # Cc: Bart Van Assche <bvanassche@acm.org> # Cc: Arun Easi <aeasi@marvell.com> # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi-ld --version # < git log --format=%s --max-count=1 4525c8781ec0701ce824e8bd379ae1b129e26568 # < make -s -j 10 ARCH=arm O=/kisskb/build/linus_multi_v7_defconfig_arm-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi- multi_v7_defconfig # make -s -j 10 ARCH=arm O=/kisskb/build/linus_multi_v7_defconfig_arm-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi- /kisskb/src/arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge): /soc/apb@d4000000/spi@d4037000: incorrect #address-cells for SPI bus also defined at /kisskb/src/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3 /kisskb/src/arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge): /soc/apb@d4000000/spi@d4037000: incorrect #size-cells for SPI bus also defined at /kisskb/src/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3 arch/arm/boot/dts/mmp2-olpc-xo-1-75.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' /kisskb/src/arch/arm/crypto/ghash-ce-glue.c: In function 'ghash_do_update': /kisskb/src/arch/arm/crypto/ghash-ce-glue.c:67:44: warning: passing argument 4 of 'pmull_ghash_update_p64' from incompatible pointer type pmull_ghash_update_p64(blocks, dg, src, key->h, head); ^ /kisskb/src/arch/arm/crypto/ghash-ce-glue.c:45:17: note: expected 'const u64 ()[2]' but argument is of type 'u64 ()[2]' asmlinkage void pmull_ghash_update_p64(int blocks, u64 dg[], const char src, ^ /kisskb/src/arch/arm/crypto/ghash-ce-glue.c:69:43: warning: passing argument 4 of 'pmull_ghash_update_p8' from incompatible pointer type pmull_ghash_update_p8(blocks, dg, src, key->h, head); ^ /kisskb/src/arch/arm/crypto/ghash-ce-glue.c:48:17: note: expected 'const u64 ()[2]' but argument is of type 'u64 ()[2]' asmlinkage void pmull_ghash_update_p8(int blocks, u64 dg[], const char src, ^ /kisskb/src/drivers/firmware/qcom_scm-smc.c: In function 'scm_smc_call': /kisskb/src/drivers/firmware/qcom_scm-smc.c:94:9: warning: missing braces around initializer [-Wmissing-braces] struct arm_smccc_args smc = {0}; ^ /kisskb/src/drivers/firmware/qcom_scm-smc.c:94:9: warning: (near initialization for 'smc.args') [-Wmissing-braces] /kisskb/src/drivers/firmware/qcom_scm-legacy.c: In function 'scm_legacy_call': /kisskb/src/drivers/firmware/qcom_scm-legacy.c:139:9: warning: missing braces around initializer [-Wmissing-braces] struct arm_smccc_args smc = {0}; ^ /kisskb/src/drivers/firmware/qcom_scm-legacy.c:139:9: warning: (near initialization for 'smc.args') [-Wmissing-braces] Completed OK # rm -rf /kisskb/build/linus_multi_v7_defconfig_arm-gcc4.9 # Build took: 0:04:55.047928

© Michael Ellerman 2006-2018.