# git rev-parse -q --verify 4525c8781ec0701ce824e8bd379ae1b129e26568^{commit} 4525c8781ec0701ce824e8bd379ae1b129e26568 already have revision, skipping fetch # git checkout -q -f -B kisskb 4525c8781ec0701ce824e8bd379ae1b129e26568 # git clean -qxdf # < git log -1 # commit 4525c8781ec0701ce824e8bd379ae1b129e26568 # Author: Linus Torvalds # Date: Mon Oct 26 15:45:22 2020 -0700 # # scsi: qla2xxx: remove incorrect sparse #ifdef # # The code to try to shut up sparse warnings about questionable locking # didn't shut up sparse: it made the result not parse as valid C at all, # since the end result now has a label with no statement. # # The proper fix is to just always lock the hardware, the same way Bart # did in commit 8ae178760b23 ("scsi: qla2xxx: Simplify the functions for # dumping firmware"). That avoids the whole problem with having locking # that is not statically obvious. # # But in the meantime, just remove the incorrect attempt at trying to # avoid a sparse warning that just made things worse. # # This was exposed by commit 3e6efab865ac ("scsi: qla2xxx: Fix reset of # MPI firmware"), very similarly to how commit cbb01c2f2f63 ("scsi: # qla2xxx: Fix MPI failure AEN (8200) handling") exposed the same problem # in another place, and caused that commit 8ae178760b23. # # Please don't add code to just shut up sparse without actually fixing # what sparse complains about. # # Reported-by: Luc Van Oostenryck # Cc: Bart Van Assche # Cc: Arun Easi # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 4525c8781ec0701ce824e8bd379ae1b129e26568 # < make -s -j 10 ARCH=powerpc O=/kisskb/build/linus_ppc6xx_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- ppc6xx_defconfig # < make -s -j 10 ARCH=powerpc O=/kisskb/build/linus_ppc6xx_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 10 ARCH=powerpc O=/kisskb/build/linus_ppc6xx_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 10 ARCH=powerpc O=/kisskb/build/linus_ppc6xx_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/block/genhd.c: In function 'diskstats_show': /kisskb/src/block/genhd.c:1659:1: warning: the frame size of 1160 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ INFO: Uncompressed kernel (size 0xc4e010) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc4e010) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc4e010) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc4e010) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc4e010) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc4e010) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc3d928) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc4e010) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc4e010) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) INFO: Uncompressed kernel (size 0xc4e010) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) Image Name: Linux-5.10.0-rc1+ Created: Tue Oct 27 11:31:51 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5398828 Bytes = 5272.29 KiB = 5.15 MiB Load Address: 00000000 Entry Point: 00000000 INFO: Uncompressed kernel (size 0xc4e010) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) Image Name: Linux-5.10.0-rc1+ Created: Tue Oct 27 11:31:52 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5428869 Bytes = 5301.63 KiB = 5.18 MiB Load Address: 00d00000 Entry Point: 00d00894 Image Name: Linux-5.10.0-rc1+ Created: Tue Oct 27 11:31:52 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5430338 Bytes = 5303.06 KiB = 5.18 MiB Load Address: 00d00000 Entry Point: 00d00294 Image Name: Linux-5.10.0-rc1+ Created: Tue Oct 27 11:31:52 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5430034 Bytes = 5302.77 KiB = 5.18 MiB Load Address: 00d00000 Entry Point: 00d00294 Image Name: Linux-5.10.0-rc1+ Created: Tue Oct 27 11:31:52 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5429134 Bytes = 5301.89 KiB = 5.18 MiB Load Address: 00d00000 Entry Point: 00d00894 Image Name: Linux-5.10.0-rc1+ Created: Tue Oct 27 11:31:52 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5430041 Bytes = 5302.77 KiB = 5.18 MiB Load Address: 00d00000 Entry Point: 00d00294 INFO: Uncompressed kernel (size 0xc3d928) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xd00000) Image Name: Linux-5.10.0-rc1+ Created: Tue Oct 27 11:31:56 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5428844 Bytes = 5301.61 KiB = 5.18 MiB Load Address: 00d00000 Entry Point: 00d00294 Image Name: Linux-5.10.0-rc1+ Created: Tue Oct 27 11:31:56 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5429533 Bytes = 5302.28 KiB = 5.18 MiB Load Address: 00d00000 Entry Point: 00d00294 Image Name: Linux-5.10.0-rc1+ Created: Tue Oct 27 11:31:56 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5430033 Bytes = 5302.77 KiB = 5.18 MiB Load Address: 00d00000 Entry Point: 00d00294 Completed OK # rm -rf /kisskb/build/linus_ppc6xx_defconfig_powerpc-gcc4.9 # Build took: 0:07:32.213028