# git rev-parse -q --verify 4525c8781ec0701ce824e8bd379ae1b129e26568^{commit}
4525c8781ec0701ce824e8bd379ae1b129e26568
already have revision, skipping fetch
# git checkout -q -f -B kisskb 4525c8781ec0701ce824e8bd379ae1b129e26568
# git clean -qxdf
# < git log -1
# commit 4525c8781ec0701ce824e8bd379ae1b129e26568
# Author: Linus Torvalds <torvalds@linux-foundation.org>
# Date:   Mon Oct 26 15:45:22 2020 -0700
# 
#     scsi: qla2xxx: remove incorrect sparse #ifdef
#     
#     The code to try to shut up sparse warnings about questionable locking
#     didn't shut up sparse: it made the result not parse as valid C at all,
#     since the end result now has a label with no statement.
#     
#     The proper fix is to just always lock the hardware, the same way Bart
#     did in commit 8ae178760b23 ("scsi: qla2xxx: Simplify the functions for
#     dumping firmware").  That avoids the whole problem with having locking
#     that is not statically obvious.
#     
#     But in the meantime, just remove the incorrect attempt at trying to
#     avoid a sparse warning that just made things worse.
#     
#     This was exposed by commit 3e6efab865ac ("scsi: qla2xxx: Fix reset of
#     MPI firmware"), very similarly to how commit cbb01c2f2f63 ("scsi:
#     qla2xxx: Fix MPI failure AEN (8200) handling") exposed the same problem
#     in another place, and caused that commit 8ae178760b23.
#     
#     Please don't add code to just shut up sparse without actually fixing
#     what sparse complains about.
#     
#     Reported-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
#     Cc: Bart Van Assche <bvanassche@acm.org>
#     Cc: Arun Easi <aeasi@marvell.com>
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/korg/gcc-10.1.0-nolibc/sh4-linux/bin/sh4-linux-gcc --version
# < /opt/cross/kisskb/korg/gcc-10.1.0-nolibc/sh4-linux/bin/sh4-linux-ld --version
# < git log --format=%s --max-count=1 4525c8781ec0701ce824e8bd379ae1b129e26568
# < make -s -j 10 ARCH=sh O=/kisskb/build/linus_se7619_defconfig_sh4-gcc10 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-10.1.0-nolibc/sh4-linux/bin/sh4-linux-  se7619_defconfig
# make -s -j 10 ARCH=sh O=/kisskb/build/linus_se7619_defconfig_sh4-gcc10 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-10.1.0-nolibc/sh4-linux/bin/sh4-linux-  
  Generating include/generated/machtypes.h
<stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
In file included from /kisskb/src/arch/sh/include/asm/hw_irq.h:6,
                 from /kisskb/src/include/linux/irq.h:589,
                 from /kisskb/src/arch/sh/include/asm/hardirq.h:6,
                 from /kisskb/src/include/linux/hardirq.h:10,
                 from /kisskb/src/include/linux/interrupt.h:11,
                 from /kisskb/src/include/linux/serial_core.h:13,
                 from /kisskb/src/include/linux/serial_sci.h:6,
                 from /kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:11:
/kisskb/src/include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div]
  100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
      |                                                               ^
/kisskb/src/include/linux/sh_intc.h:105:24: note: in expansion of macro '_INTC_ARRAY'
  105 |  _INTC_ARRAY(vectors), _INTC_ARRAY(groups), \
      |                        ^~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:124:8: note: in expansion of macro 'INTC_HW_DESC'
  124 |  .hw = INTC_HW_DESC(vectors, groups, mask_regs,   \
      |        ^~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:58:8: note: in expansion of macro 'DECLARE_INTC_DESC'
   58 | static DECLARE_INTC_DESC(intc_desc, "sh7619", vectors, NULL,
      |        ^~~~~~~~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div]
  100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
      |                                                               ^
/kisskb/src/include/linux/sh_intc.h:106:2: note: in expansion of macro '_INTC_ARRAY'
  106 |  _INTC_ARRAY(mask_regs), _INTC_ARRAY(prio_regs), \
      |  ^~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:124:8: note: in expansion of macro 'INTC_HW_DESC'
  124 |  .hw = INTC_HW_DESC(vectors, groups, mask_regs,   \
      |        ^~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:58:8: note: in expansion of macro 'DECLARE_INTC_DESC'
   58 | static DECLARE_INTC_DESC(intc_desc, "sh7619", vectors, NULL,
      |        ^~~~~~~~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div]
  100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
      |                                                               ^
/kisskb/src/include/linux/sh_intc.h:107:2: note: in expansion of macro '_INTC_ARRAY'
  107 |  _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \
      |  ^~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:124:8: note: in expansion of macro 'INTC_HW_DESC'
  124 |  .hw = INTC_HW_DESC(vectors, groups, mask_regs,   \
      |        ^~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:58:8: note: in expansion of macro 'DECLARE_INTC_DESC'
   58 | static DECLARE_INTC_DESC(intc_desc, "sh7619", vectors, NULL,
      |        ^~~~~~~~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div]
  100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
      |                                                               ^
/kisskb/src/include/linux/sh_intc.h:107:27: note: in expansion of macro '_INTC_ARRAY'
  107 |  _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \
      |                           ^~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:124:8: note: in expansion of macro 'INTC_HW_DESC'
  124 |  .hw = INTC_HW_DESC(vectors, groups, mask_regs,   \
      |        ^~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:58:8: note: in expansion of macro 'DECLARE_INTC_DESC'
   58 | static DECLARE_INTC_DESC(intc_desc, "sh7619", vectors, NULL,
      |        ^~~~~~~~~~~~~~~~~
/kisskb/src/drivers/tty/serial/sh-sci.c: In function 'sci_remap_port':
/kisskb/src/drivers/tty/serial/sh-sci.c:2677:19: warning: unused variable 'sport' [-Wunused-variable]
 2677 |  struct sci_port *sport = to_sci_port(port);
      |                   ^~~~~
Completed OK
# rm -rf /kisskb/build/linus_se7619_defconfig_sh4-gcc10
# Build took: 0:00:33.186083