# git rev-parse -q --verify 4525c8781ec0701ce824e8bd379ae1b129e26568^{commit}
4525c8781ec0701ce824e8bd379ae1b129e26568
already have revision, skipping fetch
# git checkout -q -f -B kisskb 4525c8781ec0701ce824e8bd379ae1b129e26568
# git clean -qxdf
# < git log -1
# commit 4525c8781ec0701ce824e8bd379ae1b129e26568
# Author: Linus Torvalds <torvalds@linux-foundation.org>
# Date:   Mon Oct 26 15:45:22 2020 -0700
# 
#     scsi: qla2xxx: remove incorrect sparse #ifdef
#     
#     The code to try to shut up sparse warnings about questionable locking
#     didn't shut up sparse: it made the result not parse as valid C at all,
#     since the end result now has a label with no statement.
#     
#     The proper fix is to just always lock the hardware, the same way Bart
#     did in commit 8ae178760b23 ("scsi: qla2xxx: Simplify the functions for
#     dumping firmware").  That avoids the whole problem with having locking
#     that is not statically obvious.
#     
#     But in the meantime, just remove the incorrect attempt at trying to
#     avoid a sparse warning that just made things worse.
#     
#     This was exposed by commit 3e6efab865ac ("scsi: qla2xxx: Fix reset of
#     MPI firmware"), very similarly to how commit cbb01c2f2f63 ("scsi:
#     qla2xxx: Fix MPI failure AEN (8200) handling") exposed the same problem
#     in another place, and caused that commit 8ae178760b23.
#     
#     Please don't add code to just shut up sparse without actually fixing
#     what sparse complains about.
#     
#     Reported-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
#     Cc: Bart Van Assche <bvanassche@acm.org>
#     Cc: Arun Easi <aeasi@marvell.com>
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux-gcc --version
# < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux-ld --version
# < git log --format=%s --max-count=1 4525c8781ec0701ce824e8bd379ae1b129e26568
# < make -s -j 8 ARCH=mips O=/kisskb/build/linus_ip22_defconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux-  ip22_defconfig
# < make -s -j 8 ARCH=mips O=/kisskb/build/linus_ip22_defconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux-  help
# make -s -j 8 ARCH=mips O=/kisskb/build/linus_ip22_defconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux-  olddefconfig
# make -s -j 8 ARCH=mips O=/kisskb/build/linus_ip22_defconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux-  
Completed OK
# rm -rf /kisskb/build/linus_ip22_defconfig_mips-gcc8
# Build took: 0:02:56.894419