# git rev-parse -q --verify 4525c8781ec0701ce824e8bd379ae1b129e26568^{commit} 4525c8781ec0701ce824e8bd379ae1b129e26568 already have revision, skipping fetch # git checkout -q -f -B kisskb 4525c8781ec0701ce824e8bd379ae1b129e26568 # git clean -qxdf # < git log -1 # commit 4525c8781ec0701ce824e8bd379ae1b129e26568 # Author: Linus Torvalds # Date: Mon Oct 26 15:45:22 2020 -0700 # # scsi: qla2xxx: remove incorrect sparse #ifdef # # The code to try to shut up sparse warnings about questionable locking # didn't shut up sparse: it made the result not parse as valid C at all, # since the end result now has a label with no statement. # # The proper fix is to just always lock the hardware, the same way Bart # did in commit 8ae178760b23 ("scsi: qla2xxx: Simplify the functions for # dumping firmware"). That avoids the whole problem with having locking # that is not statically obvious. # # But in the meantime, just remove the incorrect attempt at trying to # avoid a sparse warning that just made things worse. # # This was exposed by commit 3e6efab865ac ("scsi: qla2xxx: Fix reset of # MPI firmware"), very similarly to how commit cbb01c2f2f63 ("scsi: # qla2xxx: Fix MPI failure AEN (8200) handling") exposed the same problem # in another place, and caused that commit 8ae178760b23. # # Please don't add code to just shut up sparse without actually fixing # what sparse complains about. # # Reported-by: Luc Van Oostenryck # Cc: Bart Van Assche # Cc: Arun Easi # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux-gcc --version # < /opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux-ld --version # < git log --format=%s --max-count=1 4525c8781ec0701ce824e8bd379ae1b129e26568 # < make -s -j 8 ARCH=arm64 O=/kisskb/build/linus-rand_arm64-randconfig_arm64-gcc5.4 CROSS_COMPILE=/opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux- randconfig KCONFIG_SEED=0xEFBB499B # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # < make -s -j 8 ARCH=arm64 O=/kisskb/build/linus-rand_arm64-randconfig_arm64-gcc5.4 CROSS_COMPILE=/opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux- help # make -s -j 8 ARCH=arm64 O=/kisskb/build/linus-rand_arm64-randconfig_arm64-gcc5.4 CROSS_COMPILE=/opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux- olddefconfig .config:6251:warning: override: reassigning to symbol PREVENT_FIRMWARE_BUILD # make -s -j 8 ARCH=arm64 O=/kisskb/build/linus-rand_arm64-randconfig_arm64-gcc5.4 CROSS_COMPILE=/opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux- arch/arm64/Makefile:25: ld does not support --fix-cortex-a53-843419; kernel may be susceptible to erratum arch/arm64/Makefile:25: ld does not support --fix-cortex-a53-843419; kernel may be susceptible to erratum /kisskb/src/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14: Warning (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges" property but its #address-cells (1) differs from / (2) /kisskb/src/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14: Warning (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges" property but its #size-cells (1) differs from / (2) /kisskb/src/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14: Warning (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges" property but its #address-cells (1) differs from / (2) /kisskb/src/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14: Warning (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges" property but its #size-cells (1) differs from / (2) /kisskb/src/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14: Warning (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges" property but its #address-cells (1) differs from / (2) /kisskb/src/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14: Warning (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges" property but its #size-cells (1) differs from / (2) /kisskb/src/arch/arm64/boot/dts/qcom/ipq6018.dtsi:185.3-14: Warning (dma_ranges_format): /soc:dma-ranges: empty "dma-ranges" property but its #address-cells (1) differs from / (2) /kisskb/src/arch/arm64/boot/dts/qcom/ipq6018.dtsi:185.3-14: Warning (dma_ranges_format): /soc:dma-ranges: empty "dma-ranges" property but its #size-cells (1) differs from / (2) /kisskb/src/drivers/i2c/busses/i2c-mlxbf.c: In function 'mlxbf_i2c_acpi_probe': /kisskb/src/drivers/i2c/busses/i2c-mlxbf.c:2296:8: error: implicit declaration of function 'acpi_device_uid' [-Werror=implicit-function-declaration] uid = acpi_device_uid(adev); ^ /kisskb/src/drivers/i2c/busses/i2c-mlxbf.c:2296:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion] uid = acpi_device_uid(adev); ^ cc1: some warnings being treated as errors make[4]: *** [/kisskb/src/scripts/Makefile.build:283: drivers/i2c/busses/i2c-mlxbf.o] Error 1 make[3]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/i2c/busses] Error 2 make[2]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/i2c] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1799: drivers] Error 2 make: *** [Makefile:185: __sub-make] Error 2 Command 'make -s -j 8 ARCH=arm64 O=/kisskb/build/linus-rand_arm64-randconfig_arm64-gcc5.4 CROSS_COMPILE=/opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus-rand_arm64-randconfig_arm64-gcc5.4 # Build took: 0:05:14.395357