Buildresult: linus-rand/powerpc-randconfig/powerpc-gcc4.9 built on Oct 27 2020, 13:19

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Oct 27 2020, 13:19
Duration:	0:03:20.653224
Builder:	blade4b
Revision:	scsi: qla2xxx: remove incorrect sparse #ifdef (`4525c8781ec0701ce824e8bd379ae1b129e26568)`
Target:	linus-rand/powerpc-randconfig/powerpc-gcc4.9
Branch:	linus-rand
Compiler:	powerpc-gcc4.9 (powerpc64-linux-gcc (GCC) 4.9.4 / GNU ld (GNU Binutils) 2.29.1.20170915)
Config:	randconfig (download)
Log:	Download original Possible warnings (6) .config:3720:warning: override: reassigning to symbol PPC64 .config:3723:warning: override: reassigning to symbol PREVENT_FIRMWARE_BUILD arch/powerpc/kernel/eeh.c:1571:12: warning: 'proc_eeh_show' defined but not used [-Wunused-function] drivers/tty/serial/8250/8250_aspeed_vuart.c:497:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] drivers/usb/dwc2/platform.c:611:1: warning: label 'error_debugfs' defined but not used [-Wunused-label] drivers/usb/serial/ftdi_sio.c:1540:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] Full Log # git rev-parse -q --verify 4525c8781ec0701ce824e8bd379ae1b129e26568^{commit} 4525c8781ec0701ce824e8bd379ae1b129e26568 already have revision, skipping fetch # git checkout -q -f -B kisskb 4525c8781ec0701ce824e8bd379ae1b129e26568 # git clean -qxdf # < git log -1 # commit 4525c8781ec0701ce824e8bd379ae1b129e26568 # Author: Linus Torvalds <torvalds@linux-foundation.org> # Date: Mon Oct 26 15:45:22 2020 -0700 # # scsi: qla2xxx: remove incorrect sparse #ifdef # # The code to try to shut up sparse warnings about questionable locking # didn't shut up sparse: it made the result not parse as valid C at all, # since the end result now has a label with no statement. # # The proper fix is to just always lock the hardware, the same way Bart # did in commit 8ae178760b23 ("scsi: qla2xxx: Simplify the functions for # dumping firmware"). That avoids the whole problem with having locking # that is not statically obvious. # # But in the meantime, just remove the incorrect attempt at trying to # avoid a sparse warning that just made things worse. # # This was exposed by commit 3e6efab865ac ("scsi: qla2xxx: Fix reset of # MPI firmware"), very similarly to how commit cbb01c2f2f63 ("scsi: # qla2xxx: Fix MPI failure AEN (8200) handling") exposed the same problem # in another place, and caused that commit 8ae178760b23. # # Please don't add code to just shut up sparse without actually fixing # what sparse complains about. # # Reported-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> # Cc: Bart Van Assche <bvanassche@acm.org> # Cc: Arun Easi <aeasi@marvell.com> # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 4525c8781ec0701ce824e8bd379ae1b129e26568 # < make -s -j 24 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- randconfig KCONFIG_SEED=0x2D06C91C # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # Added to kconfig CONFIG_TRIM_UNUSED_KSYMS=n # Added to kconfig CONFIG_UBSAN=n # < make -s -j 24 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 24 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:3720:warning: override: reassigning to symbol PPC64 .config:3723:warning: override: reassigning to symbol PREVENT_FIRMWARE_BUILD # make -s -j 24 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/arch/powerpc/kernel/eeh.c:1571:12: warning: 'proc_eeh_show' defined but not used [-Wunused-function] static int proc_eeh_show(struct seq_file m, void v) ^ /kisskb/src/drivers/tty/serial/8250/8250_aspeed_vuart.c: In function 'aspeed_vuart_probe': /kisskb/src/drivers/tty/serial/8250/8250_aspeed_vuart.c:497:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ /kisskb/src/drivers/usb/dwc2/platform.c: In function 'dwc2_driver_probe': /kisskb/src/drivers/usb/dwc2/platform.c:611:1: warning: label 'error_debugfs' defined but not used [-Wunused-label] error_debugfs: ^ /kisskb/src/drivers/usb/serial/ftdi_sio.c: In function 'set_serial_info': /kisskb/src/drivers/usb/serial/ftdi_sio.c:1540:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ Completed OK # rm -rf /kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc4.9 # Build took: 0:03:20.653224

© Michael Ellerman 2006-2018.