# git rev-parse -q --verify 2d83b0f30c1483a556c8aa1f7d891006fffcd5e0^{commit} 2d83b0f30c1483a556c8aa1f7d891006fffcd5e0 already have revision, skipping fetch # git checkout -q -f -B kisskb 2d83b0f30c1483a556c8aa1f7d891006fffcd5e0 # git clean -qxdf # < git log -1 # commit 2d83b0f30c1483a556c8aa1f7d891006fffcd5e0 # Author: Ard Biesheuvel # Date: Wed Oct 28 09:04:33 2020 +0100 # # powerpc: Avoid broken GCC __attribute__((optimize)) # # Commit 7053f80d9696 ("powerpc/64: Prevent stack protection in early # boot") introduced a couple of uses of __attribute__((optimize)) with # function scope, to disable the stack protector in some early boot # code. # # Unfortunately, and this is documented in the GCC man pages [0], # overriding function attributes for optimization is broken, and is only # supported for debug scenarios, not for production: the problem appears # to be that setting GCC -f flags using this method will cause it to # forget about some or all other optimization settings that have been # applied. # # So the only safe way to disable the stack protector is to disable it # for the entire source file. # # [0] https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html # # Fixes: 7053f80d9696 ("powerpc/64: Prevent stack protection in early boot") # Signed-off-by: Ard Biesheuvel # [mpe: Drop one remaining use of __nostackprotector, reported by snowpatch] # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20201028080433.26799-1-ardb@kernel.org # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 2d83b0f30c1483a556c8aa1f7d891006fffcd5e0 # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- randconfig KCONFIG_SEED=0x6044FBBC # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # Added to kconfig CONFIG_TRIM_UNUSED_KSYMS=n # Added to kconfig CONFIG_UBSAN=n # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:4719:warning: override: reassigning to symbol STANDALONE .config:4724:warning: override: reassigning to symbol PPC_DISABLE_WERROR # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/arch/powerpc/kernel/iommu.c:136:30: warning: 'fail_iommu_bus_notifier' defined but not used [-Wunused-variable] 136 | static struct notifier_block fail_iommu_bus_notifier = { | ^~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/md/dm-writecache.c: In function 'persistent_memory_claim': /kisskb/src/drivers/md/dm-writecache.c:323:1: error: no return statement in function returning non-void [-Werror=return-type] 323 | } | ^ cc1: some warnings being treated as errors make[3]: *** [/kisskb/src/scripts/Makefile.build:283: drivers/md/dm-writecache.o] Error 1 make[2]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/md] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1799: drivers] Error 2 make: *** [Makefile:185: __sub-make] Error 2 Command 'make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc9 # Build took: 0:03:05.696225