# git rev-parse -q --verify f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1^{commit} f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1 already have revision, skipping fetch # git checkout -q -f -B kisskb f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1 # git clean -qxdf # < git log -1 # commit f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1 # Merge: d9315f5634c9 9b8523423b23 # Author: Linus Torvalds # Date: Fri Nov 13 16:07:53 2020 -0800 # # Merge tag 'vfs-5.10-fixes-2' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux # # Pull fs freeze fix and cleanups from Darrick Wong: # "A single vfs fix for 5.10, along with two subsequent cleanups. # # A very long time ago, a hack was added to the vfs fs freeze protection # code to work around lockdep complaints about XFS, which would try to # run a transaction (which requires intwrite protection) to finalize an # xfs freeze (by which time the vfs had already taken intwrite). # # Fast forward a few years, and XFS fixed the recursive intwrite problem # on its own, and the hack became unnecessary. Fast forward almost a # decade, and latent bugs in the code converting this hack from freeze # flags to freeze locks combine with lockdep bugs to make this reproduce # frequently enough to notice page faults racing with freeze. # # Since the hack is unnecessary and causes thread race errors, just get # rid of it completely. Making this kind of vfs change midway through a # cycle makes me nervous, but a large enough number of the usual # VFS/ext4/XFS/btrfs suspects have said this looks good and solves a # real problem vector. # # And once that removal is done, __sb_start_write is now simple enough # that it becomes possible to refactor the function into smaller, # simpler static inline helpers in linux/fs.h. The cleanup is # straightforward. # # Summary: # # - Finally remove the "convert to trylock" weirdness in the fs freezer # code. It was necessary 10 years ago to deal with nested # transactions in XFS, but we've long since removed that; and now # this is causing subtle race conditions when lockdep goes offline # and sb_start_* aren't prepared to retry a trylock failure. # # - Minor cleanups of the sb_start_* fs freeze helpers" # # * tag 'vfs-5.10-fixes-2' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux: # vfs: move __sb_{start,end}_write* to fs.h # vfs: separate __sb_start_write into blocking and non-blocking helpers # vfs: remove lockdep bogosity in __sb_start_write # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/s390-linux/bin/s390-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/s390-linux/bin/s390-linux-ld --version # < git log --format=%s --max-count=1 f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1 # < make -s -j 48 ARCH=s390 O=/kisskb/build/linus_s390-allmodconfig_s390x-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/s390-linux/bin/s390-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # < make -s -j 48 ARCH=s390 O=/kisskb/build/linus_s390-allmodconfig_s390x-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/s390-linux/bin/s390-linux- help # make -s -j 48 ARCH=s390 O=/kisskb/build/linus_s390-allmodconfig_s390x-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/s390-linux/bin/s390-linux- olddefconfig # make -s -j 48 ARCH=s390 O=/kisskb/build/linus_s390-allmodconfig_s390x-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/s390-linux/bin/s390-linux- /kisskb/src/drivers/input/joystick/analog.c:160:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp] #warning Precise timer not defined for this architecture. ^~~~~~~ /kisskb/src/drivers/media/platform/marvell-ccic/mmp-driver.c:324:12: warning: 'mmpcam_runtime_suspend' defined but not used [-Wunused-function] static int mmpcam_runtime_suspend(struct device *dev) ^~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/media/platform/marvell-ccic/mmp-driver.c:310:12: warning: 'mmpcam_runtime_resume' defined but not used [-Wunused-function] static int mmpcam_runtime_resume(struct device *dev) ^~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/gpu/drm/rockchip/cdn-dp-core.c:1124:12: warning: 'cdn_dp_resume' defined but not used [-Wunused-function] static int cdn_dp_resume(struct device *dev) ^~~~~~~~~~~~~ In file included from /kisskb/src/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:42: /kisskb/src/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c: In function 'mvpp2_setup_bm_pool': /kisskb/src/drivers/net/ethernet/marvell/mvpp2/mvpp2.h:760:2: warning: overflow in conversion from 'long unsigned int' to 'int' changes value from '18446744073709551584' to '-32' [-Woverflow] ((total_size) - MVPP2_SKB_HEADROOM - MVPP2_SKB_SHINFO_SIZE) ^ /kisskb/src/drivers/net/ethernet/marvell/mvpp2/mvpp2.h:864:33: note: in expansion of macro 'MVPP2_RX_MAX_PKT_SIZE' #define MVPP2_BM_SHORT_PKT_SIZE MVPP2_RX_MAX_PKT_SIZE(MVPP2_BM_SHORT_FRAME_SIZE) ^~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:647:41: note: in expansion of macro 'MVPP2_BM_SHORT_PKT_SIZE' mvpp2_pools[MVPP2_BM_SHORT].pkt_size = MVPP2_BM_SHORT_PKT_SIZE; ^~~~~~~~~~~~~~~~~~~~~~~ Completed OK # rm -rf /kisskb/build/linus_s390-allmodconfig_s390x-gcc8 # Build took: 0:19:21.062931