# git rev-parse -q --verify 01b0f0eae0812e80efeee4ee17687e5386335e08^{commit} 01b0f0eae0812e80efeee4ee17687e5386335e08 already have revision, skipping fetch # git checkout -q -f -B kisskb 01b0f0eae0812e80efeee4ee17687e5386335e08 # git clean -qxdf # < git log -1 # commit 01b0f0eae0812e80efeee4ee17687e5386335e08 # Author: Nicholas Piggin # Date: Thu Nov 26 20:25:30 2020 +1000 # # powerpc/64s: Trim offlined CPUs from mm_cpumasks # # When offlining a CPU, powerpc/64s does not flush TLBs, rather it just # leaves the CPU set in mm_cpumasks, so it continues to receive TLBIEs # to manage its TLBs. # # However the exit_flush_lazy_tlbs() function expects that after # returning, all CPUs (except self) have flushed TLBs for that mm, in # which case TLBIEL can be used for this flush. This breaks for offline # CPUs because they don't get the IPI to flush their TLB. This can lead # to stale translations. # # Fix this by clearing the CPU from mm_cpumasks, then flushing all TLBs # before going offline. # # These offlined CPU bits stuck in the cpumask also prevents the cpumask # from being trimmed back to local mode, which means continual broadcast # IPIs or TLBIEs are needed for TLB flushing. This patch prevents that # situation too. # # A cast of many were involved in working this out, but in particular # Milton, Aneesh, Paul made key discoveries. # # Fixes: 0cef77c7798a7 ("powerpc/64s/radix: flush remote CPUs out of single-threaded mm_cpumask") # Signed-off-by: Nicholas Piggin # Reviewed-by: Aneesh Kumar K.V # Debugged-by: Milton Miller # Debugged-by: Aneesh Kumar K.V # Debugged-by: Paul Mackerras # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20201126102530.691335-5-npiggin@gmail.com # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 01b0f0eae0812e80efeee4ee17687e5386335e08 # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc83xx_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc83xx_defconfig # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc83xx_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc83xx_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc83xx_defconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/block/genhd.c: In function 'diskstats_show': /kisskb/src/block/genhd.c:1659:1: warning: the frame size of 1160 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ INFO: Uncompressed kernel (size 0x7a0988) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x800000) INFO: Uncompressed kernel (size 0x7a0988) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x800000) INFO: Uncompressed kernel (size 0x7a0988) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x800000) INFO: Uncompressed kernel (size 0x7a0988) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x800000) INFO: Uncompressed kernel (size 0x7a0988) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x800000) INFO: Uncompressed kernel (size 0x7a0988) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x800000) INFO: Uncompressed kernel (size 0x7902a0) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x800000) INFO: Uncompressed kernel (size 0x7a0988) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x800000) Image Name: Linux-5.10.0-rc2-65324-g01b0f0ea Created: Fri Nov 27 01:43:38 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3568448 Bytes = 3484.81 KiB = 3.40 MiB Load Address: 00000000 Entry Point: 00000000 Image Name: Linux-5.10.0-rc2-65324-g01b0f0ea Created: Fri Nov 27 01:43:39 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3599302 Bytes = 3514.94 KiB = 3.43 MiB Load Address: 00800000 Entry Point: 00800294 Image Name: Linux-5.10.0-rc2-65324-g01b0f0ea Created: Fri Nov 27 01:43:39 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3598782 Bytes = 3514.44 KiB = 3.43 MiB Load Address: 00800000 Entry Point: 00800294 Image Name: Linux-5.10.0-rc2-65324-g01b0f0ea Created: Fri Nov 27 01:43:39 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3598585 Bytes = 3514.24 KiB = 3.43 MiB Load Address: 00800000 Entry Point: 00800294 Image Name: Linux-5.10.0-rc2-65324-g01b0f0ea Created: Fri Nov 27 01:43:39 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3598517 Bytes = 3514.18 KiB = 3.43 MiB Load Address: 00800000 Entry Point: 00800294 Image Name: Linux-5.10.0-rc2-65324-g01b0f0ea Created: Fri Nov 27 01:43:39 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3598997 Bytes = 3514.65 KiB = 3.43 MiB Load Address: 00800000 Entry Point: 00800294 Image Name: Linux-5.10.0-rc2-65324-g01b0f0ea Created: Fri Nov 27 01:43:39 2020 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3598829 Bytes = 3514.48 KiB = 3.43 MiB Load Address: 00800000 Entry Point: 00800294 Completed OK # rm -rf /kisskb/build/powerpc-fixes_mpc83xx_defconfig_powerpc-gcc4.9 # Build took: 0:00:55.265735