# git rev-parse -q --verify 4cb682964706deffb4861f0a91329ab3a705039f^{commit} 4cb682964706deffb4861f0a91329ab3a705039f already have revision, skipping fetch # git checkout -q -f -B kisskb 4cb682964706deffb4861f0a91329ab3a705039f # git clean -qxdf # < git log -1 # commit 4cb682964706deffb4861f0a91329ab3a705039f # Author: David Howells # Date: Tue Dec 8 23:52:03 2020 +0000 # # afs: Fix memory leak when mounting with multiple source parameters # # There's a memory leak in afs_parse_source() whereby multiple source= # parameters overwrite fc->source in the fs_context struct without freeing # the previously recorded source. # # Fix this by only permitting a single source parameter and rejecting with # an error all subsequent ones. # # This was caught by syzbot with the kernel memory leak detector, showing # something like the following trace: # # unreferenced object 0xffff888114375440 (size 32): # comm "repro", pid 5168, jiffies 4294923723 (age 569.948s) # backtrace: # slab_post_alloc_hook+0x42/0x79 # __kmalloc_track_caller+0x125/0x16a # kmemdup_nul+0x24/0x3c # vfs_parse_fs_string+0x5a/0xa1 # generic_parse_monolithic+0x9d/0xc5 # do_new_mount+0x10d/0x15a # do_mount+0x5f/0x8e # __do_sys_mount+0xff/0x127 # do_syscall_64+0x2d/0x3a # entry_SYSCALL_64_after_hwframe+0x44/0xa9 # # Fixes: 13fcc6837049 ("afs: Add fs_context support") # Reported-by: syzbot+86dc6632faaca40133ab@syzkaller.appspotmail.com # Signed-off-by: David Howells # cc: Randy Dunlap # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux-ld --version # < git log --format=%s --max-count=1 4cb682964706deffb4861f0a91329ab3a705039f # < make -s -j 10 ARCH=m68k O=/kisskb/build/linus_sun3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- sun3_defconfig WARNING: unmet direct dependencies detected for NEED_MULTIPLE_NODES Depends on [n]: DISCONTIGMEM [=n] || NUMA Selected by [y]: - SINGLE_MEMORY_CHUNK [=y] && MMU [=y] WARNING: unmet direct dependencies detected for NEED_MULTIPLE_NODES Depends on [n]: DISCONTIGMEM [=n] || NUMA Selected by [y]: - SINGLE_MEMORY_CHUNK [=y] && MMU [=y] # make -s -j 10 ARCH=m68k O=/kisskb/build/linus_sun3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/m68k-linux/bin/m68k-linux- In file included from /kisskb/src/kernel/rcu/update.c:578: /kisskb/src/kernel/rcu/tasks.h:710:13: warning: 'show_rcu_tasks_rude_gp_kthread' defined but not used [-Wunused-function] static void show_rcu_tasks_rude_gp_kthread(void) {} ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /kisskb/src/arch/m68k/include/asm/atomic.h:7, from /kisskb/src/include/linux/atomic.h:7, from /kisskb/src/include/linux/cpumask.h:13, from /kisskb/src/include/linux/smp.h:13, from /kisskb/src/include/linux/lockdep.h:14, from /kisskb/src/include/linux/spinlock.h:59, from /kisskb/src/include/linux/wait.h:9, from /kisskb/src/include/linux/wait_bit.h:8, from /kisskb/src/include/linux/fs.h:6, from /kisskb/src/fs/ocfs2/file.c:13: /kisskb/src/fs/ocfs2/file.c: In function 'ocfs2_file_write_iter': /kisskb/src/arch/m68k/include/asm/cmpxchg.h:79:22: warning: value computed is not used [-Wunused-value] #define xchg(ptr,x) ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr)))) ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/fs/ocfs2/file.c:2419:3: note: in expansion of macro 'xchg' xchg(&iocb->ki_complete, saved_ki_complete); ^~~~ Completed OK # rm -rf /kisskb/build/linus_sun3_defconfig_m68k-gcc8 # Build took: 0:02:36.991946