# git rev-parse -q --verify 4cb682964706deffb4861f0a91329ab3a705039f^{commit}
4cb682964706deffb4861f0a91329ab3a705039f
already have revision, skipping fetch
# git checkout -q -f -B kisskb 4cb682964706deffb4861f0a91329ab3a705039f
# git clean -qxdf
# < git log -1
# commit 4cb682964706deffb4861f0a91329ab3a705039f
# Author: David Howells <dhowells@redhat.com>
# Date:   Tue Dec 8 23:52:03 2020 +0000
# 
#     afs: Fix memory leak when mounting with multiple source parameters
#     
#     There's a memory leak in afs_parse_source() whereby multiple source=
#     parameters overwrite fc->source in the fs_context struct without freeing
#     the previously recorded source.
#     
#     Fix this by only permitting a single source parameter and rejecting with
#     an error all subsequent ones.
#     
#     This was caught by syzbot with the kernel memory leak detector, showing
#     something like the following trace:
#     
#       unreferenced object 0xffff888114375440 (size 32):
#         comm "repro", pid 5168, jiffies 4294923723 (age 569.948s)
#         backtrace:
#           slab_post_alloc_hook+0x42/0x79
#           __kmalloc_track_caller+0x125/0x16a
#           kmemdup_nul+0x24/0x3c
#           vfs_parse_fs_string+0x5a/0xa1
#           generic_parse_monolithic+0x9d/0xc5
#           do_new_mount+0x10d/0x15a
#           do_mount+0x5f/0x8e
#           __do_sys_mount+0xff/0x127
#           do_syscall_64+0x2d/0x3a
#           entry_SYSCALL_64_after_hwframe+0x44/0xa9
#     
#     Fixes: 13fcc6837049 ("afs: Add fs_context support")
#     Reported-by: syzbot+86dc6632faaca40133ab@syzkaller.appspotmail.com
#     Signed-off-by: David Howells <dhowells@redhat.com>
#     cc: Randy Dunlap <rdunlap@infradead.org>
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux-gcc --version
# < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux-ld --version
# < git log --format=%s --max-count=1 4cb682964706deffb4861f0a91329ab3a705039f
# < make -s -j 8 ARCH=ia64 O=/kisskb/build/linus_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux-  defconfig
arch/ia64/configs/generic_defconfig:58:warning: override: reassigning to symbol ATA
arch/ia64/configs/generic_defconfig:59:warning: override: reassigning to symbol ATA_PIIX
# < make -s -j 8 ARCH=ia64 O=/kisskb/build/linus_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux-  help
# make -s -j 8 ARCH=ia64 O=/kisskb/build/linus_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux-  olddefconfig
# make -s -j 8 ARCH=ia64 O=/kisskb/build/linus_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux-  
<stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
In file included from /kisskb/src/arch/ia64/include/uapi/asm/intrinsics.h:22:0,
                 from /kisskb/src/arch/ia64/include/asm/intrinsics.h:11,
                 from /kisskb/src/arch/ia64/include/asm/timex.h:14,
                 from /kisskb/src/include/linux/timex.h:65,
                 from /kisskb/src/include/linux/time32.h:13,
                 from /kisskb/src/include/linux/time.h:73,
                 from /kisskb/src/fs/nfs/read.c:11:
/kisskb/src/fs/nfs/read.c: In function 'nfs_read_completion':
/kisskb/src/arch/ia64/include/uapi/asm/cmpxchg.h:57:2: warning: value computed is not used [-Wunused-value]
 ((__typeof__(*(ptr))) __xchg((unsigned long) (x), (ptr), sizeof(*(ptr))))
  ^
/kisskb/src/fs/nfs/read.c:196:5: note: in expansion of macro 'xchg'
     xchg(&nfs_req_openctx(req)->error, error);
     ^
/kisskb/src/fs/nfs/read.c: In function 'nfs_readpage':
/kisskb/src/arch/ia64/include/uapi/asm/cmpxchg.h:57:2: warning: value computed is not used [-Wunused-value]
 ((__typeof__(*(ptr))) __xchg((unsigned long) (x), (ptr), sizeof(*(ptr))))
  ^
/kisskb/src/fs/nfs/read.c:355:2: note: in expansion of macro 'xchg'
  xchg(&ctx->error, 0);
  ^
No errors detected in 22334 functions.
Completed OK
# rm -rf /kisskb/build/linus_ia64-defconfig_ia64-gcc4.9
# Build took: 0:03:36.403439