# git rev-parse -q --verify 4cb682964706deffb4861f0a91329ab3a705039f^{commit} 4cb682964706deffb4861f0a91329ab3a705039f already have revision, skipping fetch # git checkout -q -f -B kisskb 4cb682964706deffb4861f0a91329ab3a705039f # git clean -qxdf # < git log -1 # commit 4cb682964706deffb4861f0a91329ab3a705039f # Author: David Howells # Date: Tue Dec 8 23:52:03 2020 +0000 # # afs: Fix memory leak when mounting with multiple source parameters # # There's a memory leak in afs_parse_source() whereby multiple source= # parameters overwrite fc->source in the fs_context struct without freeing # the previously recorded source. # # Fix this by only permitting a single source parameter and rejecting with # an error all subsequent ones. # # This was caught by syzbot with the kernel memory leak detector, showing # something like the following trace: # # unreferenced object 0xffff888114375440 (size 32): # comm "repro", pid 5168, jiffies 4294923723 (age 569.948s) # backtrace: # slab_post_alloc_hook+0x42/0x79 # __kmalloc_track_caller+0x125/0x16a # kmemdup_nul+0x24/0x3c # vfs_parse_fs_string+0x5a/0xa1 # generic_parse_monolithic+0x9d/0xc5 # do_new_mount+0x10d/0x15a # do_mount+0x5f/0x8e # __do_sys_mount+0xff/0x127 # do_syscall_64+0x2d/0x3a # entry_SYSCALL_64_after_hwframe+0x44/0xa9 # # Fixes: 13fcc6837049 ("afs: Add fs_context support") # Reported-by: syzbot+86dc6632faaca40133ab@syzkaller.appspotmail.com # Signed-off-by: David Howells # cc: Randy Dunlap # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 4cb682964706deffb4861f0a91329ab3a705039f # < make -s -j 8 ARCH=powerpc O=/kisskb/build/linus_pmac32_defconfig+SMP_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- pmac32_defconfig # Added to kconfig CONFIG_SMP=y # < make -s -j 8 ARCH=powerpc O=/kisskb/build/linus_pmac32_defconfig+SMP_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 8 ARCH=powerpc O=/kisskb/build/linus_pmac32_defconfig+SMP_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:4119:warning: override: reassigning to symbol SMP # make -s -j 8 ARCH=powerpc O=/kisskb/build/linus_pmac32_defconfig+SMP_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/arch/powerpc/platforms/powermac/smp.c: In function 'smp_core99_cpu_disable': /kisskb/src/arch/powerpc/platforms/powermac/smp.c:914:2: error: implicit declaration of function 'cleanup_cpu_mmu_context' [-Werror=implicit-function-declaration] cleanup_cpu_mmu_context(); ^ cc1: all warnings being treated as errors make[4]: *** [/kisskb/src/scripts/Makefile.build:279: arch/powerpc/platforms/powermac/smp.o] Error 1 make[3]: *** [/kisskb/src/scripts/Makefile.build:496: arch/powerpc/platforms/powermac] Error 2 make[2]: *** [/kisskb/src/scripts/Makefile.build:496: arch/powerpc/platforms] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1805: arch/powerpc] Error 2 make[1]: *** Waiting for unfinished jobs.... /kisskb/src/block/genhd.c: In function 'diskstats_show': /kisskb/src/block/genhd.c:1662:1: warning: the frame size of 1168 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ make: *** [Makefile:185: __sub-make] Error 2 Command 'make -s -j 8 ARCH=powerpc O=/kisskb/build/linus_pmac32_defconfig+SMP_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_pmac32_defconfig+SMP_powerpc-gcc4.9 # Build took: 0:01:52.189042