# git rev-parse -q --verify 4025c784c573cab7e3f84746cc82b8033923ec62^{commit} 4025c784c573cab7e3f84746cc82b8033923ec62 already have revision, skipping fetch # git checkout -q -f -B kisskb 4025c784c573cab7e3f84746cc82b8033923ec62 # git clean -qxdf # < git log -1 # commit 4025c784c573cab7e3f84746cc82b8033923ec62 # Author: Nicholas Piggin # Date: Sat Jan 23 16:12:44 2021 +1000 # # powerpc/64s: prevent recursive replay_soft_interrupts causing superfluous interrupt # # When an asynchronous interrupt calls irq_exit, it checks for softirqs # that may have been created, and runs them. Running softirqs enables # local irqs, which can replay pending interrupts causing recursion in # replay_soft_interrupts. This abridged trace shows how this can occur: # # ! NIP replay_soft_interrupts # LR interrupt_exit_kernel_prepare # Call Trace: # interrupt_exit_kernel_prepare (unreliable) # interrupt_return # --- interrupt: ea0 at __rb_reserve_next # NIP __rb_reserve_next # LR __rb_reserve_next # Call Trace: # ring_buffer_lock_reserve # trace_function # function_trace_call # ftrace_call # __do_softirq # irq_exit # timer_interrupt # ! replay_soft_interrupts # interrupt_exit_kernel_prepare # interrupt_return # --- interrupt: ea0 at arch_local_irq_restore # # This can not be prevented easily, because softirqs must not block hard # irqs, so it has to be dealt with. # # The recursion is bounded by design in the softirq code because softirq # replay disables softirqs and loops around again to check for new # softirqs created while it ran, so that's not a problem. # # However it does mess up interrupt replay state, causing superfluous # interrupts when the second replay_soft_interrupts clears a pending # interrupt, leaving it still set in the first call in the 'happened' # local variable. # # Fix this by not caching a copy of irqs_happened across interrupt # handler calls. # # Fixes: 3282a3da25bd ("powerpc/64: Implement soft interrupt replay in C") # Signed-off-by: Nicholas Piggin # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20210123061244.2076145-1-npiggin@gmail.com # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux-ld --version # < git log --format=%s --max-count=1 4025c784c573cab7e3f84746cc82b8033923ec62 # < make -s -j 32 ARCH=ia64 O=/kisskb/build/powerpc-fixes_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux- defconfig arch/ia64/configs/generic_defconfig:58:warning: override: reassigning to symbol ATA arch/ia64/configs/generic_defconfig:59:warning: override: reassigning to symbol ATA_PIIX # < make -s -j 32 ARCH=ia64 O=/kisskb/build/powerpc-fixes_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux- help # make -s -j 32 ARCH=ia64 O=/kisskb/build/powerpc-fixes_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux- olddefconfig # make -s -j 32 ARCH=ia64 O=/kisskb/build/powerpc-fixes_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux- :1511:2: warning: #warning syscall clone3 not implemented [-Wcpp] In file included from /kisskb/src/include/linux/numa.h:25:0, from /kisskb/src/include/linux/nodemask.h:96, from /kisskb/src/lib/nodemask.c:2: /kisskb/src/arch/ia64/include/asm/sparsemem.h:14:40: warning: "PAGE_SHIFT" is not defined [-Wundef] #if ((CONFIG_FORCE_MAX_ZONEORDER - 1 + PAGE_SHIFT) > SECTION_SIZE_BITS) ^ In file included from /kisskb/src/include/linux/gfp.h:6:0, from /kisskb/src/include/linux/umh.h:4, from /kisskb/src/include/linux/kmod.h:9, from /kisskb/src/include/linux/module.h:16, from /kisskb/src/lib/nodemask.c:3: /kisskb/src/include/linux/mmzone.h:1156:2: error: #error Allocator MAX_ORDER exceeds SECTION_SIZE #error Allocator MAX_ORDER exceeds SECTION_SIZE ^ make[2]: *** [/kisskb/src/scripts/Makefile.build:279: lib/nodemask.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1805: lib] Error 2 make[1]: *** Waiting for unfinished jobs.... In file included from /kisskb/src/include/linux/numa.h:25:0, from /kisskb/src/include/linux/async.h:13, from /kisskb/src/kernel/async.c:47: /kisskb/src/arch/ia64/include/asm/sparsemem.h:14:40: warning: "PAGE_SHIFT" is not defined [-Wundef] #if ((CONFIG_FORCE_MAX_ZONEORDER - 1 + PAGE_SHIFT) > SECTION_SIZE_BITS) ^ In file included from /kisskb/src/include/linux/gfp.h:6:0, from /kisskb/src/include/linux/xarray.h:14, from /kisskb/src/include/linux/radix-tree.h:19, from /kisskb/src/include/linux/idr.h:15, from /kisskb/src/include/linux/kernfs.h:13, from /kisskb/src/include/linux/sysfs.h:16, from /kisskb/src/include/linux/kobject.h:20, from /kisskb/src/include/linux/energy_model.h:7, from /kisskb/src/include/linux/device.h:16, from /kisskb/src/include/linux/async.h:14, from /kisskb/src/kernel/async.c:47: /kisskb/src/include/linux/mmzone.h:1156:2: error: #error Allocator MAX_ORDER exceeds SECTION_SIZE #error Allocator MAX_ORDER exceeds SECTION_SIZE ^ make[2]: *** [/kisskb/src/scripts/Makefile.build:279: kernel/async.o] Error 1 make[2]: *** Waiting for unfinished jobs.... In file included from /kisskb/src/arch/ia64/include/uapi/asm/intrinsics.h:22:0, from /kisskb/src/arch/ia64/include/asm/intrinsics.h:11, from /kisskb/src/arch/ia64/include/asm/timex.h:14, from /kisskb/src/include/linux/timex.h:65, from /kisskb/src/include/linux/time32.h:13, from /kisskb/src/include/linux/time.h:60, from /kisskb/src/fs/nfs/read.c:11: /kisskb/src/fs/nfs/read.c: In function 'nfs_read_completion': /kisskb/src/arch/ia64/include/uapi/asm/cmpxchg.h:57:2: warning: value computed is not used [-Wunused-value] ((__typeof__(*(ptr))) __xchg((unsigned long) (x), (ptr), sizeof(*(ptr)))) ^ /kisskb/src/fs/nfs/read.c:196:5: note: in expansion of macro 'xchg' xchg(&nfs_req_openctx(req)->error, error); ^ /kisskb/src/fs/nfs/read.c: In function 'nfs_readpage': /kisskb/src/arch/ia64/include/uapi/asm/cmpxchg.h:57:2: warning: value computed is not used [-Wunused-value] ((__typeof__(*(ptr))) __xchg((unsigned long) (x), (ptr), sizeof(*(ptr)))) ^ /kisskb/src/fs/nfs/read.c:355:2: note: in expansion of macro 'xchg' xchg(&ctx->error, 0); ^ make[1]: *** [/kisskb/src/Makefile:1805: kernel] Error 2 In file included from /kisskb/src/include/linux/numa.h:25:0, from /kisskb/src/include/linux/async.h:13, from /kisskb/src/drivers/acpi/battery.c:13: /kisskb/src/arch/ia64/include/asm/sparsemem.h:14:40: warning: "PAGE_SHIFT" is not defined [-Wundef] #if ((CONFIG_FORCE_MAX_ZONEORDER - 1 + PAGE_SHIFT) > SECTION_SIZE_BITS) ^ In file included from /kisskb/src/include/linux/gfp.h:6:0, from /kisskb/src/include/linux/xarray.h:14, from /kisskb/src/include/linux/radix-tree.h:19, from /kisskb/src/include/linux/idr.h:15, from /kisskb/src/include/linux/kernfs.h:13, from /kisskb/src/include/linux/sysfs.h:16, from /kisskb/src/include/linux/kobject.h:20, from /kisskb/src/include/linux/energy_model.h:7, from /kisskb/src/include/linux/device.h:16, from /kisskb/src/include/linux/async.h:14, from /kisskb/src/drivers/acpi/battery.c:13: /kisskb/src/include/linux/mmzone.h:1156:2: error: #error Allocator MAX_ORDER exceeds SECTION_SIZE #error Allocator MAX_ORDER exceeds SECTION_SIZE ^ make[3]: *** [/kisskb/src/scripts/Makefile.build:279: drivers/acpi/battery.o] Error 1 make[3]: *** Waiting for unfinished jobs.... In file included from /kisskb/src/include/linux/numa.h:25:0, from /kisskb/src/include/linux/nodemask.h:96, from /kisskb/src/include/linux/mount.h:15, from /kisskb/src/fs/pnode.c:9: /kisskb/src/arch/ia64/include/asm/sparsemem.h:14:40: warning: "PAGE_SHIFT" is not defined [-Wundef] #if ((CONFIG_FORCE_MAX_ZONEORDER - 1 + PAGE_SHIFT) > SECTION_SIZE_BITS) ^ In file included from /kisskb/src/include/linux/gfp.h:6:0, from /kisskb/src/include/linux/xarray.h:14, from /kisskb/src/include/linux/radix-tree.h:19, from /kisskb/src/include/linux/fs.h:15, from /kisskb/src/fs/pnode.c:10: /kisskb/src/include/linux/mmzone.h:1156:2: error: #error Allocator MAX_ORDER exceeds SECTION_SIZE #error Allocator MAX_ORDER exceeds SECTION_SIZE ^ make[2]: *** [/kisskb/src/scripts/Makefile.build:279: fs/pnode.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1805: fs] Error 2 In file included from /kisskb/src/include/linux/numa.h:25:0, from /kisskb/src/include/linux/async.h:13, from /kisskb/src/drivers/base/bus.c:11: /kisskb/src/arch/ia64/include/asm/sparsemem.h:14:40: warning: "PAGE_SHIFT" is not defined [-Wundef] #if ((CONFIG_FORCE_MAX_ZONEORDER - 1 + PAGE_SHIFT) > SECTION_SIZE_BITS) ^ In file included from /kisskb/src/include/linux/gfp.h:6:0, from /kisskb/src/include/linux/xarray.h:14, from /kisskb/src/include/linux/radix-tree.h:19, from /kisskb/src/include/linux/idr.h:15, from /kisskb/src/include/linux/kernfs.h:13, from /kisskb/src/include/linux/sysfs.h:16, from /kisskb/src/include/linux/kobject.h:20, from /kisskb/src/include/linux/energy_model.h:7, from /kisskb/src/include/linux/device.h:16, from /kisskb/src/include/linux/async.h:14, from /kisskb/src/drivers/base/bus.c:11: /kisskb/src/include/linux/mmzone.h:1156:2: error: #error Allocator MAX_ORDER exceeds SECTION_SIZE #error Allocator MAX_ORDER exceeds SECTION_SIZE ^ make[3]: *** [/kisskb/src/scripts/Makefile.build:279: drivers/base/bus.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:496: drivers/acpi] Error 2 make[2]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:496: drivers/base] Error 2 make[1]: *** [/kisskb/src/Makefile:1805: drivers] Error 2 make: *** [Makefile:185: __sub-make] Error 2 Command 'make -s -j 32 ARCH=ia64 O=/kisskb/build/powerpc-fixes_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/powerpc-fixes_ia64-defconfig_ia64-gcc4.9 # Build took: 0:01:52.681770