# git rev-parse -q --verify f8ad8187c3b536ee2b10502a8340c014204a1af0^{commit} f8ad8187c3b536ee2b10502a8340c014204a1af0 already have revision, skipping fetch # git checkout -q -f -B kisskb f8ad8187c3b536ee2b10502a8340c014204a1af0 # git clean -qxdf # < git log -1 # commit f8ad8187c3b536ee2b10502a8340c014204a1af0 # Author: Johannes Berg # Date: Mon Jan 25 10:16:15 2021 +0100 # # fs/pipe: allow sendfile() to pipe again # # After commit 36e2c7421f02 ("fs: don't allow splice read/write # without explicit ops") sendfile() could no longer send data # from a real file to a pipe, breaking for example certain cgit # setups (e.g. when running behind fcgiwrap), because in this # case cgit will try to do exactly this: sendfile() to a pipe. # # Fix this by using iter_file_splice_write for the splice_write # method of pipes, as suggested by Christoph. # # Cc: stable@vger.kernel.org # Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops") # Suggested-by: Christoph Hellwig # Reviewed-by: Christoph Hellwig # Tested-by: Johannes Berg # Signed-off-by: Johannes Berg # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 f8ad8187c3b536ee2b10502a8340c014204a1af0 # < make -s -j 8 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- randconfig KCONFIG_SEED=0xB811A972 # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # Added to kconfig CONFIG_TRIM_UNUSED_KSYMS=n # Added to kconfig CONFIG_UBSAN=n # < make -s -j 8 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 8 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:3762:warning: override: reassigning to symbol STANDALONE .config:3764:warning: override: reassigning to symbol MODULE_SIG .config:3766:warning: override: reassigning to symbol PPC64 .config:3767:warning: override: reassigning to symbol PPC_DISABLE_WERROR .config:3768:warning: override: reassigning to symbol SECTION_MISMATCH_WARN_ONLY .config:3769:warning: override: reassigning to symbol PREVENT_FIRMWARE_BUILD # make -s -j 8 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/arch/powerpc/kernel/eeh.c:1571:12: warning: 'proc_eeh_show' defined but not used [-Wunused-function] static int proc_eeh_show(struct seq_file *m, void *v) ^ In file included from :0:0: /kisskb/src/mm/mremap.c: In function 'get_extent': /kisskb/src/include/linux/compiler_types.h:320:38: error: call to '__compiletime_assert_305' declared with attribute error: BUILD_BUG failed _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:301:4: note: in definition of macro '__compiletime_assert' prefix ## suffix(); \ ^ /kisskb/src/include/linux/compiler_types.h:320:2: note: in expansion of macro '_compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ /kisskb/src/include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^ /kisskb/src/include/linux/build_bug.h:59:21: note: in expansion of macro 'BUILD_BUG_ON_MSG' #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed") ^ /kisskb/src/mm/mremap.c:355:3: note: in expansion of macro 'BUILD_BUG' BUILD_BUG(); ^ make[2]: *** [/kisskb/src/scripts/Makefile.build:279: mm/mremap.o] Error 1 make[1]: *** [/kisskb/src/Makefile:1805: mm] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:185: __sub-make] Error 2 Command 'make -s -j 8 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc4.9 # Build took: 0:01:25.307964