# git rev-parse -q --verify 24321ac668e452a4942598533d267805f291fdc9^{commit} 24321ac668e452a4942598533d267805f291fdc9 already have revision, skipping fetch # git checkout -q -f -B kisskb 24321ac668e452a4942598533d267805f291fdc9 # git clean -qxdf # < git log -1 # commit 24321ac668e452a4942598533d267805f291fdc9 # Author: Raoni Fassina Firmino # Date: Mon Feb 1 17:05:05 2021 -0300 # # powerpc/64/signal: Fix regression in __kernel_sigtramp_rt64() semantics # # Commit 0138ba5783ae ("powerpc/64/signal: Balance return predictor # stack in signal trampoline") changed __kernel_sigtramp_rt64() VDSO and # trampoline code, and introduced a regression in the way glibc's # backtrace()[1] detects the signal-handler stack frame. Apart from the # practical implications, __kernel_sigtramp_rt64() was a VDSO function # with the semantics that it is a function you can call from userspace # to end a signal handling. Now this semantics are no longer valid. # # I believe the aforementioned change affects all releases since 5.9. # # This patch tries to fix both the semantics and practical aspect of # __kernel_sigtramp_rt64() returning it to the previous code, whilst # keeping the intended behaviour of 0138ba5783ae by adding a new symbol # to serve as the jump target from the kernel to the trampoline. Now the # trampoline has two parts, a new entry point and the old return point. # # [1] https://lists.ozlabs.org/pipermail/linuxppc-dev/2021-January/223194.html # # Fixes: 0138ba5783ae ("powerpc/64/signal: Balance return predictor stack in signal trampoline") # Cc: stable@vger.kernel.org # v5.9+ # Signed-off-by: Raoni Fassina Firmino # Acked-by: Nicholas Piggin # [mpe: Minor tweaks to change log formatting, add stable tag] # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20210201200505.iz46ubcizipnkcxe@work-tp # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux-ld --version # < git log --format=%s --max-count=1 24321ac668e452a4942598533d267805f291fdc9 # < make -s -j 24 ARCH=ia64 O=/kisskb/build/powerpc-fixes_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux- defconfig arch/ia64/configs/generic_defconfig:58:warning: override: reassigning to symbol ATA arch/ia64/configs/generic_defconfig:59:warning: override: reassigning to symbol ATA_PIIX # < make -s -j 24 ARCH=ia64 O=/kisskb/build/powerpc-fixes_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux- help # make -s -j 24 ARCH=ia64 O=/kisskb/build/powerpc-fixes_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux- olddefconfig # make -s -j 24 ARCH=ia64 O=/kisskb/build/powerpc-fixes_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux- :1511:2: warning: #warning syscall clone3 not implemented [-Wcpp] In file included from /kisskb/src/include/linux/numa.h:25:0, from /kisskb/src/include/linux/nodemask.h:96, from /kisskb/src/lib/nodemask.c:2: /kisskb/src/arch/ia64/include/asm/sparsemem.h:14:40: warning: "PAGE_SHIFT" is not defined [-Wundef] #if ((CONFIG_FORCE_MAX_ZONEORDER - 1 + PAGE_SHIFT) > SECTION_SIZE_BITS) ^ In file included from /kisskb/src/include/linux/gfp.h:6:0, from /kisskb/src/include/linux/umh.h:4, from /kisskb/src/include/linux/kmod.h:9, from /kisskb/src/include/linux/module.h:16, from /kisskb/src/lib/nodemask.c:3: /kisskb/src/include/linux/mmzone.h:1156:2: error: #error Allocator MAX_ORDER exceeds SECTION_SIZE #error Allocator MAX_ORDER exceeds SECTION_SIZE ^ make[2]: *** [/kisskb/src/scripts/Makefile.build:279: lib/nodemask.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1805: lib] Error 2 make[1]: *** Waiting for unfinished jobs.... In file included from /kisskb/src/arch/ia64/include/uapi/asm/intrinsics.h:22:0, from /kisskb/src/arch/ia64/include/asm/intrinsics.h:11, from /kisskb/src/arch/ia64/include/asm/timex.h:14, from /kisskb/src/include/linux/timex.h:65, from /kisskb/src/include/linux/time32.h:13, from /kisskb/src/include/linux/time.h:60, from /kisskb/src/fs/nfs/read.c:11: /kisskb/src/fs/nfs/read.c: In function 'nfs_read_completion': /kisskb/src/arch/ia64/include/uapi/asm/cmpxchg.h:57:2: warning: value computed is not used [-Wunused-value] ((__typeof__(*(ptr))) __xchg((unsigned long) (x), (ptr), sizeof(*(ptr)))) ^ /kisskb/src/fs/nfs/read.c:196:5: note: in expansion of macro 'xchg' xchg(&nfs_req_openctx(req)->error, error); ^ /kisskb/src/fs/nfs/read.c: In function 'nfs_readpage': /kisskb/src/arch/ia64/include/uapi/asm/cmpxchg.h:57:2: warning: value computed is not used [-Wunused-value] ((__typeof__(*(ptr))) __xchg((unsigned long) (x), (ptr), sizeof(*(ptr)))) ^ /kisskb/src/fs/nfs/read.c:355:2: note: in expansion of macro 'xchg' xchg(&ctx->error, 0); ^ In file included from /kisskb/src/include/linux/numa.h:25:0, from /kisskb/src/include/linux/async.h:13, from /kisskb/src/kernel/async.c:47: /kisskb/src/arch/ia64/include/asm/sparsemem.h:14:40: warning: "PAGE_SHIFT" is not defined [-Wundef] #if ((CONFIG_FORCE_MAX_ZONEORDER - 1 + PAGE_SHIFT) > SECTION_SIZE_BITS) ^ In file included from /kisskb/src/include/linux/gfp.h:6:0, from /kisskb/src/include/linux/xarray.h:14, from /kisskb/src/include/linux/radix-tree.h:19, from /kisskb/src/include/linux/idr.h:15, from /kisskb/src/include/linux/kernfs.h:13, from /kisskb/src/include/linux/sysfs.h:16, from /kisskb/src/include/linux/kobject.h:20, from /kisskb/src/include/linux/energy_model.h:7, from /kisskb/src/include/linux/device.h:16, from /kisskb/src/include/linux/async.h:14, from /kisskb/src/kernel/async.c:47: /kisskb/src/include/linux/mmzone.h:1156:2: error: #error Allocator MAX_ORDER exceeds SECTION_SIZE #error Allocator MAX_ORDER exceeds SECTION_SIZE ^ make[2]: *** [/kisskb/src/scripts/Makefile.build:279: kernel/async.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1805: kernel] Error 2 In file included from /kisskb/src/include/linux/numa.h:25:0, from /kisskb/src/include/linux/async.h:13, from /kisskb/src/drivers/acpi/battery.c:13: /kisskb/src/arch/ia64/include/asm/sparsemem.h:14:40: warning: "PAGE_SHIFT" is not defined [-Wundef] #if ((CONFIG_FORCE_MAX_ZONEORDER - 1 + PAGE_SHIFT) > SECTION_SIZE_BITS) ^ In file included from /kisskb/src/include/linux/gfp.h:6:0, from /kisskb/src/include/linux/xarray.h:14, from /kisskb/src/include/linux/radix-tree.h:19, from /kisskb/src/include/linux/idr.h:15, from /kisskb/src/include/linux/kernfs.h:13, from /kisskb/src/include/linux/sysfs.h:16, from /kisskb/src/include/linux/kobject.h:20, from /kisskb/src/include/linux/energy_model.h:7, from /kisskb/src/include/linux/device.h:16, from /kisskb/src/include/linux/async.h:14, from /kisskb/src/drivers/acpi/battery.c:13: /kisskb/src/include/linux/mmzone.h:1156:2: error: #error Allocator MAX_ORDER exceeds SECTION_SIZE #error Allocator MAX_ORDER exceeds SECTION_SIZE ^ make[3]: *** [/kisskb/src/scripts/Makefile.build:279: drivers/acpi/battery.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:496: drivers/acpi] Error 2 make[2]: *** Waiting for unfinished jobs.... In file included from /kisskb/src/include/linux/numa.h:25:0, from /kisskb/src/include/linux/async.h:13, from /kisskb/src/drivers/base/bus.c:11: /kisskb/src/arch/ia64/include/asm/sparsemem.h:14:40: warning: "PAGE_SHIFT" is not defined [-Wundef] #if ((CONFIG_FORCE_MAX_ZONEORDER - 1 + PAGE_SHIFT) > SECTION_SIZE_BITS) ^ In file included from /kisskb/src/include/linux/gfp.h:6:0, from /kisskb/src/include/linux/xarray.h:14, from /kisskb/src/include/linux/radix-tree.h:19, from /kisskb/src/include/linux/idr.h:15, from /kisskb/src/include/linux/kernfs.h:13, from /kisskb/src/include/linux/sysfs.h:16, from /kisskb/src/include/linux/kobject.h:20, from /kisskb/src/include/linux/energy_model.h:7, from /kisskb/src/include/linux/device.h:16, from /kisskb/src/include/linux/async.h:14, from /kisskb/src/drivers/base/bus.c:11: /kisskb/src/include/linux/mmzone.h:1156:2: error: #error Allocator MAX_ORDER exceeds SECTION_SIZE #error Allocator MAX_ORDER exceeds SECTION_SIZE ^ make[3]: *** [/kisskb/src/scripts/Makefile.build:279: drivers/base/bus.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:496: drivers/base] Error 2 In file included from /kisskb/src/include/linux/numa.h:25:0, from /kisskb/src/include/linux/nodemask.h:96, from /kisskb/src/include/linux/mount.h:15, from /kisskb/src/fs/pnode.c:9: /kisskb/src/arch/ia64/include/asm/sparsemem.h:14:40: warning: "PAGE_SHIFT" is not defined [-Wundef] #if ((CONFIG_FORCE_MAX_ZONEORDER - 1 + PAGE_SHIFT) > SECTION_SIZE_BITS) ^ In file included from /kisskb/src/include/linux/gfp.h:6:0, from /kisskb/src/include/linux/xarray.h:14, from /kisskb/src/include/linux/radix-tree.h:19, from /kisskb/src/include/linux/fs.h:15, from /kisskb/src/fs/pnode.c:10: /kisskb/src/include/linux/mmzone.h:1156:2: error: #error Allocator MAX_ORDER exceeds SECTION_SIZE #error Allocator MAX_ORDER exceeds SECTION_SIZE ^ make[2]: *** [/kisskb/src/scripts/Makefile.build:279: fs/pnode.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1805: fs] Error 2 make[1]: *** [/kisskb/src/Makefile:1805: drivers] Error 2 make: *** [Makefile:185: __sub-make] Error 2 Command 'make -s -j 24 ARCH=ia64 O=/kisskb/build/powerpc-fixes_ia64-defconfig_ia64-gcc4.9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-4.9.4-nolibc/ia64-linux/bin/ia64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/powerpc-fixes_ia64-defconfig_ia64-gcc4.9 # Build took: 0:02:03.586869