# git rev-parse -q --verify 6a86fe746e2f69e49328b9ad8ad0f840c467ee59^{commit} 6a86fe746e2f69e49328b9ad8ad0f840c467ee59 already have revision, skipping fetch # git checkout -q -f -B kisskb 6a86fe746e2f69e49328b9ad8ad0f840c467ee59 # git clean -qxdf # < git log -1 # commit 6a86fe746e2f69e49328b9ad8ad0f840c467ee59 # Author: Michael Ellerman # Date: Thu Feb 18 23:30:58 2021 +1100 # # powerpc/4xx: Fix build errors from mfdcr() # # lkp reported a build error in fsp2.o: # # CC arch/powerpc/platforms/44x/fsp2.o # {standard input}:577: Error: unsupported relocation against base # # Which comes from: # # pr_err("GESR0: 0x%08x\n", mfdcr(base + PLB4OPB_GESR0)); # # Where our mfdcr() macro is stringifying "base + PLB4OPB_GESR0", and # passing that to the assembler, which obviously doesn't work. # # The mfdcr() macro already checks that the argument is constant using # __builtin_constant_p(), and if not calls the out-of-line version of # mfdcr(). But in this case GCC is smart enough to notice that "base + # PLB4OPB_GESR0" will be constant, even though it's not something we can # immediately stringify into a register number. # # Segher pointed out that passing the register number to the inline asm # as a constant would be better, and in fact it fixes the build error, # presumably because it gives GCC a chance to resolve the value. # # While we're at it, change mtdcr() similarly. # # Reported-by: kernel test robot # Suggested-by: Segher Boessenkool # Signed-off-by: Michael Ellerman # Acked-by: Feng Tang # Link: https://lore.kernel.org/r/20210218123058.748882-1-mpe@ellerman.id.au # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 6a86fe746e2f69e49328b9ad8ad0f840c467ee59 # < make -s -j 10 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powernv_defconfig+NO_PERF_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- powernv_defconfig # Added to kconfig CONFIG_PERF_EVENTS=n # < make -s -j 10 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powernv_defconfig+NO_PERF_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 10 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powernv_defconfig+NO_PERF_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 10 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powernv_defconfig+NO_PERF_powerpc-gcc9 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-9.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/drivers/net/phy/phy_device.c:293:12: warning: 'mdio_bus_phy_resume' defined but not used [-Wunused-function] 293 | static int mdio_bus_phy_resume(struct device *dev) | ^~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/net/phy/phy_device.c:273:12: warning: 'mdio_bus_phy_suspend' defined but not used [-Wunused-function] 273 | static int mdio_bus_phy_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~ Completed OK # rm -rf /kisskb/build/powerpc-fixes_powernv_defconfig+NO_PERF_powerpc-gcc9 # Build took: 0:04:41.218023