# git rev-parse -q --verify e3d773ddb5a1140780a15703b3e0e2618274cce9^{commit} e3d773ddb5a1140780a15703b3e0e2618274cce9 already have revision, skipping fetch # git checkout -q -f -B kisskb e3d773ddb5a1140780a15703b3e0e2618274cce9 # git clean -qxdf # < git log -1 # commit e3d773ddb5a1140780a15703b3e0e2618274cce9 # Author: Jordan Niethe # Date: Thu Feb 25 14:19:46 2021 +1100 # # powerpc/sstep: Fix VSX instruction emulation # # Commit af99da74333b ("powerpc/sstep: Support VSX vector paired storage # access instructions") added loading and storing 32 word long data into # adjacent VSRs. However the calculation used to determine if two VSRs # needed to be loaded/stored inadvertently prevented the load/storing # taking place for instructions with a data length less than 16 words. # # This causes the emulation to not function correctly, which can be seen # by the alignment_handler selftest: # # $ ./alignment_handler # [snip] # test: test_alignment_handler_vsx_207 # tags: git_version:powerpc-5.12-1-0-g82d2c16b350f # VSX: 2.07B # Doing lxsspx: PASSED # Doing lxsiwax: FAILED: Wrong Data # Doing lxsiwzx: PASSED # Doing stxsspx: PASSED # Doing stxsiwx: PASSED # failure: test_alignment_handler_vsx_207 # test: test_alignment_handler_vsx_300 # tags: git_version:powerpc-5.12-1-0-g82d2c16b350f # VSX: 3.00B # Doing lxsd: PASSED # Doing lxsibzx: PASSED # Doing lxsihzx: PASSED # Doing lxssp: FAILED: Wrong Data # Doing lxv: PASSED # Doing lxvb16x: PASSED # Doing lxvh8x: PASSED # Doing lxvx: PASSED # Doing lxvwsx: FAILED: Wrong Data # Doing lxvl: PASSED # Doing lxvll: PASSED # Doing stxsd: PASSED # Doing stxsibx: PASSED # Doing stxsihx: PASSED # Doing stxssp: PASSED # Doing stxv: PASSED # Doing stxvb16x: PASSED # Doing stxvh8x: PASSED # Doing stxvx: PASSED # Doing stxvl: PASSED # Doing stxvll: PASSED # failure: test_alignment_handler_vsx_300 # [snip] # # Fix this by making sure all VSX instruction emulation correctly # load/store from the VSRs. # # Fixes: af99da74333b ("powerpc/sstep: Support VSX vector paired storage access instructions") # Signed-off-by: Jordan Niethe # Reviewed-by: Ravi Bangoria # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20210225031946.1458206-1-jniethe5@gmail.com # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 e3d773ddb5a1140780a15703b3e0e2618274cce9 # < make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_defconfig # < make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/include/linux/kernel.h:10:0, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/module.h:12, from /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:15: /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) ^ /kisskb/src/include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' # define unlikely(x) __builtin_expect(!!(x), 0) ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:139:6: note: in expansion of macro 'IS_ERR_VALUE' if (IS_ERR_VALUE(fep->ring_mem_addr)) ^ /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) INFO: Uncompressed kernel (size 0xd54950) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd54950) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd54950) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd54950) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd54950) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd54950) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd54950) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd54950) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd54950) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd54950) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd54950) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd54950) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd54950) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd54950) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd54950) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) INFO: Uncompressed kernel (size 0xd44224) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xe00000) Image Name: Linux-5.12.0-rc1-ge3d773ddb5a1 Created: Mon Mar 1 23:41:19 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6464640 Bytes = 6313.12 KiB = 6.17 MiB Load Address: 00e00000 Entry Point: 00e00314 Image Name: Linux-5.12.0-rc1-ge3d773ddb5a1 Created: Mon Mar 1 23:41:19 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6466442 Bytes = 6314.88 KiB = 6.17 MiB Load Address: 00e00000 Entry Point: 00e002a4 Image Name: Linux-5.12.0-rc1-ge3d773ddb5a1 Created: Mon Mar 1 23:41:19 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6436300 Bytes = 6285.45 KiB = 6.14 MiB Load Address: 00000000 Entry Point: 00000000 Image Name: Linux-5.12.0-rc1-ge3d773ddb5a1 Created: Mon Mar 1 23:41:19 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6464807 Bytes = 6313.29 KiB = 6.17 MiB Load Address: 00e00000 Entry Point: 00e00314 Image Name: Linux-5.12.0-rc1-ge3d773ddb5a1 Created: Mon Mar 1 23:41:19 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6464806 Bytes = 6313.29 KiB = 6.17 MiB Load Address: 00e00000 Entry Point: 00e00314 Image Name: Linux-5.12.0-rc1-ge3d773ddb5a1 Created: Mon Mar 1 23:41:19 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6464589 Bytes = 6313.08 KiB = 6.17 MiB Load Address: 00e00000 Entry Point: 00e00314 Image Name: Linux-5.12.0-rc1-ge3d773ddb5a1 Created: Mon Mar 1 23:41:19 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6464743 Bytes = 6313.23 KiB = 6.17 MiB Load Address: 00e00000 Entry Point: 00e002a4 Image Name: Linux-5.12.0-rc1-ge3d773ddb5a1 Created: Mon Mar 1 23:41:19 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6464462 Bytes = 6312.95 KiB = 6.16 MiB Load Address: 00e00000 Entry Point: 00e002a4 Image Name: Linux-5.12.0-rc1-ge3d773ddb5a1 Created: Mon Mar 1 23:41:19 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6467577 Bytes = 6315.99 KiB = 6.17 MiB Load Address: 00e00000 Entry Point: 00e002a4 Image Name: Linux-5.12.0-rc1-ge3d773ddb5a1 Created: Mon Mar 1 23:41:19 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6467660 Bytes = 6316.07 KiB = 6.17 MiB Load Address: 00e00000 Entry Point: 00e002a4 Image Name: Linux-5.12.0-rc1-ge3d773ddb5a1 Created: Mon Mar 1 23:41:19 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6467058 Bytes = 6315.49 KiB = 6.17 MiB Load Address: 00e00000 Entry Point: 00e002a4 Image Name: Linux-5.12.0-rc1-ge3d773ddb5a1 Created: Mon Mar 1 23:41:20 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6466857 Bytes = 6315.29 KiB = 6.17 MiB Load Address: 00e00000 Entry Point: 00e002a4 Image Name: Linux-5.12.0-rc1-ge3d773ddb5a1 Created: Mon Mar 1 23:41:20 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6464413 Bytes = 6312.90 KiB = 6.16 MiB Load Address: 00e00000 Entry Point: 00e002a4 Image Name: Linux-5.12.0-rc1-ge3d773ddb5a1 Created: Mon Mar 1 23:41:20 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6464772 Bytes = 6313.25 KiB = 6.17 MiB Load Address: 00e00000 Entry Point: 00e002a4 Image Name: Linux-5.12.0-rc1-ge3d773ddb5a1 Created: Mon Mar 1 23:41:20 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6464770 Bytes = 6313.25 KiB = 6.17 MiB Load Address: 00e00000 Entry Point: 00e002a4 Image Name: Linux-5.12.0-rc1-ge3d773ddb5a1 Created: Mon Mar 1 23:41:20 2021 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 6464587 Bytes = 6313.07 KiB = 6.17 MiB Load Address: 00e00000 Entry Point: 00e00314 Completed OK # rm -rf /kisskb/build/powerpc-fixes_mpc85xx_defconfig_powerpc-gcc5 # Build took: 0:02:47.963929